| Message ID | 20220830190048.67448-4-shentey@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Instantiate VT82xx functions in host device | expand |
On Tue, 30 Aug 2022, Bernhard Beschow wrote: > Unlike get_system_memory(), pci_address_space() respects the memory tree > available to the parent device. I don't know if this is correct but likely nothing will use it so probably does not break anything. Regards, BALATON Zoltan > Signed-off-by: Bernhard Beschow <shentey@gmail.com> > --- > hw/isa/vt82c686.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c > index 9d12e1cae4..5582c0b179 100644 > --- a/hw/isa/vt82c686.c > +++ b/hw/isa/vt82c686.c > @@ -589,7 +589,7 @@ static void via_isa_realize(PCIDevice *d, Error **errp) > > qdev_init_gpio_out(dev, &s->cpu_intr, 1); > isa_irq = qemu_allocate_irqs(via_isa_request_i8259_irq, s, 1); > - isa_bus = isa_bus_new(dev, get_system_memory(), pci_address_space_io(d), > + isa_bus = isa_bus_new(dev, pci_address_space(d), pci_address_space_io(d), > &error_fatal); > s->isa_irqs = i8259_init(isa_bus, *isa_irq); > isa_bus_irqs(isa_bus, s->isa_irqs); >
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 9d12e1cae4..5582c0b179 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@ -589,7 +589,7 @@ static void via_isa_realize(PCIDevice *d, Error **errp) qdev_init_gpio_out(dev, &s->cpu_intr, 1); isa_irq = qemu_allocate_irqs(via_isa_request_i8259_irq, s, 1); - isa_bus = isa_bus_new(dev, get_system_memory(), pci_address_space_io(d), + isa_bus = isa_bus_new(dev, pci_address_space(d), pci_address_space_io(d), &error_fatal); s->isa_irqs = i8259_init(isa_bus, *isa_irq); isa_bus_irqs(isa_bus, s->isa_irqs);
Unlike get_system_memory(), pci_address_space() respects the memory tree available to the parent device. Signed-off-by: Bernhard Beschow <shentey@gmail.com> --- hw/isa/vt82c686.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)