| Message ID | 1321141830.20271.22.camel@x61.thuisdomein (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | a92282524aee149de0014eef10a0771d1d19821f |
| Delegated to: | Kumar Gala |
| Headers | show |
On Sun, Nov 13, 2011 at 12:50:30AM +0100, Paul Bolle wrote: > The driver for the Freescale P3060 QDS got added by commit 96cc017c5b > ("[...] Add support for P3060QDS board"). Its Kconfig entry selects > MPC8xxx_GPIO. But at the time that driver got added MPC8xxx_GPIO was > already renamed to GPIO_MPC8XXX, by commit c68308dd50c ("gpio: move > mpc8xxx/512x gpio driver to drivers/gpio"). > > So make this driver select GPIO_MPC8XXX. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Acked-by: Wolfram Sang <w.sang@pengutronix.de> Thanks for catching this! > 2) The config tools do not complain about selects that cannot be met > because they concern a Kconfig symbol that doesn't even exist. Shouldn't > they be made to complain in that case? I'd think so. Regards, Wolfram
On Nov 12, 2011, at 5:50 PM, Paul Bolle wrote: > The driver for the Freescale P3060 QDS got added by commit 96cc017c5b > ("[...] Add support for P3060QDS board"). Its Kconfig entry selects > MPC8xxx_GPIO. But at the time that driver got added MPC8xxx_GPIO was > already renamed to GPIO_MPC8XXX, by commit c68308dd50c ("gpio: move > mpc8xxx/512x gpio driver to drivers/gpio"). > > So make this driver select GPIO_MPC8XXX. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > 0) Bravely untested: I haven't got the hardware nor the PPC toolchain > needed to build this. And it seems this needs (build) testing anyhow. > > 1) Sent to the people who wrote the two patches mentioned in the commit > explanation and CC'd the non-authors who signed-off these patches. > > 2) The config tools do not complain about selects that cannot be met > because they concern a Kconfig symbol that doesn't even exist. Shouldn't > they be made to complain in that case? > > arch/powerpc/platforms/85xx/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) applied to merge - k
diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig index 45023e2..d7946be 100644 --- a/arch/powerpc/platforms/85xx/Kconfig +++ b/arch/powerpc/platforms/85xx/Kconfig @@ -203,7 +203,7 @@ config P3060_QDS select PPC_E500MC select PHYS_64BIT select SWIOTLB - select MPC8xxx_GPIO + select GPIO_MPC8XXX select HAS_RAPIDIO select PPC_EPAPR_HV_PIC help
The driver for the Freescale P3060 QDS got added by commit 96cc017c5b ("[...] Add support for P3060QDS board"). Its Kconfig entry selects MPC8xxx_GPIO. But at the time that driver got added MPC8xxx_GPIO was already renamed to GPIO_MPC8XXX, by commit c68308dd50c ("gpio: move mpc8xxx/512x gpio driver to drivers/gpio"). So make this driver select GPIO_MPC8XXX. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- 0) Bravely untested: I haven't got the hardware nor the PPC toolchain needed to build this. And it seems this needs (build) testing anyhow. 1) Sent to the people who wrote the two patches mentioned in the commit explanation and CC'd the non-authors who signed-off these patches. 2) The config tools do not complain about selects that cannot be met because they concern a Kconfig symbol that doesn't even exist. Shouldn't they be made to complain in that case? arch/powerpc/platforms/85xx/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)