Message ID | ce5869418f5838187946eb6b11a52715a93ece3d.1657566849.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
---|---|
State | Handled Elsewhere, archived |
Headers | show |
Series | [1/2] cxl: Use the bitmap API to allocate bitmaps | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 23 jobs. |
snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
On Mon, 2022-07-11 at 21:14 +0200, Christophe JAILLET wrote: > A bitmap_zalloc() must be balanced by a corresponding bitmap_free() > in the > error handling path of afu_allocate_irqs(). > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Thanks for catching this. Acked-by: Andrew Donnellan <ajd@linux.ibm.com> > --- > The error handling path should be done in the reversed order but it > should > work as-is. > --- > drivers/misc/cxl/irq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c > index 0ce91d99aead..b730e022a48e 100644 > --- a/drivers/misc/cxl/irq.c > +++ b/drivers/misc/cxl/irq.c > @@ -349,6 +349,7 @@ int afu_allocate_irqs(struct cxl_context *ctx, > u32 count) > > out: > cxl_ops->release_irq_ranges(&ctx->irqs, ctx->afu->adapter); > + bitmap_free(ctx->irq_bitmap); > afu_irq_name_free(ctx); > return -ENOMEM; > }
diff --git a/drivers/misc/cxl/irq.c b/drivers/misc/cxl/irq.c index 0ce91d99aead..b730e022a48e 100644 --- a/drivers/misc/cxl/irq.c +++ b/drivers/misc/cxl/irq.c @@ -349,6 +349,7 @@ int afu_allocate_irqs(struct cxl_context *ctx, u32 count) out: cxl_ops->release_irq_ranges(&ctx->irqs, ctx->afu->adapter); + bitmap_free(ctx->irq_bitmap); afu_irq_name_free(ctx); return -ENOMEM; }
A bitmap_zalloc() must be balanced by a corresponding bitmap_free() in the error handling path of afu_allocate_irqs(). Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- The error handling path should be done in the reversed order but it should work as-is. --- drivers/misc/cxl/irq.c | 1 + 1 file changed, 1 insertion(+)