diff mbox series

[2/4] slirp: Update SlirpConfig version to 5

Message ID 20220616010526.1895564-3-pdel@fb.com
State New
Headers show
Series slirp: Update submodule to include NC-SI features | expand

Commit Message

Peter Delevoryas June 16, 2022, 1:05 a.m. UTC 
I think we probably need a new Slirp release
(4.8.0) and a switch statement here instead, right?

So that we can preserve the behavior for 4.7.0?

Signed-off-by: Peter Delevoryas <pdel@fb.com>
---
 net/slirp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Samuel Thibault June 18, 2022, 10:03 a.m. UTC | #1 
Hello,

Peter Delevoryas, le mer. 15 juin 2022 18:05:24 -0700, a ecrit:
> I think we probably need a new Slirp release
> (4.8.0) and a switch statement here instead, right?
> 
> So that we can preserve the behavior for 4.7.0?

Yes, that's the idea.

Samuel
Peter Delevoryas June 20, 2022, 9:33 p.m. UTC | #2 
> On Jun 18, 2022, at 3:03 AM, Samuel Thibault <samuel.thibault@gnu.org> wrote:
> 
> Hello,
> 
> Peter Delevoryas, le mer. 15 juin 2022 18:05:24 -0700, a ecrit:
>> I think we probably need a new Slirp release
>> (4.8.0) and a switch statement here instead, right?
>> 
>> So that we can preserve the behavior for 4.7.0?
> 
> Yes, that's the idea.

Ok great, thanks!

> 
> Samuel
diff mbox series

Patch

diff --git a/net/slirp.c b/net/slirp.c
index 8679be6444..75e5ccafd9 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -617,7 +617,7 @@  static int net_slirp_init(NetClientState *peer, const char *model,
 
     s = DO_UPCAST(SlirpState, nc, nc);
 
-    cfg.version = SLIRP_CHECK_VERSION(4,7,0) ? 4 : 1;
+    cfg.version = SLIRP_CHECK_VERSION(4, 7, 0) ? 5 : 1;
     cfg.restricted = restricted;
     cfg.in_enabled = ipv4;
     cfg.vnetwork = net;