| Message ID | 1321023211-34566-5-git-send-email-chenwj@iis.sinica.edu.tw |
|---|---|
| State | New |
| Headers | show |
On 11 November 2011 14:53, Chen Wei-Ren (陳韋任) <chenwj@iis.sinica.edu.tw> wrote: > Remove libqemu target from Makefile.target. > diff --git a/Makefile.target b/Makefile.target > index a111521..d1f7993 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -92,14 +92,6 @@ tci-dis.o: QEMU_CFLAGS += -I$(SRC_PATH)/tcg -I$(SRC_PATH)/tcg/tci > > $(libobj-y): $(GENERATED_HEADERS) > > -# libqemu > - > -translate.o: translate.c cpu.h > - > -translate-all.o: translate-all.c cpu.h > - > -tcg/tcg.o: cpu.h > - This commit isn't doing what the commit message claims it does. What you're actually removing is a set of manually inserted dependencies of some object files on their source files and on cpu.h. There is already no libqemu target in this makefile. What you maybe wanted to remove is just the now out of date comment line? Now, I think those manually inserted dependencies shouldn't be there, because the autogenerated .d files already cover the dependencies they specify as far as I can tell. But that would be a different commit entirely.) -- PMM
> This commit isn't doing what the commit message claims it does. > > What you're actually removing is a set of manually inserted > dependencies of some object files on their source files and > on cpu.h. There is already no libqemu target in this makefile. > What you maybe wanted to remove is just the now out of date > comment line? I thought the lines below "# libqemu" is related to libqemu.a , but it's apparently not. > Now, I think those manually inserted dependencies shouldn't > be there, because the autogenerated .d files already cover > the dependencies they specify as far as I can tell. You mean those *.d file under the build directory? > But that would be a different commit entirely.) I'll exclude those manually inserted dependencies from this series next time. Regards, chenwj
diff --git a/Makefile.target b/Makefile.target index a111521..d1f7993 100644 --- a/Makefile.target +++ b/Makefile.target @@ -92,14 +92,6 @@ tci-dis.o: QEMU_CFLAGS += -I$(SRC_PATH)/tcg -I$(SRC_PATH)/tcg/tci $(libobj-y): $(GENERATED_HEADERS) -# libqemu - -translate.o: translate.c cpu.h - -translate-all.o: translate-all.c cpu.h - -tcg/tcg.o: cpu.h - # HELPER_CFLAGS is used for all the code compiled with static register # variables op_helper.o ldst_helper.o user-exec.o: QEMU_CFLAGS += $(HELPER_CFLAGS)