Message ID | 20220520180109.8224-1-shentey@gmail.com |
---|---|
Headers | show |
Series | Random cleanup patches | expand |
Am 20. Mai 2022 18:01:09 UTC schrieb Bernhard Beschow <shentey@gmail.com>: >Ammends commit 9f73de8df0335c9387f4ee39e207a65a1615676f 'docs: rSTify >the "SubmitAPatch" wiki'. > >Cc: qemu-stable@nongnu.org >Signed-off-by: Bernhard Beschow <shentey@gmail.com> >--- > docs/devel/submitting-a-patch.rst | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst >index e51259eb9c..21ed52bd82 100644 >--- a/docs/devel/submitting-a-patch.rst >+++ b/docs/devel/submitting-a-patch.rst >@@ -18,9 +18,9 @@ one-shot fix, the bare minimum we ask is that: > <http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n297>`__ > policy.) ``git commit -s`` or ``git format-patch -s`` will add one. > - All contributions to QEMU must be **sent as patches** to the >- qemu-devel `mailing list <MailingLists>`__. Patch contributions >- should not be posted on the bug tracker, posted on forums, or >- externally hosted and linked to. (We have other mailing lists too, >+ qemu-devel `mailing list <https://wiki.qemu.org/Contribute/MailingLists>`__. >+ Patch contributions should not be posted on the bug tracker, posted on >+ forums, or externally hosted and linked to. (We have other mailing lists too, > but all patches must go to qemu-devel, possibly with a Cc: to another > list.) ``git send-email`` (`step-by-step setup > guide <https://git-send-email.io/>`__ and `hints and Ping
On 20/05/2022 19:00, Bernhard Beschow wrote: > v2: > * Omit removal of isa_connect_gpio_out() (Mark) > > v1: > This patch series contains random cleanups that I made while studying the code. > > Bernhard Beschow (10): > hw: Reuse TYPE_I8042 define > hw/audio/cs4231a: Const'ify global tables > hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro > hw/i386/pc: Unexport functions used only internally > hw/i386/pc: Remove orphan declarations > hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE > hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create() > accel/tcg/cpu-exec: Unexport dump_drift_info() > accel/tcg: Inline dump_opcount_info() and remove it > docs/devel: Fix link to developer mailing lists > > accel/tcg/cpu-exec.c | 4 ++-- > accel/tcg/translate-all.c | 5 ----- > docs/devel/submitting-a-patch.rst | 6 +++--- > hw/audio/cs4231a.c | 8 ++++---- > hw/i386/pc.c | 17 +++++++++++++---- > hw/net/fsl_etsec/etsec.c | 23 ----------------------- > hw/net/fsl_etsec/etsec.h | 7 ------- > hw/ppc/e500.c | 1 - > hw/sparc64/sun4u.c | 2 +- > include/exec/cpu-all.h | 3 --- > include/hw/i386/pc.h | 14 -------------- > 11 files changed, 23 insertions(+), 67 deletions(-) In general these changes look okay, so I'd be fine to give an: Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> for those I haven't already given a Reviewed-by tag for. Laurent, are you happy to take these patches with their current tags via qemu-trivial? Or would you prefer an extra set of eyes on the two accel/tcg ones first? ATB, Mark.
On 5/21/22 06:55, Mark Cave-Ayland wrote: > On 20/05/2022 19:00, Bernhard Beschow wrote: > >> v2: >> * Omit removal of isa_connect_gpio_out() (Mark) >> >> v1: >> This patch series contains random cleanups that I made while studying the code. >> >> Bernhard Beschow (10): >> hw: Reuse TYPE_I8042 define >> hw/audio/cs4231a: Const'ify global tables >> hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro >> hw/i386/pc: Unexport functions used only internally >> hw/i386/pc: Remove orphan declarations >> hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE >> hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create() >> accel/tcg/cpu-exec: Unexport dump_drift_info() >> accel/tcg: Inline dump_opcount_info() and remove it >> docs/devel: Fix link to developer mailing lists >> >> accel/tcg/cpu-exec.c | 4 ++-- >> accel/tcg/translate-all.c | 5 ----- >> docs/devel/submitting-a-patch.rst | 6 +++--- >> hw/audio/cs4231a.c | 8 ++++---- >> hw/i386/pc.c | 17 +++++++++++++---- >> hw/net/fsl_etsec/etsec.c | 23 ----------------------- >> hw/net/fsl_etsec/etsec.h | 7 ------- >> hw/ppc/e500.c | 1 - >> hw/sparc64/sun4u.c | 2 +- >> include/exec/cpu-all.h | 3 --- >> include/hw/i386/pc.h | 14 -------------- >> 11 files changed, 23 insertions(+), 67 deletions(-) > > In general these changes look okay, so I'd be fine to give an: > > Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> > > for those I haven't already given a Reviewed-by tag for. > > Laurent, are you happy to take these patches with their current tags via qemu-trivial? Or would you prefer an extra set of eyes on the two accel/tcg ones first? BTW I'll send a PR later this week and I was about to queue patch 06 (hw/ppc/e500 change) via the ppc tree. Let me know if you want to queue the whole series via qemu-trivial instead. Thanks, Daniel > > > ATB, > > Mark. >
On Sat, May 21, 2022 at 11:55 AM Mark Cave-Ayland < mark.cave-ayland@ilande.co.uk> wrote: > On 20/05/2022 19:00, Bernhard Beschow wrote: > > > v2: > > * Omit removal of isa_connect_gpio_out() (Mark) > > > > v1: > > This patch series contains random cleanups that I made while studying > the code. > > > > Bernhard Beschow (10): > > hw: Reuse TYPE_I8042 define > > hw/audio/cs4231a: Const'ify global tables > > hw/i386/pc: Unexport PC_CPU_MODEL_IDS macro > > hw/i386/pc: Unexport functions used only internally > > hw/i386/pc: Remove orphan declarations > > hw/ppc/e500: Remove unused BINARY_DEVICE_TREE_FILE > > hw/net/fsl_etsec/etsec: Remove obsolete and unused etsec_create() > > accel/tcg/cpu-exec: Unexport dump_drift_info() > > accel/tcg: Inline dump_opcount_info() and remove it > > docs/devel: Fix link to developer mailing lists > > > > accel/tcg/cpu-exec.c | 4 ++-- > > accel/tcg/translate-all.c | 5 ----- > > docs/devel/submitting-a-patch.rst | 6 +++--- > > hw/audio/cs4231a.c | 8 ++++---- > > hw/i386/pc.c | 17 +++++++++++++---- > > hw/net/fsl_etsec/etsec.c | 23 ----------------------- > > hw/net/fsl_etsec/etsec.h | 7 ------- > > hw/ppc/e500.c | 1 - > > hw/sparc64/sun4u.c | 2 +- > > include/exec/cpu-all.h | 3 --- > > include/hw/i386/pc.h | 14 -------------- > > 11 files changed, 23 insertions(+), 67 deletions(-) > > In general these changes look okay, so I'd be fine to give an: > > Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> > > for those I haven't already given a Reviewed-by tag for. > > Laurent, are you happy to take these patches with their current tags via > qemu-trivial? Or would you prefer an extra set of eyes on the two > accel/tcg ones first? > Ping > ATB, > > Mark. >