Message ID | 4EB743CB.10403@cn.fujitsu.com |
---|---|
State | New |
Headers | show |
Wen Congyang <wency@cn.fujitsu.com> wrote: > We set s->mon to NULL in migrate_init. But we will use it > to search fd when do fd-migration, and it will cause qemu > crashed. > > Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> > > --- > migration.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/migration.c b/migration.c > index 4b17566..d094381 100644 > --- a/migration.c > +++ b/migration.c > @@ -383,7 +383,7 @@ static MigrationState *migrate_init(Monitor *mon, int detach, int blk, int inc) > s->bandwidth_limit = bandwidth_limit; > s->blk = blk; > s->shared = inc; > - s->mon = NULL; > + s->mon = mon; > s->bandwidth_limit = bandwidth_limit; > s->state = MIG_STATE_SETUP; Problem is real. Patch is wrong, because now we "resume" the monitor even when we are doing detached migration. Looking into it. Thanks, Juan.
diff --git a/migration.c b/migration.c index 4b17566..d094381 100644 --- a/migration.c +++ b/migration.c @@ -383,7 +383,7 @@ static MigrationState *migrate_init(Monitor *mon, int detach, int blk, int inc) s->bandwidth_limit = bandwidth_limit; s->blk = blk; s->shared = inc; - s->mon = NULL; + s->mon = mon; s->bandwidth_limit = bandwidth_limit; s->state = MIG_STATE_SETUP;
We set s->mon to NULL in migrate_init. But we will use it to search fd when do fd-migration, and it will cause qemu crashed. Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> --- migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)