| Message ID | 20220221020323.1925215-1-chi.minghao@zte.com.cn (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | platforms/83xx: Use of_device_get_match_data() | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | fail | boot (ppc64le_guest_defconfig, pseries+p8+tcg, pseries+p9+tcg, qemu-system-ppc64, ppc64le-rootfs.... failed at step Run qemu-pseries+p9+tcg with fedora-34 build kernel. |
Le 21/02/2022 à 03:03, cgel.zte@gmail.com a écrit : > From: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn> > > Use of_device_get_match_data() to simplify the code. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn> > --- > arch/powerpc/platforms/83xx/suspend.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/arch/powerpc/platforms/83xx/suspend.c b/arch/powerpc/platforms/83xx/suspend.c > index bb147d34d4a6..9ae9268b683c 100644 > --- a/arch/powerpc/platforms/83xx/suspend.c > +++ b/arch/powerpc/platforms/83xx/suspend.c > @@ -322,17 +322,12 @@ static const struct platform_suspend_ops mpc83xx_suspend_ops = { > static const struct of_device_id pmc_match[]; > static int pmc_probe(struct platform_device *ofdev) > { > - const struct of_device_id *match; > struct device_node *np = ofdev->dev.of_node; > struct resource res; > const struct pmc_type *type; > int ret = 0; > > - match = of_match_device(pmc_match, &ofdev->dev); > - if (!match) > - return -EINVAL; > - > - type = match->data; > + type = of_device_get_match_data(&ofdev->dev); What happens when of_device_get_match_data() returns NULL ? > > if (!of_device_is_available(np)) > return -ENODEV;
Resending as I accidentaly sent my response to the list only. Le 21/02/2022 à 03:03, cgel.zte@gmail.com a écrit : > From: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn> > > Use of_device_get_match_data() to simplify the code. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn> > --- > arch/powerpc/platforms/83xx/suspend.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/arch/powerpc/platforms/83xx/suspend.c b/arch/powerpc/platforms/83xx/suspend.c > index bb147d34d4a6..9ae9268b683c 100644 > --- a/arch/powerpc/platforms/83xx/suspend.c > +++ b/arch/powerpc/platforms/83xx/suspend.c > @@ -322,17 +322,12 @@ static const struct platform_suspend_ops mpc83xx_suspend_ops = { > static const struct of_device_id pmc_match[]; > static int pmc_probe(struct platform_device *ofdev) > { > - const struct of_device_id *match; > struct device_node *np = ofdev->dev.of_node; > struct resource res; > const struct pmc_type *type; > int ret = 0; > > - match = of_match_device(pmc_match, &ofdev->dev); > - if (!match) > - return -EINVAL; > - > - type = match->data; > + type = of_device_get_match_data(&ofdev->dev); What happens when of_device_get_match_data() returns NULL ? > > if (!of_device_is_available(np)) > return -ENODEV;
diff --git a/arch/powerpc/platforms/83xx/suspend.c b/arch/powerpc/platforms/83xx/suspend.c index bb147d34d4a6..9ae9268b683c 100644 --- a/arch/powerpc/platforms/83xx/suspend.c +++ b/arch/powerpc/platforms/83xx/suspend.c @@ -322,17 +322,12 @@ static const struct platform_suspend_ops mpc83xx_suspend_ops = { static const struct of_device_id pmc_match[]; static int pmc_probe(struct platform_device *ofdev) { - const struct of_device_id *match; struct device_node *np = ofdev->dev.of_node; struct resource res; const struct pmc_type *type; int ret = 0; - match = of_match_device(pmc_match, &ofdev->dev); - if (!match) - return -EINVAL; - - type = match->data; + type = of_device_get_match_data(&ofdev->dev); if (!of_device_is_available(np)) return -ENODEV;