| Message ID | 20081108175254.GA6444@oksana.dev.rtsoft.ru (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 068e8c9d02ee37c44a4d65279b3ae8188fb09e18 |
| Delegated to: | Kumar Gala |
| Headers | show |
On Sat, Nov 08, 2008 at 08:52:54PM +0300, Anton Vorontsov wrote: > Boards should know when QE_USB is used, so that they can configure USB > clocks and pins. > > Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE, > but selects are evil since they don't support dependencies. Can anyone explain *why* select ignores dependencies, rather than recursively enabling the dependencies (and giving an error if it can't, or if a dependency has an || in it and is unmet)? -Scott
On Sat, Nov 08, 2008 at 08:52:54PM +0300, Anton Vorontsov wrote: > Boards should know when QE_USB is used, so that they can configure USB > clocks and pins. > > Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE, > but selects are evil since they don't support dependencies. > > While at it, also remove 'host' from the symbol description, since the > QE_USB code is used to support the gadget driver as well. > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > --- Anything wrong with this one? Thanks, > arch/powerpc/sysdev/qe_lib/Kconfig | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig > index 76ffbc4..41ac3df 100644 > --- a/arch/powerpc/sysdev/qe_lib/Kconfig > +++ b/arch/powerpc/sysdev/qe_lib/Kconfig > @@ -22,5 +22,6 @@ config UCC > > config QE_USB > bool > + default y if USB_GADGET_FSL_QE > help > - QE USB Host Controller support > + QE USB Controller support > -- > 1.5.6.3 > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev
On Wed, Dec 03, 2008 at 10:33:27PM +0300, Anton Vorontsov wrote: > On Sat, Nov 08, 2008 at 08:52:54PM +0300, Anton Vorontsov wrote: > > Boards should know when QE_USB is used, so that they can configure USB > > clocks and pins. > > > > Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE, > > but selects are evil since they don't support dependencies. > > > > While at it, also remove 'host' from the symbol description, since the > > QE_USB code is used to support the gadget driver as well. > > > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > > --- > > Anything wrong with this one? Without this patch QE UDC won't work (board file won't configure the USB clocks and pins). Thanks, > > arch/powerpc/sysdev/qe_lib/Kconfig | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig > > index 76ffbc4..41ac3df 100644 > > --- a/arch/powerpc/sysdev/qe_lib/Kconfig > > +++ b/arch/powerpc/sysdev/qe_lib/Kconfig > > @@ -22,5 +22,6 @@ config UCC > > > > config QE_USB > > bool > > + default y if USB_GADGET_FSL_QE > > help > > - QE USB Host Controller support > > + QE USB Controller support > > -- > > 1.5.6.3
On Nov 8, 2008, at 11:52 AM, Anton Vorontsov wrote: > Boards should know when QE_USB is used, so that they can configure USB > clocks and pins. > > Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE, > but selects are evil since they don't support dependencies. > > While at it, also remove 'host' from the symbol description, since the > QE_USB code is used to support the gadget driver as well. > > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> > --- > arch/powerpc/sysdev/qe_lib/Kconfig | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) applied to next - k
diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig index 76ffbc4..41ac3df 100644 --- a/arch/powerpc/sysdev/qe_lib/Kconfig +++ b/arch/powerpc/sysdev/qe_lib/Kconfig @@ -22,5 +22,6 @@ config UCC config QE_USB bool + default y if USB_GADGET_FSL_QE help - QE USB Host Controller support + QE USB Controller support
Boards should know when QE_USB is used, so that they can configure USB clocks and pins. Another option would be to add 'select QE_USB' into USB_GADGET_FSL_QE, but selects are evil since they don't support dependencies. While at it, also remove 'host' from the symbol description, since the QE_USB code is used to support the gadget driver as well. Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> --- arch/powerpc/sysdev/qe_lib/Kconfig | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)