| Message ID | 20220111173723.26212-1-bigunclemax@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2] powerpc: dts: t1040rdb: fix ports names for Seville Ethernet switch | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
On Tue, Jan 11, 2022 at 08:37:23PM +0300, Maxim wrote: > From: Maxim Kiselev <bigunclemax@gmail.com> > > On board rev A, the network interface labels for the switch ports > written on the front panel are different than on rev B and later. > > This patch fixes network interface names for the switch ports according > to labels that are written on the front panel of the board rev B. > They start from ETH3 and end at ETH10. > > This patch also introduces a separate device tree for rev A. > The main device tree is supposed to cover rev B and later. > > Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com> > Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru> > --- Fixes: e69eb0824d8c ("powerpc: dts: t1040rdb: add ports for Seville Ethernet switch") Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Maxim <bigunclemax@gmail.com> writes: > From: Maxim Kiselev <bigunclemax@gmail.com> > > On board rev A, the network interface labels for the switch ports > written on the front panel are different than on rev B and later. > > This patch fixes network interface names for the switch ports according > to labels that are written on the front panel of the board rev B. > They start from ETH3 and end at ETH10. > > This patch also introduces a separate device tree for rev A. > The main device tree is supposed to cover rev B and later. > > Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com> > Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru> > --- > arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts | 30 ++++++++++++++++++++ > arch/powerpc/boot/dts/fsl/t1040rdb.dts | 8 +++--- > 2 files changed, 34 insertions(+), 4 deletions(-) > create mode 100644 arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts I applied this but it generated errors, you should have got some reports from the kernel build robot. cheers
diff --git a/arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts b/arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts new file mode 100644 index 00000000000..2203286b64b --- /dev/null +++ b/arch/powerpc/boot/dts/fsl/t1040rdb-rev-a.dts @@ -0,0 +1,30 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * T1040RDB-REV-A Device Tree Source + * + * Copyright 2014 - 2015 Freescale Semiconductor Inc. + * + */ + +/include/ "t1040rdb.dts" + +/ { + model = "fsl,T1040RDB-REV-A"; + compatible = "fsl,T1040RDB-REV-A"; +}; + +&seville_port0 { + label = "ETH5"; +}; + +&seville_port2 { + label = "ETH7"; +}; + +&seville_port4 { + label = "ETH9"; +}; + +&seville_port6 { + label = "ETH11"; +}; diff --git a/arch/powerpc/boot/dts/fsl/t1040rdb.dts b/arch/powerpc/boot/dts/fsl/t1040rdb.dts index af0c8a6f561..b6733e7e658 100644 --- a/arch/powerpc/boot/dts/fsl/t1040rdb.dts +++ b/arch/powerpc/boot/dts/fsl/t1040rdb.dts @@ -119,7 +119,7 @@ &seville_port0 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_0>; phy-mode = "qsgmii"; - label = "ETH5"; + label = "ETH3"; status = "okay"; }; @@ -135,7 +135,7 @@ &seville_port2 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_2>; phy-mode = "qsgmii"; - label = "ETH7"; + label = "ETH5"; status = "okay"; }; @@ -151,7 +151,7 @@ &seville_port4 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_4>; phy-mode = "qsgmii"; - label = "ETH9"; + label = "ETH7"; status = "okay"; }; @@ -167,7 +167,7 @@ &seville_port6 { managed = "in-band-status"; phy-handle = <&phy_qsgmii_6>; phy-mode = "qsgmii"; - label = "ETH11"; + label = "ETH9"; status = "okay"; };