Message ID | 20211216220035.605465-1-nick.child@ibm.com (mailing list archive) |
---|---|
Headers | show |
Series | powerpc: Define eligible functions as __init | expand |
Le 16/12/2021 à 23:00, Nick Child a écrit : > > Changes in v2: > - add `__init` in prototypes right before the funtion name instead of > at the end. > - respond to ./scripts/checkpatch feedback You probably missed the following comment from checkpatch: WARNING: From:/Signed-off-by: email address mismatch: 'From: Nick Child <nnac123@gmail.com>' != 'Signed-off-by: Nick Child <nick.child@ibm.com>' Sending from a different address is possible, but you then must add From: Nick Child <nick.child@ibm.com> at the top of the commit message. 'git format-patch' should be able to do it for you with the good option. Christophe
Christophe Leroy <christophe.leroy@csgroup.eu> writes: > Le 16/12/2021 à 23:00, Nick Child a écrit : >> >> Changes in v2: >> - add `__init` in prototypes right before the funtion name instead of >> at the end. >> - respond to ./scripts/checkpatch feedback > > You probably missed the following comment from checkpatch: > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Nick Child > <nnac123@gmail.com>' != 'Signed-off-by: Nick Child <nick.child@ibm.com>' I fixed it up when applying to use Nick's IBM address as the author. > Sending from a different address is possible, but you then must add > > From: Nick Child <nick.child@ibm.com> > > at the top of the commit message. > > 'git format-patch' should be able to do it for you with the good option. Yeah, Nick please teach git format-patch/send-email to use the right address for future series. If you need any help just let me know. cheers
On Thu, 16 Dec 2021 17:00:15 -0500, Nick Child wrote: > This patchset focuses on redefining/declaring functions that could be > labeled with the macro `__init`. From my understanding, an > initialization function is one which is only needed during the initial > phases of booting, after which it's resources can be freed. I figure > that any function which is only called by other initialization > functions may also be labeled as an initialization function. There are > several (mostly static) functions which can and should be labeled as > `__init`. I created some scripts to help identify these functions. It > scans all functions defined in `arch/powerpc` and, if it is only called > by functions with the `__init` attribute, it will go on to adjust the > prototype and definition to include the `__init` declaration. This > patchset hopes to solve related issue #282: > https://github.com/linuxppc/issues/issues/282 > > [...] Applied to powerpc/next. [01/20] powerpc/kernel: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/d276960d9296b6a9074795fe60a513abf8474e35 [02/20] powerpc/lib: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/ce0c6be9c69883df38e7631d1d7364b52f6db135 [03/20] powerpc/mm: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/c13f2b2bb5afd90f152c389c1c9245a0d43bce80 [04/20] powerpc/perf: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/c49f5d88ff0166ffa4e48ee8ce84d63719f346be [05/20] powerpc/sysdev: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/6c552983d0e65a8c923dfacc4f69b694205672c1 [06/20] powerpc/xmon: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/456e8eb324a47573b377f7041f4c038fac403f86 [07/20] powerpc/cell: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/7c1ab16b2d035c6bc3b6b6980ab7e72f547edc45 [08/20] powerpc/chrp: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/d3aa3c5edf0cb7ac0b0b5b0d144bba60b0ee77da [09/20] powerpc/pasemi: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/e37e06af9b0d6b7828159455d33f8ef45c456460 [10/20] powerpc/powermac: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/b346f57100e9417f23ee9051f0efe621a492be96 [11/20] powerpc/powernv: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/e5913db1ef22817e128f0a794752f7393205e00b [12/20] powerpc/pseries: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/e14ff96d08f0ade9dd33081d909ad65a02a858c1 [13/20] powerpc/ps3: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/f1ba9b9474a9e32b9c173c91e71f713bfa7b2463 [14/20] powerpc/4xx: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/1e3d992d213928851f7ddec6f150fb54fe759b64 [15/20] powerpc/44x: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/1ee969be25ed21a1192ca569ad827013eb7fac04 [16/20] powerpc/embedded6xx: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/c0dc225ae7dd9f01d46ea779f7f169d49aa59b78 [17/20] powerpc/83xx: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/f4a88b0ef5c5f7ce218aced7d811a31dd311a0b0 [18/20] powerpc/85xx: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/407454cafd3f1878dae6bb839d8bac2db264300f [19/20] powerpc/512x: Add __init attribute to eligible functions https://git.kernel.org/powerpc/c/2493a24271dab3d5c1235a13cf6ee2d12773c9a1 [20/20] cuda/pmu: Make find_via_cuda/pmu init functions https://git.kernel.org/powerpc/c/7da1d1ddd1f02e5de7497a0c849256912652fb6c cheers