| Message ID | 163941374362.36967.18016981579099073379.sendpatchset@1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | selftests/powerpc: skip tests for unavailable mitigations. | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
| snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
| snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
| snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
On 13/12/21 10:12 pm, Sachin Sant wrote: > Mitigation patching test iterates over a set of mitigations irrespective > of whether a certain mitigation is supported/available in the kernel. > This causes following messages on a kernel where some mitigations > are unavailable: > > Spawned threads enabling/disabling mitigations ... > cat: entry_flush: No such file or directory > cat: uaccess_flush: No such file or directory > Waiting for timeout ... > OK > > This patch adds a check for available mitigations in the kernel. > > Reported-by: Nageswara R Sastry <rnsastry@linux.ibm.com> > Signed-off-by: Sachin Sant <sachinp@linux.vnet.ibm.com> Tested-by: Nageswara R Sastry <rnsastry@linux.ibm.com> > --- > diff -Naurp aa/tools/testing/selftests/powerpc/security/mitigation-patching.sh bb/tools/testing/selftests/powerpc/security/mitigation-patching.sh > --- aa/tools/testing/selftests/powerpc/security/mitigation-patching.sh 2021-12-13 10:17:05.714127154 -0500 > +++ bb/tools/testing/selftests/powerpc/security/mitigation-patching.sh 2021-12-13 10:19:32.575315913 -0500 > @@ -44,7 +44,10 @@ mitigations="barrier_nospec stf_barrier > > for m in $mitigations > do > - do_one "$m" & > + if [[ -f /sys/kernel/debug/powerpc/$m ]] > + then > + do_one "$m" & > + fi > done > > echo "Spawned threads enabling/disabling mitigations ..."
On Mon, 2021-12-13 at 22:12 +0530, Sachin Sant wrote: > Mitigation patching test iterates over a set of mitigations > irrespective > of whether a certain mitigation is supported/available in the kernel. > This causes following messages on a kernel where some mitigations > are unavailable: > > Spawned threads enabling/disabling mitigations ... > cat: entry_flush: No such file or directory > cat: uaccess_flush: No such file or directory > Waiting for timeout ... > OK > > This patch adds a check for available mitigations in the kernel. > > Reported-by: Nageswara R Sastry <rnsastry@linux.ibm.com> > Signed-off-by: Sachin Sant <sachinp@linux.vnet.ibm.com> Reviewed-by: Russell Currey <ruscur@russell.cc>
On Mon, 13 Dec 2021 22:12:23 +0530, Sachin Sant wrote: > Mitigation patching test iterates over a set of mitigations irrespective > of whether a certain mitigation is supported/available in the kernel. > This causes following messages on a kernel where some mitigations > are unavailable: > > Spawned threads enabling/disabling mitigations ... > cat: entry_flush: No such file or directory > cat: uaccess_flush: No such file or directory > Waiting for timeout ... > OK > > [...] Applied to powerpc/next. [1/1] selftests/powerpc: skip tests for unavailable mitigations. https://git.kernel.org/powerpc/c/18678591846d668649fbd4f87b4a4c470818d386 cheers
diff -Naurp aa/tools/testing/selftests/powerpc/security/mitigation-patching.sh bb/tools/testing/selftests/powerpc/security/mitigation-patching.sh --- aa/tools/testing/selftests/powerpc/security/mitigation-patching.sh 2021-12-13 10:17:05.714127154 -0500 +++ bb/tools/testing/selftests/powerpc/security/mitigation-patching.sh 2021-12-13 10:19:32.575315913 -0500 @@ -44,7 +44,10 @@ mitigations="barrier_nospec stf_barrier for m in $mitigations do - do_one "$m" & + if [[ -f /sys/kernel/debug/powerpc/$m ]] + then + do_one "$m" & + fi done echo "Spawned threads enabling/disabling mitigations ..."
Mitigation patching test iterates over a set of mitigations irrespective of whether a certain mitigation is supported/available in the kernel. This causes following messages on a kernel where some mitigations are unavailable: Spawned threads enabling/disabling mitigations ... cat: entry_flush: No such file or directory cat: uaccess_flush: No such file or directory Waiting for timeout ... OK This patch adds a check for available mitigations in the kernel. Reported-by: Nageswara R Sastry <rnsastry@linux.ibm.com> Signed-off-by: Sachin Sant <sachinp@linux.vnet.ibm.com> ---