Message ID | 1635406102-88719-1-git-send-email-cuibixuan@linux.alibaba.com (mailing list archive) |
---|---|
State | Accepted |
Headers | show |
Series | [-next] powerpc/44x/fsp2: add missing of_node_put | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/github-powerpc_ppctests | success | Successfully ran 8 jobs. |
snowpatch_ozlabs/github-powerpc_selftests | success | Successfully ran 8 jobs. |
snowpatch_ozlabs/github-powerpc_sparse | success | Successfully ran 4 jobs. |
snowpatch_ozlabs/github-powerpc_clang | success | Successfully ran 7 jobs. |
snowpatch_ozlabs/github-powerpc_kernel_qemu | success | Successfully ran 24 jobs. |
On Thu, 28 Oct 2021 15:28:22 +0800, Bixuan Cui wrote: > Early exits from for_each_compatible_node() should decrement the > node reference counter. Reported by Coccinelle: > > ./arch/powerpc/platforms/44x/fsp2.c:206:1-25: WARNING: Function > "for_each_compatible_node" should have of_node_put() before return > around line 218. > > [...] Applied to powerpc/next. [1/1] powerpc/44x/fsp2: add missing of_node_put https://git.kernel.org/powerpc/c/290fe8aa69ef5c51c778c0bb33f8ef0181c769f5 cheers
在 2021/11/2 下午6:12, Michael Ellerman 写道: >> Early exits from for_each_compatible_node() should decrement the >> node reference counter. Reported by Coccinelle: >> >> ./arch/powerpc/platforms/44x/fsp2.c:206:1-25: WARNING: Function >> "for_each_compatible_node" should have of_node_put() before return >> around line 218. >> >> [...] > Applied to powerpc/next. > > [1/1] powerpc/44x/fsp2: add missing of_node_put > https://git.kernel.org/powerpc/c/290fe8aa69ef5c51c778c0bb33f8ef0181c769f5 Thanks. :-) Bixuan Cui
diff --git a/arch/powerpc/platforms/44x/fsp2.c b/arch/powerpc/platforms/44x/fsp2.c index b299e43..823397c 100644 --- a/arch/powerpc/platforms/44x/fsp2.c +++ b/arch/powerpc/platforms/44x/fsp2.c @@ -208,6 +208,7 @@ static void node_irq_request(const char *compat, irq_handler_t errirq_handler) if (irq == NO_IRQ) { pr_err("device tree node %pOFn is missing a interrupt", np); + of_node_put(np); return; } @@ -215,6 +216,7 @@ static void node_irq_request(const char *compat, irq_handler_t errirq_handler) if (rc) { pr_err("fsp_of_probe: request_irq failed: np=%pOF rc=%d", np, rc); + of_node_put(np); return; } }
Early exits from for_each_compatible_node() should decrement the node reference counter. Reported by Coccinelle: ./arch/powerpc/platforms/44x/fsp2.c:206:1-25: WARNING: Function "for_each_compatible_node" should have of_node_put() before return around line 218. Fixes: 7813043e1bbc ("powerpc/44x/fsp2: Add irq error handlers") Signed-off-by: Bixuan Cui <cuibixuan@linux.alibaba.com> --- arch/powerpc/platforms/44x/fsp2.c | 2 ++ 1 file changed, 2 insertions(+)