diff mbox series

powerpc/kexec: fix for_each_child.cocci warning

Message ID alpine.DEB.2.22.394.2108031654080.17639@hadrien (mailing list archive)
State Accepted
Headers show
Series powerpc/kexec: fix for_each_child.cocci warning | expand

Commit Message

Julia Lawall Aug. 3, 2021, 2:59 p.m. UTC 
From: kernel test robot <lkp@intel.com>

for_each_node_by_type should have of_node_put() before return.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Sumera Priyadarsini <sylphrenadin@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

The code seems to have been this way since the beginning of time.  Perhaps
the of_node_put is a no op for this code?

 core_64.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Michael Ellerman Aug. 18, 2021, 1:38 p.m. UTC | #1 
On Tue, 3 Aug 2021 16:59:55 +0200 (CEST), Julia Lawall wrote:
> for_each_node_by_type should have of_node_put() before return.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Applied to powerpc/next.

[1/1] powerpc/kexec: fix for_each_child.cocci warning
      https://git.kernel.org/powerpc/c/c00103abf76fd3916596afd07dd3fdeee0dca15d

cheers
diff mbox series

Patch

--- a/arch/powerpc/kexec/core_64.c
+++ b/arch/powerpc/kexec/core_64.c
@@ -64,8 +64,10 @@  int default_machine_kexec_prepare(struct
 			begin = image->segment[i].mem;
 			end = begin + image->segment[i].memsz;

-			if ((begin < high) && (end > low))
+			if ((begin < high) && (end > low)) {
+				of_node_put(node);
 				return -ETXTBSY;
+			}
 		}
 	}