| Message ID | 20210519095044.4109-4-linkmauve@linkmauve.fr (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP | expand |
| Related | show |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (3a81c0495fdb91fd9a9b4f617098c283131eeae1) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 11 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On Wed, May 19, 2021 at 11:50:43AM +0200, Emmanuel Gil Peyrot wrote: > This can be used by the newly-added nintendo-otp nvmem module. > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > --- > arch/powerpc/boot/dts/wii.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/powerpc/boot/dts/wii.dts b/arch/powerpc/boot/dts/wii.dts > index aaa381da1906..7837c4a3f09c 100644 > --- a/arch/powerpc/boot/dts/wii.dts > +++ b/arch/powerpc/boot/dts/wii.dts > @@ -219,6 +219,11 @@ control@d800100 { > reg = <0x0d800100 0x300>; > }; > > + otp@d8001ec { > + compatible = "nintendo,hollywood-otp"; > + reg = <0x0d8001ec 0x8>; The OTP registers overlap with the previous node, control@d800100. Not sure what's the best way to structure the devicetree in this case, maybe something roughly like the following (untested, unverified): control@d800100 { compatible = "nintendo,hollywood-control", "simple-mfd"; reg = <0x0d800100 0x300>; ranges; otp@d8001ec { compatible = "nintendo,hollywood-otp"; reg = <0x0d8001ec 0x8>; }; }; Thanks, Jonathan Neuschäfer
On Sat, Jun 26, 2021 at 11:34:01PM +0000, Jonathan Neuschäfer wrote: > On Wed, May 19, 2021 at 11:50:43AM +0200, Emmanuel Gil Peyrot wrote: > > This can be used by the newly-added nintendo-otp nvmem module. > > > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > > --- > > arch/powerpc/boot/dts/wii.dts | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/powerpc/boot/dts/wii.dts b/arch/powerpc/boot/dts/wii.dts > > index aaa381da1906..7837c4a3f09c 100644 > > --- a/arch/powerpc/boot/dts/wii.dts > > +++ b/arch/powerpc/boot/dts/wii.dts > > @@ -219,6 +219,11 @@ control@d800100 { > > reg = <0x0d800100 0x300>; > > }; > > > > + otp@d8001ec { > > + compatible = "nintendo,hollywood-otp"; > > + reg = <0x0d8001ec 0x8>; > > The OTP registers overlap with the previous node, control@d800100. > Not sure what's the best way to structure the devicetree in this case, > maybe something roughly like the following (untested, unverified): [snip] I couldn’t get this to work, but additionally it looks like it should start 0x100 earlier and contain pic1@d800030 and gpio@d8000c0, given https://wiibrew.org/wiki/Hardware/Hollywood_Registers Would it make sense, for the time being, to reduce the size of this control@d800100 device to the single register currently being used by arch/powerpc/platforms/embedded6xx/wii.c (0xd800194, used to reboot the system) and leave the refactor of restart + OTP + PIC + GPIO for a future series? Thanks,
On Thu, Jul 01, 2021 at 09:56:55PM +0200, Emmanuel Gil Peyrot wrote: > On Sat, Jun 26, 2021 at 11:34:01PM +0000, Jonathan Neuschäfer wrote: > > On Wed, May 19, 2021 at 11:50:43AM +0200, Emmanuel Gil Peyrot wrote: [...] > > > + otp@d8001ec { > > > + compatible = "nintendo,hollywood-otp"; > > > + reg = <0x0d8001ec 0x8>; > > > > The OTP registers overlap with the previous node, control@d800100. > > Not sure what's the best way to structure the devicetree in this case, > > maybe something roughly like the following (untested, unverified): > [snip] > > I couldn’t get this to work, but additionally it looks like it should > start 0x100 earlier and contain pic1@d800030 and gpio@d8000c0, given > https://wiibrew.org/wiki/Hardware/Hollywood_Registers > > Would it make sense, for the time being, to reduce the size of this > control@d800100 device to the single register currently being used by > arch/powerpc/platforms/embedded6xx/wii.c (0xd800194, used to reboot the > system) and leave the refactor of restart + OTP + PIC + GPIO for a > future series? Makes sense to me! Jonathan
On Fri, Jul 02, 2021 at 08:56:31AM +0000, Jonathan Neuschäfer wrote: > On Thu, Jul 01, 2021 at 09:56:55PM +0200, Emmanuel Gil Peyrot wrote: > > On Sat, Jun 26, 2021 at 11:34:01PM +0000, Jonathan Neuschäfer wrote: > > > On Wed, May 19, 2021 at 11:50:43AM +0200, Emmanuel Gil Peyrot wrote: > [...] > > > > + otp@d8001ec { > > > > + compatible = "nintendo,hollywood-otp"; > > > > + reg = <0x0d8001ec 0x8>; > > > > > > The OTP registers overlap with the previous node, control@d800100. > > > Not sure what's the best way to structure the devicetree in this case, > > > maybe something roughly like the following (untested, unverified): > > [snip] > > > > I couldn’t get this to work, but additionally it looks like it should > > start 0x100 earlier and contain pic1@d800030 and gpio@d8000c0, given > > https://wiibrew.org/wiki/Hardware/Hollywood_Registers > > > > Would it make sense, for the time being, to reduce the size of this > > control@d800100 device to the single register currently being used by > > arch/powerpc/platforms/embedded6xx/wii.c (0xd800194, used to reboot the > > system) and leave the refactor of restart + OTP + PIC + GPIO for a > > future series? > > Makes sense to me! There is no benefit to pretending there is a "control" bus (there is no such thing), it only gets in the way. Segher
diff --git a/arch/powerpc/boot/dts/wii.dts b/arch/powerpc/boot/dts/wii.dts index aaa381da1906..7837c4a3f09c 100644 --- a/arch/powerpc/boot/dts/wii.dts +++ b/arch/powerpc/boot/dts/wii.dts @@ -219,6 +219,11 @@ control@d800100 { reg = <0x0d800100 0x300>; }; + otp@d8001ec { + compatible = "nintendo,hollywood-otp"; + reg = <0x0d8001ec 0x8>; + }; + disk@d806000 { compatible = "nintendo,hollywood-di"; reg = <0x0d806000 0x40>;
This can be used by the newly-added nintendo-otp nvmem module. Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> --- arch/powerpc/boot/dts/wii.dts | 5 +++++ 1 file changed, 5 insertions(+)