| Message ID | 20210629101048.933733-3-gjb@semihalf.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | sbbr: Make _AEI test optional for SBBR. | expand |
The subject should be the names of the subsystems, i.e. acpi: method: Make _AEI test optional for SBBR but I can fix this when applying. On 2021-06-29 4:10 a.m., Grzegorz Bernacki wrote: > BBR 1.0 specifies that _AEI method is not mandatory. > According to chapter 8.2 either GPIO-signaled events > or Interrupt-signaled events must be provided. > > BugLink: https://bugs.launchpad.net/fwts/+bug/1933495 > > Signed-off-by: Grzegorz Bernacki <gjb@semihalf.com> > --- > src/acpi/method/method.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c > index 9200f7d4..c3532b67 100644 > --- a/src/acpi/method/method.c > +++ b/src/acpi/method/method.c > @@ -566,12 +566,8 @@ static void method_test_AEI_return( > > static int method_test_AEI(fwts_framework *fw) > { > - if (fw->flags & FWTS_FLAG_SBBR) > - return method_evaluate_method(fw, METHOD_MANDATORY, > - "_AEI", NULL, 0, method_test_AEI_return, NULL); > - else > - return method_evaluate_method(fw, METHOD_OPTIONAL, > - "_AEI", NULL, 0, method_test_AEI_return, NULL); > + return method_evaluate_method(fw, METHOD_OPTIONAL, > + "_AEI", NULL, 0, method_test_AEI_return, NULL); > } > > static void check_evt_event ( > Acked-by: Alex Hung <alex.hung@canonical.com>
diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c index 9200f7d4..c3532b67 100644 --- a/src/acpi/method/method.c +++ b/src/acpi/method/method.c @@ -566,12 +566,8 @@ static void method_test_AEI_return( static int method_test_AEI(fwts_framework *fw) { - if (fw->flags & FWTS_FLAG_SBBR) - return method_evaluate_method(fw, METHOD_MANDATORY, - "_AEI", NULL, 0, method_test_AEI_return, NULL); - else - return method_evaluate_method(fw, METHOD_OPTIONAL, - "_AEI", NULL, 0, method_test_AEI_return, NULL); + return method_evaluate_method(fw, METHOD_OPTIONAL, + "_AEI", NULL, 0, method_test_AEI_return, NULL); } static void check_evt_event (
BBR 1.0 specifies that _AEI method is not mandatory. According to chapter 8.2 either GPIO-signaled events or Interrupt-signaled events must be provided. BugLink: https://bugs.launchpad.net/fwts/+bug/1933495 Signed-off-by: Grzegorz Bernacki <gjb@semihalf.com> --- src/acpi/method/method.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)