| Message ID | 20210601175304.2634549-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | powerpc/8xx: select CPM1 for MPC8XXFADS | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (112f47a1484ddca610b70cbe4a99f0d0f1701daf) |
| snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
| snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
| snowpatch_ozlabs/build-pmac32 | success | Build succeeded |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
Le 01/06/2021 à 19:53, trix@redhat.com a écrit : > From: Tom Rix <trix@redhat.com> > > With MPC8XXFADS, there is this linker error > ppc64-linux-ld: m8xx_setup.o: in function `cpm_cascade': > m8xx_setup.c: undefined reference to `cpm_get_irq' It looks like this config item is stale, it doesn't build any board support, there is no define_machine() for this config item, no file is linked to that config item. I think you should just remove that item from the possible choices. Christophe > > cpm_get_irq() is conditionally complied by CPM1 > So add a select, like the other plaforms > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > arch/powerpc/platforms/8xx/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/platforms/8xx/Kconfig b/arch/powerpc/platforms/8xx/Kconfig > index 60cc5b537a98..919082cdb2f1 100644 > --- a/arch/powerpc/platforms/8xx/Kconfig > +++ b/arch/powerpc/platforms/8xx/Kconfig > @@ -10,6 +10,7 @@ choice > > config MPC8XXFADS > bool "FADS" > + select CPM1 > > config MPC86XADS > bool "MPC86XADS" >
On 6/2/21 12:44 AM, Christophe Leroy wrote: > > > Le 01/06/2021 à 19:53, trix@redhat.com a écrit : >> From: Tom Rix <trix@redhat.com> >> >> With MPC8XXFADS, there is this linker error >> ppc64-linux-ld: m8xx_setup.o: in function `cpm_cascade': >> m8xx_setup.c: undefined reference to `cpm_get_irq' > > It looks like this config item is stale, it doesn't build any board > support, there is no define_machine() for this config item, no file is > linked to that config item. > > I think you should just remove that item from the possible choices. > Yes, this looks like a dead config and removing it is what to do. I withdraw this change. I am looking at sweeping the tree of dead configs. Up a dir, my finder shows PPC_MMU_NOHASH_32 is another (maybe) dead config. Thanks for pointing this out, Tom > Christophe > > >> >> cpm_get_irq() is conditionally complied by CPM1 >> So add a select, like the other plaforms >> >> Signed-off-by: Tom Rix <trix@redhat.com> >> --- >> arch/powerpc/platforms/8xx/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/powerpc/platforms/8xx/Kconfig >> b/arch/powerpc/platforms/8xx/Kconfig >> index 60cc5b537a98..919082cdb2f1 100644 >> --- a/arch/powerpc/platforms/8xx/Kconfig >> +++ b/arch/powerpc/platforms/8xx/Kconfig >> @@ -10,6 +10,7 @@ choice >> config MPC8XXFADS >> bool "FADS" >> + select CPM1 >> config MPC86XADS >> bool "MPC86XADS" >> >
diff --git a/arch/powerpc/platforms/8xx/Kconfig b/arch/powerpc/platforms/8xx/Kconfig index 60cc5b537a98..919082cdb2f1 100644 --- a/arch/powerpc/platforms/8xx/Kconfig +++ b/arch/powerpc/platforms/8xx/Kconfig @@ -10,6 +10,7 @@ choice config MPC8XXFADS bool "FADS" + select CPM1 config MPC86XADS bool "MPC86XADS"