| Message ID | 20210119135500.265403-1-its@irrelevant.dk |
|---|---|
| Headers | show |
| Series | hw/block/nvme: zoned fixes | expand |
On Tue, Jan 19, 2021 at 02:54:58PM +0100, Klaus Jensen wrote: > From: Klaus Jensen <k.jensen@samsung.com> > > Patch [1/2] fixes the zone append bug reported by Niklas. [2/2] > refactors the zone write check function to return status codes in a > different order if there are multiple zone write violations that apply. > > Klaus Jensen (2): > hw/block/nvme: fix zone boundary check for append > hw/block/nvme: refactor the logic for zone write checks > > hw/block/nvme.c | 89 +++++++++++++++++++++---------------------- > hw/block/trace-events | 5 +++ > 2 files changed, 48 insertions(+), 46 deletions(-) > > -- > 2.30.0 > > For the series: Tested-by: Niklas Cassel <niklas.cassel@wdc.com>
On Jan 19 14:54, Klaus Jensen wrote: > From: Klaus Jensen <k.jensen@samsung.com> > > Patch [1/2] fixes the zone append bug reported by Niklas. [2/2] > refactors the zone write check function to return status codes in a > different order if there are multiple zone write violations that apply. > > Klaus Jensen (2): > hw/block/nvme: fix zone boundary check for append > hw/block/nvme: refactor the logic for zone write checks > > hw/block/nvme.c | 89 +++++++++++++++++++++---------------------- > hw/block/trace-events | 5 +++ > 2 files changed, 48 insertions(+), 46 deletions(-) > Pinging for a review. Dmitry maybe?
On Mon, 2021-01-25 at 08:25 +0100, Klaus Jensen wrote: > On Jan 19 14:54, Klaus Jensen wrote: > > From: Klaus Jensen <k.jensen@samsung.com> > > > > Patch [1/2] fixes the zone append bug reported by Niklas. [2/2] > > refactors the zone write check function to return status codes in a > > different order if there are multiple zone write violations that apply. > > > > Klaus Jensen (2): > > hw/block/nvme: fix zone boundary check for append > > hw/block/nvme: refactor the logic for zone write checks > > > > hw/block/nvme.c | 89 +++++++++++++++++++++---------------------- > > hw/block/trace-events | 5 +++ > > 2 files changed, 48 insertions(+), 46 deletions(-) > > > > Pinging for a review. Dmitry maybe? I am testing it now, will post my review shortly. DF
On Tue, Jan 19, 2021 at 02:54:58PM +0100, Klaus Jensen wrote: > From: Klaus Jensen <k.jensen@samsung.com> > > Patch [1/2] fixes the zone append bug reported by Niklas. [2/2] > refactors the zone write check function to return status codes in a > different order if there are multiple zone write violations that apply. Looks good to me. Reviewed-by: Keith Busch <kbusch@kernel.org>
> -----Original Message----- > From: Keith Busch <kbusch@kernel.org> > Sent: Wednesday, January 27, 2021 12:42 PM > To: Klaus Jensen <its@irrelevant.dk> > Cc: qemu-devel@nongnu.org; Kevin Wolf <kwolf@redhat.com>; Max Reitz > <mreitz@redhat.com>; qemu-block@nongnu.org; Dmitry Fomichev > <Dmitry.Fomichev@wdc.com>; Klaus Jensen <k.jensen@samsung.com> > Subject: Re: [PATCH 0/2] hw/block/nvme: zoned fixes > > On Tue, Jan 19, 2021 at 02:54:58PM +0100, Klaus Jensen wrote: > > From: Klaus Jensen <k.jensen@samsung.com> > > > > Patch [1/2] fixes the zone append bug reported by Niklas. [2/2] > > refactors the zone write check function to return status codes in a > > different order if there are multiple zone write violations that apply. > > Looks good to me. > > Reviewed-by: Keith Busch <kbusch@kernel.org> Besides aesthetics, I don't have any complaints about this series :) Tested-by: Dmitry Fomichev <dmitry.fomichev@wdc.com> Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
On Jan 19 14:54, Klaus Jensen wrote: > From: Klaus Jensen <k.jensen@samsung.com> > > Patch [1/2] fixes the zone append bug reported by Niklas. [2/2] > refactors the zone write check function to return status codes in a > different order if there are multiple zone write violations that apply. > > Klaus Jensen (2): > hw/block/nvme: fix zone boundary check for append > hw/block/nvme: refactor the logic for zone write checks > > hw/block/nvme.c | 89 +++++++++++++++++++++---------------------- > hw/block/trace-events | 5 +++ > 2 files changed, 48 insertions(+), 46 deletions(-) > > -- > 2.30.0 > > Thanks all, applied to nvme-next.
From: Klaus Jensen <k.jensen@samsung.com> Patch [1/2] fixes the zone append bug reported by Niklas. [2/2] refactors the zone write check function to return status codes in a different order if there are multiple zone write violations that apply. Klaus Jensen (2): hw/block/nvme: fix zone boundary check for append hw/block/nvme: refactor the logic for zone write checks hw/block/nvme.c | 89 +++++++++++++++++++++---------------------- hw/block/trace-events | 5 +++ 2 files changed, 48 insertions(+), 46 deletions(-)