| Message ID | 20201104102248.32168-4-its@irrelevant.dk |
|---|---|
| State | New |
| Headers | show |
| Series | hw/block/nvme: coverity fixes | expand |
On 11/4/20 11:22 AM, Klaus Jensen wrote: > From: Klaus Jensen <k.jensen@samsung.com> > > Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the > namespaces member of NvmeCtrl is no longer a dynamically allocated > array. Remove the free. > > Fixes: 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces") > Reported-by: Coverity (CID 1436131) > Signed-off-by: Klaus Jensen <k.jensen@samsung.com> > --- > hw/block/nvme.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On 04.11.20 11:22, Klaus Jensen wrote: > From: Klaus Jensen <k.jensen@samsung.com> > > Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the > namespaces member of NvmeCtrl is no longer a dynamically allocated > array. Remove the free. > > Fixes: 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces") > Reported-by: Coverity (CID 1436131) > Signed-off-by: Klaus Jensen <k.jensen@samsung.com> > --- > hw/block/nvme.c | 1 - > 1 file changed, 1 deletion(-) Thanks! :) Reviewed-by: Max Reitz <mreitz@redhat.com>
On Nov 4 11:59, Max Reitz wrote: > On 04.11.20 11:22, Klaus Jensen wrote: > > From: Klaus Jensen <k.jensen@samsung.com> > > > > Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the > > namespaces member of NvmeCtrl is no longer a dynamically allocated > > array. Remove the free. > > > > Fixes: 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces") > > Reported-by: Coverity (CID 1436131) > > Signed-off-by: Klaus Jensen <k.jensen@samsung.com> > > --- > > hw/block/nvme.c | 1 - > > 1 file changed, 1 deletion(-) > > Thanks! :) > > Reviewed-by: Max Reitz <mreitz@redhat.com> > Will Peter pick up fixes like this directly so we don't have to go through a pull request from nvme-next? Did I correctly annotate with "for-5.2"? :)
On 04.11.20 12:04, Klaus Jensen wrote: > On Nov 4 11:59, Max Reitz wrote: >> On 04.11.20 11:22, Klaus Jensen wrote: >>> From: Klaus Jensen <k.jensen@samsung.com> >>> >>> Since 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces"), the >>> namespaces member of NvmeCtrl is no longer a dynamically allocated >>> array. Remove the free. >>> >>> Fixes: 7f0f1acedf15 ("hw/block/nvme: support multiple namespaces") >>> Reported-by: Coverity (CID 1436131) >>> Signed-off-by: Klaus Jensen <k.jensen@samsung.com> >>> --- >>> hw/block/nvme.c | 1 - >>> 1 file changed, 1 deletion(-) >> >> Thanks! :) >> >> Reviewed-by: Max Reitz <mreitz@redhat.com> >> > > Will Peter pick up fixes like this directly so we don't have to go > through a pull request from nvme-next? AFAIA, Peter only picks up build fixes. Since the build wasn’t broken, I think someone™ will have to send a pull request... I understand you don’t necessarily want to be that someone, so I suppose I might as well. > Did I correctly annotate with "for-5.2"? :) Yes! Max
diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 2bdc50eb6fce..01b657b1c5e2 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -2799,7 +2799,6 @@ static void nvme_exit(PCIDevice *pci_dev) NvmeCtrl *n = NVME(pci_dev); nvme_clear_ctrl(n); - g_free(n->namespaces); g_free(n->cq); g_free(n->sq); g_free(n->aer_reqs);