Message ID | cd6eaf1915c834e7070a5c3cad083372a43edb82.1598951375.git.lukasstraub2@web.de |
---|---|
State | New |
Headers | show |
Series | Introduce 'yank' oob qmp command to recover from hanging qemu | expand |
On Tue, Sep 01, 2020 at 11:15:25AM +0200, Lukas Straub wrote: > Migration and yank code assume that qio_channel_shutdown is thread > -safe and can be called from qmp oob handler. Document this after > checking the code. > > Signed-off-by: Lukas Straub <lukasstraub2@web.de> > Acked-by: Stefan Hajnoczi <stefanha@redhat.com> > --- > include/io/channel.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel
diff --git a/include/io/channel.h b/include/io/channel.h index d4557f0930..46156d84f5 100644 --- a/include/io/channel.h +++ b/include/io/channel.h @@ -98,7 +98,8 @@ struct QIOChannel { * provide additional optional features. * * Consult the corresponding public API docs for a description - * of the semantics of each callback + * of the semantics of each callback. io_shutdown in particular + * must be thread-safe, terminate quickly and must not block. */ struct QIOChannelClass { ObjectClass parent; @@ -516,6 +517,8 @@ int qio_channel_close(QIOChannel *ioc, * QIO_CHANNEL_FEATURE_SHUTDOWN prior to calling * this method. * + * This function is thread-safe, terminates quickly and does not block. + * * Returns: 0 on success, -1 on error */ int qio_channel_shutdown(QIOChannel *ioc,