| Message ID | 20200624083337.912846-1-dinechin@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | trivial: Remove extra character in configure help | expand |
Please ignore. The =B appears intentional, even if it offsets the whole help text. Maybe replace with =L to indicate a list is expected? > On 24 Jun 2020, at 10:33, Christophe de Dinechin <dinechin@redhat.com> wrote: > > Signed-off-by: Christophe de Dinechin <dinechin@redhat.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index ba88fd1824..c7a6a5adfe 100755 > --- a/configure > +++ b/configure > @@ -1787,7 +1787,7 @@ Advanced options (experts only): > --block-drv-ro-whitelist=L > set block driver read-only whitelist > (affects only QEMU, not qemu-img) > - --enable-trace-backends=B Set trace backend > + --enable-trace-backends= Set trace backend > Available backends: $trace_backend_list > --with-trace-file=NAME Full PATH,NAME of file to store traces > Default:trace-<pid> > -- > 2.26.2 > >
On Wed, Jun 24, 2020 at 10:33:37AM +0200, Christophe de Dinechin wrote: > Signed-off-by: Christophe de Dinechin <dinechin@redhat.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index ba88fd1824..c7a6a5adfe 100755 > --- a/configure > +++ b/configure > @@ -1787,7 +1787,7 @@ Advanced options (experts only): > --block-drv-ro-whitelist=L > set block driver read-only whitelist > (affects only QEMU, not qemu-img) > - --enable-trace-backends=B Set trace backend > + --enable-trace-backends= Set trace backend This is just following the style of the option above. "B" is a placeholder for the desired backend(s). > Available backends: $trace_backend_list > --with-trace-file=NAME Full PATH,NAME of file to store traces > Default:trace-<pid> Regards, Daniel
On 6/24/20 10:59 AM, Daniel P. Berrangé wrote: > On Wed, Jun 24, 2020 at 10:33:37AM +0200, Christophe de Dinechin wrote: >> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com> >> --- >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure b/configure >> index ba88fd1824..c7a6a5adfe 100755 >> --- a/configure >> +++ b/configure >> @@ -1787,7 +1787,7 @@ Advanced options (experts only): >> --block-drv-ro-whitelist=L >> set block driver read-only whitelist >> (affects only QEMU, not qemu-img) >> - --enable-trace-backends=B Set trace backend >> + --enable-trace-backends= Set trace backend > > This is just following the style of the option above. "B" is a > placeholder for the desired backend(s). I agree this is confusing, since then the filename is NAME, not N. Maybe clearer to replace B -> BACKEND, L -> LIST, ...? > >> Available backends: $trace_backend_list >> --with-trace-file=NAME Full PATH,NAME of file to store traces >> Default:trace-<pid> > > > Regards, > Daniel >
diff --git a/configure b/configure index ba88fd1824..c7a6a5adfe 100755 --- a/configure +++ b/configure @@ -1787,7 +1787,7 @@ Advanced options (experts only): --block-drv-ro-whitelist=L set block driver read-only whitelist (affects only QEMU, not qemu-img) - --enable-trace-backends=B Set trace backend + --enable-trace-backends= Set trace backend Available backends: $trace_backend_list --with-trace-file=NAME Full PATH,NAME of file to store traces Default:trace-<pid>
Signed-off-by: Christophe de Dinechin <dinechin@redhat.com> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)