Message ID | 20200403071325.3721-1-yanaijie@huawei.com (mailing list archive) |
---|---|
State | Handled Elsewhere, archived |
Headers | show |
Series | tty: hvc: remove hvcs_driver_string | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/apply_patch | success | Successfully applied on branch powerpc/merge (d0c12846a3a24cd6d68b608c866712bc7e471634) |
snowpatch_ozlabs/build-ppc64le | success | Build succeeded |
snowpatch_ozlabs/build-ppc64be | success | Build succeeded |
snowpatch_ozlabs/build-ppc64e | success | Build succeeded |
snowpatch_ozlabs/build-pmac32 | fail | build failed! |
snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
snowpatch_ozlabs/needsstable | success | Patch has no Fixes tags |
On 03. 04. 20, 9:13, Jason Yan wrote: > No users of hvcs_driver_string, remove it. This fixes the following gcc > warning: > > drivers/tty/hvc/hvcs.c:199:19: warning: ‘hvcs_driver_string’ defined but > not used [-Wunused-const-variable=] > static const char hvcs_driver_string[] > ^~~~~~~~~~~~~~~~~~ > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jason Yan <yanaijie@huawei.com> Acked-by: Jiri Slaby <jslaby@suse.cz> It fixes a commit from 2011: commit c7704d352d45de47333f2d9f10aead820b49044c Author: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: Sun Feb 6 18:26:25 2011 +0000 powerpc/pseries: Reduce HVCS driver insanity ! > --- > drivers/tty/hvc/hvcs.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c > index ee0604cd9c6b..55105ac38f89 100644 > --- a/drivers/tty/hvc/hvcs.c > +++ b/drivers/tty/hvc/hvcs.c > @@ -196,8 +196,6 @@ module_param(hvcs_parm_num_devs, int, 0); > > static const char hvcs_driver_name[] = "hvcs"; > static const char hvcs_device_node[] = "hvcs"; > -static const char hvcs_driver_string[] > - = "IBM hvcs (Hypervisor Virtual Console Server) Driver"; > > /* Status of partner info rescan triggered via sysfs. */ > static int hvcs_rescan_status; >
diff --git a/drivers/tty/hvc/hvcs.c b/drivers/tty/hvc/hvcs.c index ee0604cd9c6b..55105ac38f89 100644 --- a/drivers/tty/hvc/hvcs.c +++ b/drivers/tty/hvc/hvcs.c @@ -196,8 +196,6 @@ module_param(hvcs_parm_num_devs, int, 0); static const char hvcs_driver_name[] = "hvcs"; static const char hvcs_device_node[] = "hvcs"; -static const char hvcs_driver_string[] - = "IBM hvcs (Hypervisor Virtual Console Server) Driver"; /* Status of partner info rescan triggered via sysfs. */ static int hvcs_rescan_status;
No users of hvcs_driver_string, remove it. This fixes the following gcc warning: drivers/tty/hvc/hvcs.c:199:19: warning: ‘hvcs_driver_string’ defined but not used [-Wunused-const-variable=] static const char hvcs_driver_string[] ^~~~~~~~~~~~~~~~~~ Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/tty/hvc/hvcs.c | 2 -- 1 file changed, 2 deletions(-)