Message ID | 20200330102945.2388294-1-laurent@vivier.eu |
---|---|
State | New |
Headers | show |
Patchew URL: https://patchew.org/QEMU/20200330102945.2388294-1-laurent@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 0/1] Linux user for 5.0 patches Message-id: 20200330102945.2388294-1-laurent@vivier.eu Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 68faea1 linux-user: Support futex_time64 === OUTPUT BEGIN === WARNING: architecture specific defines should be avoided #27: FILE: linux-user/syscall.c:248: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #30: FILE: linux-user/syscall.c:251: +#if defined(__NR_futex_time64) WARNING: architecture specific defines should be avoided #41: FILE: linux-user/syscall.c:303: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #45: FILE: linux-user/syscall.c:307: +#if defined(__NR_futex_time64) ERROR: space required after that ',' (ctx:VxV) #46: FILE: linux-user/syscall.c:308: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #46: FILE: linux-user/syscall.c:308: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:OxV) #46: FILE: linux-user/syscall.c:308: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #46: FILE: linux-user/syscall.c:308: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #46: FILE: linux-user/syscall.c:308: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #46: FILE: linux-user/syscall.c:308: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:VxV) #46: FILE: linux-user/syscall.c:308: +_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val, ^ ERROR: space required after that ',' (ctx:OxV) #47: FILE: linux-user/syscall.c:309: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #47: FILE: linux-user/syscall.c:309: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:OxV) #47: FILE: linux-user/syscall.c:309: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #47: FILE: linux-user/syscall.c:309: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #47: FILE: linux-user/syscall.c:309: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ WARNING: architecture specific defines should be avoided #57: FILE: linux-user/syscall.c:774: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #61: FILE: linux-user/syscall.c:778: +#if defined(__NR_futex_time64) ERROR: space required after that ',' (ctx:VxV) #62: FILE: linux-user/syscall.c:779: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #62: FILE: linux-user/syscall.c:779: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:OxV) #62: FILE: linux-user/syscall.c:779: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #62: FILE: linux-user/syscall.c:779: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #62: FILE: linux-user/syscall.c:779: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #62: FILE: linux-user/syscall.c:779: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:VxV) #62: FILE: linux-user/syscall.c:779: +safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \ ^ ERROR: space required after that ',' (ctx:OxV) #63: FILE: linux-user/syscall.c:780: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #63: FILE: linux-user/syscall.c:780: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:OxV) #63: FILE: linux-user/syscall.c:780: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #63: FILE: linux-user/syscall.c:780: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ ERROR: space required after that ',' (ctx:VxV) #63: FILE: linux-user/syscall.c:780: + const struct timespec *,timeout,int *,uaddr2,int,val3) ^ WARNING: architecture specific defines should be avoided #86: FILE: linux-user/syscall.c:6937: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #92: FILE: linux-user/syscall.c:6943: +#if defined(__NR_futex_time64) WARNING: architecture specific defines should be avoided #98: FILE: linux-user/syscall.c:6949: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #111: FILE: linux-user/syscall.c:6962: +#if defined(__NR_futex) WARNING: architecture specific defines should be avoided #116: FILE: linux-user/syscall.c:6967: +#if defined(__NR_futex_time64) WARNING: architecture specific defines should be avoided #123: FILE: linux-user/syscall.c:6974: +#if defined(__NR_futex) WARNING: line over 80 characters #169: FILE: linux-user/syscall.c:7035: +static int do_futex_time64(target_ulong uaddr, int op, int val, target_ulong timeout, WARNING: Block comments use a leading /* on a separate line #175: FILE: linux-user/syscall.c:7041: + /* ??? We assume FUTEX_* constants are the same on both host WARNING: Block comments use * on subsequent lines #176: FILE: linux-user/syscall.c:7042: + /* ??? We assume FUTEX_* constants are the same on both host + and target. */ WARNING: Block comments use a trailing */ on a separate line #176: FILE: linux-user/syscall.c:7042: + and target. */ WARNING: Block comments use a leading /* on a separate line #199: FILE: linux-user/syscall.c:7065: + /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the WARNING: Block comments use * on subsequent lines #200: FILE: linux-user/syscall.c:7066: + /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the + TIMEOUT parameter is interpreted as a uint32_t by the kernel. WARNING: Block comments use a trailing */ on a separate line #203: FILE: linux-user/syscall.c:7069: + since it's not compared to guest memory. */ total: 24 errors, 19 warnings, 207 lines checked Commit 68faea14e7cf (linux-user: Support futex_time64) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200330102945.2388294-1-laurent@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Mon, 30 Mar 2020 at 11:31, Laurent Vivier <laurent@vivier.eu> wrote: > > The following changes since commit cfe68ae025f704f336d7dd3d1903ce37b445831d: > > Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.0-pull-request' into staging (2020-03-26 20:55:54 +0000) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request > > for you to fetch changes up to 146902964d66881da797e45a5950732e38532e3e: > > linux-user: Support futex_time64 (2020-03-30 12:28:30 +0200) > > ---------------------------------------------------------------- > Add support for futex_time64 > > ---------------------------------------------------------------- > > Alistair Francis (1): > linux-user: Support futex_time64 > > linux-user/syscall.c | 140 ++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 126 insertions(+), 14 deletions(-) Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0 for any user-visible changes. -- PMM