diff mbox series

sysfs: Fixes __BIN_ATTR_WO() macro

Message ID 1569973038-2710-1-git-send-email-nayna@linux.ibm.com (mailing list archive)
State Accepted
Commit 39a963b457b5c6cbbdc70441c9d496e39d151582
Headers show
Series sysfs: Fixes __BIN_ATTR_WO() macro | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success Successfully applied on branch next (6edfc6487b474fe01857dc3f1a9cd701bb9b21c8)
snowpatch_ozlabs/build-ppc64le success Build succeeded
snowpatch_ozlabs/build-ppc64be success Build succeeded
snowpatch_ozlabs/build-ppc64e success Build succeeded
snowpatch_ozlabs/build-pmac32 success Build succeeded
snowpatch_ozlabs/checkpatch success total: 0 errors, 0 warnings, 0 checks, 11 lines checked

Commit Message

Nayna Jain Oct. 1, 2019, 11:37 p.m. UTC 
This patch fixes the size and write parameter for the macro
__BIN_ATTR_WO().

Fixes: 7f905761e15a8 ("sysfs: add BIN_ATTR_WO() macro")
Signed-off-by: Nayna Jain <nayna@linux.ibm.com>
---
 include/linux/sysfs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Ellerman Nov. 14, 2019, 9:07 a.m. UTC | #1 
On Tue, 2019-10-01 at 23:37:18 UTC, Nayna Jain wrote:
> This patch fixes the size and write parameter for the macro
> __BIN_ATTR_WO().
> 
> Fixes: 7f905761e15a8 ("sysfs: add BIN_ATTR_WO() macro")
> Signed-off-by: Nayna Jain <nayna@linux.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/39a963b457b5c6cbbdc70441c9d496e39d151582

cheers
Greg KH Nov. 14, 2019, 9:47 a.m. UTC | #2 
On Thu, Nov 14, 2019 at 08:07:49PM +1100, Michael Ellerman wrote:
> On Tue, 2019-10-01 at 23:37:18 UTC, Nayna Jain wrote:
> > This patch fixes the size and write parameter for the macro
> > __BIN_ATTR_WO().
> > 
> > Fixes: 7f905761e15a8 ("sysfs: add BIN_ATTR_WO() macro")
> > Signed-off-by: Nayna Jain <nayna@linux.ibm.com>
> 
> Applied to powerpc next, thanks.
> 
> https://git.kernel.org/powerpc/c/39a963b457b5c6cbbdc70441c9d496e39d151582

Why?  This is already in 5.4-rc5, why do you need/want it again?

thanks,

greg k-h
diff mbox series

Patch

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index 5420817ed317..fa7ee503fb76 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -196,9 +196,9 @@  struct bin_attribute {
 	.size	= _size,						\
 }
 
-#define __BIN_ATTR_WO(_name) {						\
+#define __BIN_ATTR_WO(_name, _size) {					\
 	.attr	= { .name = __stringify(_name), .mode = 0200 },		\
-	.store	= _name##_store,					\
+	.write	= _name##_write,					\
 	.size	= _size,						\
 }