Message ID | 20191112105055.32269-1-laurent@vivier.eu |
---|---|
State | New |
Headers | show |
Series | linux-user: fix missing break | expand |
On 11/12/19 11:50 AM, Laurent Vivier wrote: > Reported by Coverity (CID 1407221) > Fixes: a2d866827bd8 ("linux-user: Support for NETLINK socket options") > cc: Josh Kunz <jkz@google.com> > Signed-off-by: Laurent Vivier <laurent@vivier.eu> > --- > linux-user/syscall.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index ab9d933e53af..4e97bcf1e5a9 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -2632,6 +2632,7 @@ static abi_long do_getsockopt(int sockfd, int level, int optname, > default: > goto unimplemented; > } > + break; > #endif /* SOL_NETLINK */ > default: > unimplemented: > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Le 12/11/2019 à 11:50, Laurent Vivier a écrit : > Reported by Coverity (CID 1407221) > Fixes: a2d866827bd8 ("linux-user: Support for NETLINK socket options") > cc: Josh Kunz <jkz@google.com> > Signed-off-by: Laurent Vivier <laurent@vivier.eu> > --- > linux-user/syscall.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index ab9d933e53af..4e97bcf1e5a9 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -2632,6 +2632,7 @@ static abi_long do_getsockopt(int sockfd, int level, int optname, > default: > goto unimplemented; > } > + break; > #endif /* SOL_NETLINK */ > default: > unimplemented: > Applied to my linux-user branch. Thanks, Laurent
diff --git a/linux-user/syscall.c b/linux-user/syscall.c index ab9d933e53af..4e97bcf1e5a9 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -2632,6 +2632,7 @@ static abi_long do_getsockopt(int sockfd, int level, int optname, default: goto unimplemented; } + break; #endif /* SOL_NETLINK */ default: unimplemented:
Reported by Coverity (CID 1407221) Fixes: a2d866827bd8 ("linux-user: Support for NETLINK socket options") cc: Josh Kunz <jkz@google.com> Signed-off-by: Laurent Vivier <laurent@vivier.eu> --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+)