| Message ID | 20191029114905.6856-6-jfreimann@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | add failover feature for assigned network devices | expand |
Jens Freimann <jfreimann@redhat.com> writes: > This event is emitted when we sent a request to unplug a Uh, "we sent a requestion [...] from the Guest OS"... do you mean "we received"? > failover primary device from the Guest OS and it includes the > device id of the primary device. > > Signed-off-by: Jens Freimann <jfreimann@redhat.com> > --- > qapi/migration.json | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/qapi/migration.json b/qapi/migration.json > index 82feb5bd39..e9e7a97c03 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -1448,3 +1448,22 @@ > # Since: 3.0 > ## > { 'command': 'migrate-pause', 'allow-oob': true } > + > +## > +# @UNPLUG_PRIMARY: > +# > +# Emitted from source side of a migration when migration state is > +# WAIT_UNPLUG. Device was unplugged by guest operating system. > +# Device resources in QEMU are kept on standby to be able to re-plug it in case > +# of migration failure. > +# > +# @device-id: QEMU device id of the unplugged device > +# > +# Since: 4.2 > +# > +# Example: > +# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} } > +# > +## > +{ 'event': 'UNPLUG_PRIMARY', > + 'data': { 'device-id': 'str' } } Commit message might need a touch-up. Regardless: Acked-by: Markus Armbruster <armbru@redhat.com>
On Tue, Oct 29, 2019 at 01:50:02PM +0100, Markus Armbruster wrote: >Jens Freimann <jfreimann@redhat.com> writes: > >> This event is emitted when we sent a request to unplug a > >Uh, "we sent a requestion [...] from the Guest OS"... do you mean "we >received"? No, we sent a pci hotplug event to the guest by "pushing" the pcie attention button. So, it's QEMU requesting the unplug. >> +## >> +# @UNPLUG_PRIMARY: >> +# >> +# Emitted from source side of a migration when migration state is >> +# WAIT_UNPLUG. Device was unplugged by guest operating system. >> +# Device resources in QEMU are kept on standby to be able to re-plug it in case >> +# of migration failure. >> +# >> +# @device-id: QEMU device id of the unplugged device >> +# >> +# Since: 4.2 >> +# >> +# Example: >> +# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} } >> +# >> +## >> +{ 'event': 'UNPLUG_PRIMARY', >> + 'data': { 'device-id': 'str' } } > >Commit message might need a touch-up. Regardless: >Acked-by: Markus Armbruster <armbru@redhat.com> Thanks for the review! regards, Jens
Jens Freimann <jfreimann@redhat.com> writes: > On Tue, Oct 29, 2019 at 01:50:02PM +0100, Markus Armbruster wrote: >>Jens Freimann <jfreimann@redhat.com> writes: >> >>> This event is emitted when we sent a request to unplug a >> >>Uh, "we sent a requestion [...] from the Guest OS"... do you mean "we >>received"? > > No, we sent a pci hotplug event to the guest by "pushing" the pcie attention > button. So, it's QEMU requesting the unplug. So if it's QEMU who does the sending, then saying "we sent [...] from the Guest OS does not compute for me. Do you mean "sent to"? [...]
diff --git a/qapi/migration.json b/qapi/migration.json index 82feb5bd39..e9e7a97c03 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -1448,3 +1448,22 @@ # Since: 3.0 ## { 'command': 'migrate-pause', 'allow-oob': true } + +## +# @UNPLUG_PRIMARY: +# +# Emitted from source side of a migration when migration state is +# WAIT_UNPLUG. Device was unplugged by guest operating system. +# Device resources in QEMU are kept on standby to be able to re-plug it in case +# of migration failure. +# +# @device-id: QEMU device id of the unplugged device +# +# Since: 4.2 +# +# Example: +# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} } +# +## +{ 'event': 'UNPLUG_PRIMARY', + 'data': { 'device-id': 'str' } }
This event is emitted when we sent a request to unplug a failover primary device from the Guest OS and it includes the device id of the primary device. Signed-off-by: Jens Freimann <jfreimann@redhat.com> --- qapi/migration.json | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)