| Message ID | 20191018031710.41052-1-wangkefeng.wang@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Kill pr_warning in the whole linux code | expand |
On Fri 2019-10-18 11:17:10, Kefeng Wang wrote: > There are pr_warning and pr_warng to show WARNING level message, > most of the code using pr_warn, number based on next-20191017, > > pr_warn: 5206 pr_warning: 546 (tools: 399, others: 147) > > Let's carry on with the work to standardize the logging macro, > kill pr_warning in the whole linux code. > > Patch[01-28]: simply sed and ajust formats All these patches have been commited in printk.git, branch for-5.5-pr-warn. > patch[29]: drop pr_warning definition in printk > patch[33]: cleanup the checkpatch.pl I'll wait with these two until I am sure that the are no pr_warning() users in linux-next. > patch[30-32]: tools api/bpf/perf, rename and make manually changes Only the tool api patch is commited in printk.git. The other two (bpf and perf) will need to go via the related subsystems to avoid conflicts nightmare. The good thing is that these are userspace tools. They do not block removing pr_warning() from the internal kernel API. Best Regards, Petr
As I said before: please just send Linus a scripted conversion after the next -rc1. There is no point in creating all this churn.
(Adding Stephen Rothwell) On Fri, 2019-10-18 at 17:22 +0200, Christoph Hellwig wrote: > As I said before: please just send Linus a scripted conversion after > the next -rc1. There is no point in creating all this churn. I again ask for a scripted mechanism to be added to -next to allow these types of scriptable patches to get compilation coverage testing.
There are pr_warning and pr_warng to show WARNING level message, most of the code using pr_warn, number based on next-20191017, pr_warn: 5206 pr_warning: 546 (tools: 399, others: 147) Joe Perches posted a patch, commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of pr_warning"), which is beginning to remove pr_warning, so all logging messages use a consistent pr_warn style once pr_warning removed, and checkpatch also sugguests that better to use pr_warn instead of pr_warning. Let's carry on with the work to standardize the logging macro, kill pr_warning in the whole linux code. Note, for tools api/bpf/perf part, rename pr_warning to pr_warn to keep the consistence, with this patchset, pr_warn: 5747 pr_warning: 0 Patch[01-28]: simply sed and ajust formats patch[29]: drop pr_warning definition in printk patch[30-32]: tools api/bpf/perf, rename and make manually changes patch[33]: cleanup the checkpatch.pl Miscellanea: o Coalesce formats o Realign arguments o Remove unnecessary line continuations The patchset is based on next-20191017 and will be taked via printk.git by Petr Mladek, see https://lore.kernel.org/lkml/20191017135229.a4mvcyap6l34m5bk@pathway.suse.cz/ v2: - Collect ack-by/review-by - Fix some indentation and alignment - Split patches in drivers/platform/x86/ suggested by Andy Shevchenko - Drop staging changes which already merged Kefeng Wang (33): alpha: Use pr_warn instead of pr_warning arm64: Use pr_warn instead of pr_warning ia64: Use pr_warn instead of pr_warning riscv: Use pr_warn instead of pr_warning sh: Use pr_warn instead of pr_warning sparc: Use pr_warn instead of pr_warning x86: Use pr_warn instead of pr_warning acpi: Use pr_warn instead of pr_warning drbd: Use pr_warn instead of pr_warning gdrom: Use pr_warn instead of pr_warning clocksource: samsung_pwm_timer: Use pr_warn instead of pr_warning crypto: n2: Use pr_warn instead of pr_warning ide: Use pr_warn instead of pr_warning idsn: Use pr_warn instead of pr_warning macintosh: Use pr_warn instead of pr_warning of: Use pr_warn instead of pr_warning oprofile: Use pr_warn instead of pr_warning platform/x86: eeepc-laptop: Use pr_warn instead of pr_warning platform/x86: asus-laptop: Use pr_warn instead of pr_warning platform/x86: intel_oaktrail: Use pr_warn instead of pr_warning scsi: Use pr_warn instead of pr_warning sh/intc: Use pr_warn instead of pr_warning fs: afs: Use pr_warn instead of pr_warning vgacon: Use pr_warn instead of pr_warning dma-debug: Use pr_warn instead of pr_warning trace: Use pr_warn instead of pr_warning lib: cpu_rmap: Use pr_warn instead of pr_warning ASoC: samsung: Use pr_warn instead of pr_warning printk: Drop pr_warning tools lib api: Renaming pr_warning to pr_warn tools lib bpf: Renaming pr_warning to pr_warn tools perf: Renaming pr_warning to pr_warn checkpatch: Drop pr_warning check arch/alpha/kernel/perf_event.c | 4 +- arch/arm64/kernel/hw_breakpoint.c | 8 +- arch/arm64/kernel/smp.c | 11 +- arch/ia64/kernel/setup.c | 2 +- arch/riscv/kernel/module.c | 4 +- arch/sh/boards/mach-sdk7786/nmi.c | 2 +- arch/sh/drivers/pci/fixups-sdk7786.c | 2 +- arch/sh/kernel/io_trapped.c | 2 +- arch/sh/kernel/setup.c | 2 +- arch/sh/mm/consistent.c | 5 +- arch/sparc/kernel/smp_64.c | 6 +- arch/x86/kernel/amd_gart_64.c | 12 +- arch/x86/kernel/apic/apic.c | 41 +- arch/x86/kernel/setup_percpu.c | 4 +- arch/x86/kernel/tboot.c | 15 +- arch/x86/kernel/tsc_sync.c | 8 +- arch/x86/kernel/umip.c | 6 +- arch/x86/mm/kmmio.c | 7 +- arch/x86/mm/mmio-mod.c | 6 +- arch/x86/mm/numa_emulation.c | 4 +- arch/x86/mm/testmmiotrace.c | 6 +- arch/x86/oprofile/op_x86_model.h | 6 +- arch/x86/platform/olpc/olpc-xo15-sci.c | 2 +- arch/x86/platform/sfi/sfi.c | 3 +- arch/x86/xen/setup.c | 2 +- drivers/acpi/apei/apei-base.c | 36 +- drivers/acpi/apei/einj.c | 4 +- drivers/acpi/apei/erst-dbg.c | 5 +- drivers/acpi/apei/ghes.c | 25 +- drivers/acpi/apei/hest.c | 14 +- drivers/acpi/battery.c | 2 +- drivers/acpi/resource.c | 4 +- drivers/block/drbd/drbd_nl.c | 13 +- drivers/cdrom/gdrom.c | 4 +- drivers/clocksource/samsung_pwm_timer.c | 2 +- drivers/crypto/n2_core.c | 12 +- drivers/ide/tx4938ide.c | 2 +- drivers/ide/tx4939ide.c | 6 +- drivers/isdn/hardware/mISDN/avmfritz.c | 16 +- drivers/isdn/hardware/mISDN/hfcmulti.c | 8 +- drivers/isdn/hardware/mISDN/hfcpci.c | 3 +- drivers/isdn/hardware/mISDN/hfcsusb.c | 4 +- drivers/isdn/hardware/mISDN/mISDNipac.c | 4 +- drivers/isdn/hardware/mISDN/mISDNisar.c | 10 +- drivers/isdn/hardware/mISDN/netjet.c | 8 +- drivers/isdn/hardware/mISDN/w6692.c | 12 +- drivers/isdn/mISDN/hwchannel.c | 7 +- drivers/macintosh/windfarm_fcu_controls.c | 4 +- drivers/macintosh/windfarm_lm87_sensor.c | 4 +- drivers/macintosh/windfarm_pm72.c | 22 +- drivers/macintosh/windfarm_rm31.c | 6 +- drivers/of/fdt.c | 20 +- drivers/oprofile/oprofile_perf.c | 8 +- drivers/platform/x86/asus-laptop.c | 2 +- drivers/platform/x86/eeepc-laptop.c | 2 +- drivers/platform/x86/intel_oaktrail.c | 10 +- drivers/scsi/a3000.c | 2 +- drivers/sh/intc/core.c | 4 +- drivers/video/console/vgacon.c | 6 +- fs/afs/flock.c | 4 +- fs/afs/inode.c | 13 +- fs/afs/yfsclient.c | 4 +- include/linux/printk.h | 3 +- kernel/dma/debug.c | 2 +- kernel/trace/trace_benchmark.c | 4 +- lib/cpu_rmap.c | 2 +- scripts/checkpatch.pl | 9 - sound/soc/samsung/s3c-i2s-v2.c | 6 +- tools/lib/api/debug-internal.h | 4 +- tools/lib/api/debug.c | 4 +- tools/lib/api/fs/fs.c | 4 +- tools/lib/bpf/btf.c | 56 +- tools/lib/bpf/btf_dump.c | 18 +- tools/lib/bpf/libbpf.c | 679 +++++++++++----------- tools/lib/bpf/libbpf_internal.h | 8 +- tools/lib/bpf/xsk.c | 4 +- tools/perf/arch/x86/util/intel-pt.c | 2 +- tools/perf/builtin-annotate.c | 7 +- tools/perf/builtin-buildid-cache.c | 28 +- tools/perf/builtin-diff.c | 12 +- tools/perf/builtin-help.c | 10 +- tools/perf/builtin-inject.c | 8 +- tools/perf/builtin-probe.c | 14 +- tools/perf/builtin-record.c | 10 +- tools/perf/builtin-report.c | 2 +- tools/perf/builtin-script.c | 14 +- tools/perf/builtin-stat.c | 18 +- tools/perf/builtin-timechart.c | 12 +- tools/perf/builtin-top.c | 2 +- tools/perf/builtin-trace.c | 8 +- tools/perf/lib/internal.h | 2 +- tools/perf/ui/browsers/scripts.c | 2 +- tools/perf/util/bpf-loader.c | 6 +- tools/perf/util/bpf-prologue.c | 4 +- tools/perf/util/callchain.c | 2 +- tools/perf/util/config.c | 8 +- tools/perf/util/data-convert-bt.c | 4 +- tools/perf/util/data.c | 2 +- tools/perf/util/debug.c | 4 +- tools/perf/util/debug.h | 2 +- tools/perf/util/event.c | 4 +- tools/perf/util/evlist.c | 4 +- tools/perf/util/evsel.c | 19 +- tools/perf/util/header.c | 20 +- tools/perf/util/jitdump.c | 4 +- tools/perf/util/llvm-utils.c | 18 +- tools/perf/util/machine.c | 2 +- tools/perf/util/parse-branch-options.c | 3 +- tools/perf/util/perf-hooks.c | 6 +- tools/perf/util/probe-event.c | 90 +-- tools/perf/util/probe-file.c | 36 +- tools/perf/util/probe-finder.c | 115 ++-- tools/perf/util/record.c | 18 +- tools/perf/util/session.c | 2 +- tools/perf/util/srcline.c | 6 +- tools/perf/util/synthetic-events.c | 10 +- tools/perf/util/thread-stack.c | 4 +- tools/perf/util/thread_map.c | 2 +- tools/perf/util/trace-event-parse.c | 2 +- tools/perf/util/unwind-libunwind-local.c | 9 +- 120 files changed, 898 insertions(+), 944 deletions(-)