Message ID | 20190910193347.16000-1-laurent@vivier.eu |
---|---|
Headers | show |
Series | hw/m68k: add Apple Machintosh Quadra 800 machine | expand |
Patchew URL: https://patchew.org/QEMU/20190910193347.16000-1-laurent@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190910193347.16000-1-laurent@vivier.eu Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 6c8a056 hw/m68k: define Macintosh Quadra 800 0a4fe5f hw/m68k: add a dummy SWIM floppy controller b2f7c98 hw/m68k: add Nubus support for macfb video card 5925088 hw/m68k: add Nubus support 9d7f87b hw/m68k: add macfb video card 57d3c1b hw/m68k: implement ADB bus support for via 79d3ec3 hw/m68k: add via support 3cd0a65 dp8393x: manage big endian bus 98468c1 esp: add pseudo-DMA as used by Macintosh === OUTPUT BEGIN === 1/9 Checking commit 98468c173c48 (esp: add pseudo-DMA as used by Macintosh) 2/9 Checking commit 3cd0a6527565 (dp8393x: manage big endian bus) 3/9 Checking commit 79d3ec37b19d (hw/m68k: add via support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #77: new file mode 100644 ERROR: space prohibited after that '&&' (ctx:WxW) #426: FILE: hw/misc/mac_via.c:345: + if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) { ^ total: 1 errors, 1 warnings, 867 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit 57d3c1b68d1b (hw/m68k: implement ADB bus support for via) 5/9 Checking commit 9d7f87b197f7 (hw/m68k: add macfb video card) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #68: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 59250888e2e4 (hw/m68k: add Nubus support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #62: new file mode 100644 total: 0 errors, 1 warnings, 532 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit b2f7c9845fe3 (hw/m68k: add Nubus support for macfb video card) 8/9 Checking commit 0a4fe5f04b97 (hw/m68k: add a dummy SWIM floppy controller) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 591 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit 6c8a0561eda1 (hw/m68k: define Macintosh Quadra 800) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #70: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190910193347.16000-1-laurent@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190910193347.16000-1-laurent@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190910193347.16000-1-laurent@vivier.eu Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 161e84d hw/m68k: define Macintosh Quadra 800 8e014ae hw/m68k: add a dummy SWIM floppy controller 48b413f hw/m68k: add Nubus support for macfb video card c85a9d0 hw/m68k: add Nubus support 2a9c811 hw/m68k: add macfb video card dd6f485 hw/m68k: implement ADB bus support for via 962fb19 hw/m68k: add via support bf2b5cd dp8393x: manage big endian bus b9f0b34 esp: add pseudo-DMA as used by Macintosh === OUTPUT BEGIN === 1/9 Checking commit b9f0b34536a6 (esp: add pseudo-DMA as used by Macintosh) 2/9 Checking commit bf2b5cdc0edd (dp8393x: manage big endian bus) 3/9 Checking commit 962fb196b521 (hw/m68k: add via support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #77: new file mode 100644 ERROR: space prohibited after that '&&' (ctx:WxW) #426: FILE: hw/misc/mac_via.c:345: + if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) { ^ total: 1 errors, 1 warnings, 867 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit dd6f4858fa7b (hw/m68k: implement ADB bus support for via) 5/9 Checking commit 2a9c811632ea (hw/m68k: add macfb video card) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #68: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit c85a9d0d90a0 (hw/m68k: add Nubus support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #62: new file mode 100644 total: 0 errors, 1 warnings, 532 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 48b413fb01cc (hw/m68k: add Nubus support for macfb video card) 8/9 Checking commit 8e014aea3937 (hw/m68k: add a dummy SWIM floppy controller) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 591 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit 161e84d328bc (hw/m68k: define Macintosh Quadra 800) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #70: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190910193347.16000-1-laurent@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190910193347.16000-1-laurent@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190910193347.16000-1-laurent@vivier.eu Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190911034302.29108-1-andrew@aj.id.au -> patchew/20190911034302.29108-1-andrew@aj.id.au Switched to a new branch 'test' ba04957 hw/m68k: define Macintosh Quadra 800 99060cf hw/m68k: add a dummy SWIM floppy controller d1012bd hw/m68k: add Nubus support for macfb video card 771de64 hw/m68k: add Nubus support 664a0d4 hw/m68k: add macfb video card d763a5e hw/m68k: implement ADB bus support for via c4005b8 hw/m68k: add via support 7032706 dp8393x: manage big endian bus 9ad093b esp: add pseudo-DMA as used by Macintosh === OUTPUT BEGIN === 1/9 Checking commit 9ad093b6ab18 (esp: add pseudo-DMA as used by Macintosh) 2/9 Checking commit 703270689bab (dp8393x: manage big endian bus) 3/9 Checking commit c4005b89095c (hw/m68k: add via support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #77: new file mode 100644 ERROR: space prohibited after that '&&' (ctx:WxW) #426: FILE: hw/misc/mac_via.c:345: + if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) { ^ total: 1 errors, 1 warnings, 867 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit d763a5ee0676 (hw/m68k: implement ADB bus support for via) 5/9 Checking commit 664a0d473afd (hw/m68k: add macfb video card) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #68: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 771de64f4aa2 (hw/m68k: add Nubus support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #62: new file mode 100644 total: 0 errors, 1 warnings, 532 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit d1012bd3f111 (hw/m68k: add Nubus support for macfb video card) 8/9 Checking commit 99060cf0bb1b (hw/m68k: add a dummy SWIM floppy controller) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 591 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit ba04957f42dd (hw/m68k: define Macintosh Quadra 800) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #70: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190910193347.16000-1-laurent@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190910193347.16000-1-laurent@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190910193347.16000-1-laurent@vivier.eu Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' a82c9f9 hw/m68k: define Macintosh Quadra 800 79df5b3 hw/m68k: add a dummy SWIM floppy controller 6cf208a hw/m68k: add Nubus support for macfb video card 5f38935 hw/m68k: add Nubus support be3903a hw/m68k: add macfb video card 7543084 hw/m68k: implement ADB bus support for via 126fd3e hw/m68k: add via support b1b5f5f dp8393x: manage big endian bus 81c722f esp: add pseudo-DMA as used by Macintosh === OUTPUT BEGIN === 1/9 Checking commit 81c722fdfd31 (esp: add pseudo-DMA as used by Macintosh) 2/9 Checking commit b1b5f5f329a2 (dp8393x: manage big endian bus) 3/9 Checking commit 126fd3e27620 (hw/m68k: add via support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #77: new file mode 100644 ERROR: space prohibited after that '&&' (ctx:WxW) #426: FILE: hw/misc/mac_via.c:345: + if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) { ^ total: 1 errors, 1 warnings, 867 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit 7543084b151c (hw/m68k: implement ADB bus support for via) 5/9 Checking commit be3903ae6e87 (hw/m68k: add macfb video card) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #68: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 5f389351a991 (hw/m68k: add Nubus support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #62: new file mode 100644 total: 0 errors, 1 warnings, 532 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 6cf208a8e54b (hw/m68k: add Nubus support for macfb video card) 8/9 Checking commit 79df5b3a854c (hw/m68k: add a dummy SWIM floppy controller) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 591 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit a82c9f9fafdc (hw/m68k: define Macintosh Quadra 800) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #70: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190910193347.16000-1-laurent@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190910193347.16000-1-laurent@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190910193347.16000-1-laurent@vivier.eu Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190911064920.1718-1-laurent@vivier.eu -> patchew/20190911064920.1718-1-laurent@vivier.eu Switched to a new branch 'test' 25caa2c hw/m68k: define Macintosh Quadra 800 cd09534 hw/m68k: add a dummy SWIM floppy controller c2d114a hw/m68k: add Nubus support for macfb video card 322bc5d hw/m68k: add Nubus support e89cb4f hw/m68k: add macfb video card 07131bc hw/m68k: implement ADB bus support for via 509b447 hw/m68k: add via support 522388d dp8393x: manage big endian bus d967bd4 esp: add pseudo-DMA as used by Macintosh === OUTPUT BEGIN === 1/9 Checking commit d967bd47bd5b (esp: add pseudo-DMA as used by Macintosh) 2/9 Checking commit 522388d60f5f (dp8393x: manage big endian bus) 3/9 Checking commit 509b447fb695 (hw/m68k: add via support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #77: new file mode 100644 ERROR: space prohibited after that '&&' (ctx:WxW) #426: FILE: hw/misc/mac_via.c:345: + if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) { ^ total: 1 errors, 1 warnings, 867 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit 07131bcb3f95 (hw/m68k: implement ADB bus support for via) 5/9 Checking commit e89cb4f88dbc (hw/m68k: add macfb video card) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #68: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 5/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/9 Checking commit 322bc5db6d96 (hw/m68k: add Nubus support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #62: new file mode 100644 total: 0 errors, 1 warnings, 532 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit c2d114a85b93 (hw/m68k: add Nubus support for macfb video card) 8/9 Checking commit cd0953416110 (hw/m68k: add a dummy SWIM floppy controller) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 591 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit 25caa2c0716f (hw/m68k: define Macintosh Quadra 800) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #70: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 9/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190910193347.16000-1-laurent@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com