mbox series

[V2,0/5] Add Xen COLO support

Message ID 20190609164433.5866-1-chen.zhang@intel.com
Headers show
Series Add Xen COLO support | expand

Message

Zhang, Chen June 9, 2019, 4:44 p.m. UTC
From: Zhang Chen <chen.zhang@intel.com>

Xen COLO based on KVM COLO architecture, it shared COLO proxy and block
replication with KVM COLO. The only differece is Xen COLO have own
COLO-frame to handle live migration related function, so we need this
series make Xen COLO frame can communicate with other COLO modules in
qemu. Xen side related patches have been merged.

V2:
 - Rebase on upstream code.
 - Optimize code by Zhijian's comments in patch 4/5.
 - Remove origin 5/6 patch.

V1:
 - Initial patch.

Zhang Chen (5):
  COLO-compare: Add new parameter to communicate with remote colo-frame
  COLO-compare: Add remote notification chardev handler frame
  COLO-compare: Make the compare_chr_send() can send notification
    message.
  COLO-compare: Add colo-compare remote notify support
  migration/colo.c: Add missed filter notify for Xen COLO.

 migration/colo.c   |   2 +
 net/colo-compare.c | 155 +++++++++++++++++++++++++++++++++++++++------
 qemu-options.hx    |  33 +++++++++-
 3 files changed, 171 insertions(+), 19 deletions(-)

Comments

Jason Wang June 10, 2019, 4:09 a.m. UTC | #1
On 2019/6/10 上午12:44, Zhang Chen wrote:
> From: Zhang Chen <chen.zhang@intel.com>
>
> Xen COLO based on KVM COLO architecture, it shared COLO proxy and block
> replication with KVM COLO. The only differece is Xen COLO have own
> COLO-frame to handle live migration related function, so we need this
> series make Xen COLO frame can communicate with other COLO modules in
> qemu. Xen side related patches have been merged.


Any pointer to this?

Thanks


>
> V2:
>   - Rebase on upstream code.
>   - Optimize code by Zhijian's comments in patch 4/5.
>   - Remove origin 5/6 patch.
>
> V1:
>   - Initial patch.
>
> Zhang Chen (5):
>    COLO-compare: Add new parameter to communicate with remote colo-frame
>    COLO-compare: Add remote notification chardev handler frame
>    COLO-compare: Make the compare_chr_send() can send notification
>      message.
>    COLO-compare: Add colo-compare remote notify support
>    migration/colo.c: Add missed filter notify for Xen COLO.
>
>   migration/colo.c   |   2 +
>   net/colo-compare.c | 155 +++++++++++++++++++++++++++++++++++++++------
>   qemu-options.hx    |  33 +++++++++-
>   3 files changed, 171 insertions(+), 19 deletions(-)
>
Zhang, Chen June 10, 2019, 5:56 a.m. UTC | #2
> -----Original Message-----
> From: Jason Wang [mailto:jasowang@redhat.com]
> Sent: Monday, June 10, 2019 12:09 PM
> To: Zhang, Chen <chen.zhang@intel.com>; Li Zhijian <lizhijian@cn.fujitsu.com>;
> Dr. David Alan Gilbert <dgilbert@redhat.com>; Juan Quintela
> <quintela@redhat.com>; zhanghailiang <zhang.zhanghailiang@huawei.com>;
> qemu-dev <qemu-devel@nongnu.org>; Stefano Stabellini
> <sstabellini@kernel.org>; Paul Durrant <paul.durrant@citrix.com>
> Cc: Zhang Chen <zhangckid@gmail.com>
> Subject: Re: [PATCH V2 0/5] Add Xen COLO support
> 
> 
> On 2019/6/10 上午12:44, Zhang Chen wrote:
> > From: Zhang Chen <chen.zhang@intel.com>
> >
> > Xen COLO based on KVM COLO architecture, it shared COLO proxy and
> > block replication with KVM COLO. The only differece is Xen COLO have
> > own COLO-frame to handle live migration related function, so we need
> > this series make Xen COLO frame can communicate with other COLO
> > modules in qemu. Xen side related patches have been merged.
> 
> 
> Any pointer to this?
> 

Yes, please see this thread:

https://lists.xen.org/archives/html/xen-devel/2017-03/msg00718.html

Thanks
Zhang Chen

> Thanks
> 
> 
> >
> > V2:
> >   - Rebase on upstream code.
> >   - Optimize code by Zhijian's comments in patch 4/5.
> >   - Remove origin 5/6 patch.
> >
> > V1:
> >   - Initial patch.
> >
> > Zhang Chen (5):
> >    COLO-compare: Add new parameter to communicate with remote colo-
> frame
> >    COLO-compare: Add remote notification chardev handler frame
> >    COLO-compare: Make the compare_chr_send() can send notification
> >      message.
> >    COLO-compare: Add colo-compare remote notify support
> >    migration/colo.c: Add missed filter notify for Xen COLO.
> >
> >   migration/colo.c   |   2 +
> >   net/colo-compare.c | 155 +++++++++++++++++++++++++++++++++++++++---
> ---
> >   qemu-options.hx    |  33 +++++++++-
> >   3 files changed, 171 insertions(+), 19 deletions(-)
> >
Zhang, Chen June 21, 2019, 6:43 a.m. UTC | #3
Anyone have any comments about this series?

Thanks
Zhang Chen


> -----Original Message-----
> From: Qemu-devel [mailto:qemu-devel-
> bounces+chen.zhang=intel.com@nongnu.org] On Behalf Of Zhang, Chen
> Sent: Monday, June 10, 2019 1:56 PM
> To: Jason Wang <jasowang@redhat.com>; Li Zhijian <lizhijian@cn.fujitsu.com>;
> Dr. David Alan Gilbert <dgilbert@redhat.com>; Juan Quintela
> <quintela@redhat.com>; zhanghailiang <zhang.zhanghailiang@huawei.com>;
> qemu-dev <qemu-devel@nongnu.org>; Stefano Stabellini
> <sstabellini@kernel.org>; Paul Durrant <paul.durrant@citrix.com>
> Cc: Zhang Chen <zhangckid@gmail.com>
> Subject: Re: [Qemu-devel] [PATCH V2 0/5] Add Xen COLO support
> 
> 
> 
> > -----Original Message-----
> > From: Jason Wang [mailto:jasowang@redhat.com]
> > Sent: Monday, June 10, 2019 12:09 PM
> > To: Zhang, Chen <chen.zhang@intel.com>; Li Zhijian
> > <lizhijian@cn.fujitsu.com>; Dr. David Alan Gilbert
> > <dgilbert@redhat.com>; Juan Quintela <quintela@redhat.com>;
> > zhanghailiang <zhang.zhanghailiang@huawei.com>; qemu-dev
> > <qemu-devel@nongnu.org>; Stefano Stabellini <sstabellini@kernel.org>;
> > Paul Durrant <paul.durrant@citrix.com>
> > Cc: Zhang Chen <zhangckid@gmail.com>
> > Subject: Re: [PATCH V2 0/5] Add Xen COLO support
> >
> >
> > On 2019/6/10 上午12:44, Zhang Chen wrote:
> > > From: Zhang Chen <chen.zhang@intel.com>
> > >
> > > Xen COLO based on KVM COLO architecture, it shared COLO proxy and
> > > block replication with KVM COLO. The only differece is Xen COLO have
> > > own COLO-frame to handle live migration related function, so we need
> > > this series make Xen COLO frame can communicate with other COLO
> > > modules in qemu. Xen side related patches have been merged.
> >
> >
> > Any pointer to this?
> >
> 
> Yes, please see this thread:
> 
> https://lists.xen.org/archives/html/xen-devel/2017-03/msg00718.html
> 
> Thanks
> Zhang Chen
> 
> > Thanks
> >
> >
> > >
> > > V2:
> > >   - Rebase on upstream code.
> > >   - Optimize code by Zhijian's comments in patch 4/5.
> > >   - Remove origin 5/6 patch.
> > >
> > > V1:
> > >   - Initial patch.
> > >
> > > Zhang Chen (5):
> > >    COLO-compare: Add new parameter to communicate with remote colo-
> > frame
> > >    COLO-compare: Add remote notification chardev handler frame
> > >    COLO-compare: Make the compare_chr_send() can send notification
> > >      message.
> > >    COLO-compare: Add colo-compare remote notify support
> > >    migration/colo.c: Add missed filter notify for Xen COLO.
> > >
> > >   migration/colo.c   |   2 +
> > >   net/colo-compare.c | 155
> > > +++++++++++++++++++++++++++++++++++++++---
> > ---
> > >   qemu-options.hx    |  33 +++++++++-
> > >   3 files changed, 171 insertions(+), 19 deletions(-)
> > >
Jason Wang June 21, 2019, 7:25 a.m. UTC | #4
On 2019/6/21 下午2:43, Zhang, Chen wrote:
> Anyone have any comments about this series?
>
> Thanks
> Zhang Chen


I will probably review and give feedback sometime next week.

Thanks


>
>
>> -----Original Message-----
>> From: Qemu-devel [mailto:qemu-devel-
>> bounces+chen.zhang=intel.com@nongnu.org] On Behalf Of Zhang, Chen
>> Sent: Monday, June 10, 2019 1:56 PM
>> To: Jason Wang <jasowang@redhat.com>; Li Zhijian <lizhijian@cn.fujitsu.com>;
>> Dr. David Alan Gilbert <dgilbert@redhat.com>; Juan Quintela
>> <quintela@redhat.com>; zhanghailiang <zhang.zhanghailiang@huawei.com>;
>> qemu-dev <qemu-devel@nongnu.org>; Stefano Stabellini
>> <sstabellini@kernel.org>; Paul Durrant <paul.durrant@citrix.com>
>> Cc: Zhang Chen <zhangckid@gmail.com>
>> Subject: Re: [Qemu-devel] [PATCH V2 0/5] Add Xen COLO support
>>
>>
>>
>>> -----Original Message-----
>>> From: Jason Wang [mailto:jasowang@redhat.com]
>>> Sent: Monday, June 10, 2019 12:09 PM
>>> To: Zhang, Chen <chen.zhang@intel.com>; Li Zhijian
>>> <lizhijian@cn.fujitsu.com>; Dr. David Alan Gilbert
>>> <dgilbert@redhat.com>; Juan Quintela <quintela@redhat.com>;
>>> zhanghailiang <zhang.zhanghailiang@huawei.com>; qemu-dev
>>> <qemu-devel@nongnu.org>; Stefano Stabellini <sstabellini@kernel.org>;
>>> Paul Durrant <paul.durrant@citrix.com>
>>> Cc: Zhang Chen <zhangckid@gmail.com>
>>> Subject: Re: [PATCH V2 0/5] Add Xen COLO support
>>>
>>>
>>> On 2019/6/10 上午12:44, Zhang Chen wrote:
>>>> From: Zhang Chen <chen.zhang@intel.com>
>>>>
>>>> Xen COLO based on KVM COLO architecture, it shared COLO proxy and
>>>> block replication with KVM COLO. The only differece is Xen COLO have
>>>> own COLO-frame to handle live migration related function, so we need
>>>> this series make Xen COLO frame can communicate with other COLO
>>>> modules in qemu. Xen side related patches have been merged.
>>>
>>> Any pointer to this?
>>>
>> Yes, please see this thread:
>>
>> https://lists.xen.org/archives/html/xen-devel/2017-03/msg00718.html
>>
>> Thanks
>> Zhang Chen
>>
>>> Thanks
>>>
>>>
>>>> V2:
>>>>    - Rebase on upstream code.
>>>>    - Optimize code by Zhijian's comments in patch 4/5.
>>>>    - Remove origin 5/6 patch.
>>>>
>>>> V1:
>>>>    - Initial patch.
>>>>
>>>> Zhang Chen (5):
>>>>     COLO-compare: Add new parameter to communicate with remote colo-
>>> frame
>>>>     COLO-compare: Add remote notification chardev handler frame
>>>>     COLO-compare: Make the compare_chr_send() can send notification
>>>>       message.
>>>>     COLO-compare: Add colo-compare remote notify support
>>>>     migration/colo.c: Add missed filter notify for Xen COLO.
>>>>
>>>>    migration/colo.c   |   2 +
>>>>    net/colo-compare.c | 155
>>>> +++++++++++++++++++++++++++++++++++++++---
>>> ---
>>>>    qemu-options.hx    |  33 +++++++++-
>>>>    3 files changed, 171 insertions(+), 19 deletions(-)
>>>>
Zhang, Chen June 21, 2019, 7:37 a.m. UTC | #5
> -----Original Message-----
> From: Jason Wang [mailto:jasowang@redhat.com]
> Sent: Friday, June 21, 2019 3:25 PM
> To: Zhang, Chen <chen.zhang@intel.com>; Li Zhijian <lizhijian@cn.fujitsu.com>;
> Dr. David Alan Gilbert <dgilbert@redhat.com>; Juan Quintela
> <quintela@redhat.com>; zhanghailiang <zhang.zhanghailiang@huawei.com>;
> qemu-dev <qemu-devel@nongnu.org>; Stefano Stabellini
> <sstabellini@kernel.org>; Paul Durrant <paul.durrant@citrix.com>
> Cc: Zhang Chen <zhangckid@gmail.com>
> Subject: Re: [PATCH V2 0/5] Add Xen COLO support
> 
> 
> On 2019/6/21 下午2:43, Zhang, Chen wrote:
> > Anyone have any comments about this series?
> >
> > Thanks
> > Zhang Chen
> 
> 
> I will probably review and give feedback sometime next week.
> 

Thank you Jason~ 

Thanks
Zhang Chen

> Thanks
> 
> 
> >
> >
> >> -----Original Message-----
> >> From: Qemu-devel [mailto:qemu-devel-
> >> bounces+chen.zhang=intel.com@nongnu.org] On Behalf Of Zhang, Chen
> >> Sent: Monday, June 10, 2019 1:56 PM
> >> To: Jason Wang <jasowang@redhat.com>; Li Zhijian
> >> <lizhijian@cn.fujitsu.com>; Dr. David Alan Gilbert
> >> <dgilbert@redhat.com>; Juan Quintela <quintela@redhat.com>;
> >> zhanghailiang <zhang.zhanghailiang@huawei.com>; qemu-dev
> >> <qemu-devel@nongnu.org>; Stefano Stabellini <sstabellini@kernel.org>;
> >> Paul Durrant <paul.durrant@citrix.com>
> >> Cc: Zhang Chen <zhangckid@gmail.com>
> >> Subject: Re: [Qemu-devel] [PATCH V2 0/5] Add Xen COLO support
> >>
> >>
> >>
> >>> -----Original Message-----
> >>> From: Jason Wang [mailto:jasowang@redhat.com]
> >>> Sent: Monday, June 10, 2019 12:09 PM
> >>> To: Zhang, Chen <chen.zhang@intel.com>; Li Zhijian
> >>> <lizhijian@cn.fujitsu.com>; Dr. David Alan Gilbert
> >>> <dgilbert@redhat.com>; Juan Quintela <quintela@redhat.com>;
> >>> zhanghailiang <zhang.zhanghailiang@huawei.com>; qemu-dev
> >>> <qemu-devel@nongnu.org>; Stefano Stabellini
> >>> <sstabellini@kernel.org>; Paul Durrant <paul.durrant@citrix.com>
> >>> Cc: Zhang Chen <zhangckid@gmail.com>
> >>> Subject: Re: [PATCH V2 0/5] Add Xen COLO support
> >>>
> >>>
> >>> On 2019/6/10 上午12:44, Zhang Chen wrote:
> >>>> From: Zhang Chen <chen.zhang@intel.com>
> >>>>
> >>>> Xen COLO based on KVM COLO architecture, it shared COLO proxy and
> >>>> block replication with KVM COLO. The only differece is Xen COLO
> >>>> have own COLO-frame to handle live migration related function, so
> >>>> we need this series make Xen COLO frame can communicate with other
> >>>> COLO modules in qemu. Xen side related patches have been merged.
> >>>
> >>> Any pointer to this?
> >>>
> >> Yes, please see this thread:
> >>
> >> https://lists.xen.org/archives/html/xen-devel/2017-03/msg00718.html
> >>
> >> Thanks
> >> Zhang Chen
> >>
> >>> Thanks
> >>>
> >>>
> >>>> V2:
> >>>>    - Rebase on upstream code.
> >>>>    - Optimize code by Zhijian's comments in patch 4/5.
> >>>>    - Remove origin 5/6 patch.
> >>>>
> >>>> V1:
> >>>>    - Initial patch.
> >>>>
> >>>> Zhang Chen (5):
> >>>>     COLO-compare: Add new parameter to communicate with remote
> >>>> colo-
> >>> frame
> >>>>     COLO-compare: Add remote notification chardev handler frame
> >>>>     COLO-compare: Make the compare_chr_send() can send notification
> >>>>       message.
> >>>>     COLO-compare: Add colo-compare remote notify support
> >>>>     migration/colo.c: Add missed filter notify for Xen COLO.
> >>>>
> >>>>    migration/colo.c   |   2 +
> >>>>    net/colo-compare.c | 155
> >>>> +++++++++++++++++++++++++++++++++++++++---
> >>> ---
> >>>>    qemu-options.hx    |  33 +++++++++-
> >>>>    3 files changed, 171 insertions(+), 19 deletions(-)
> >>>>
Jason Wang July 2, 2019, 2 a.m. UTC | #6
On 2019/6/10 上午12:44, Zhang Chen wrote:
> From: Zhang Chen <chen.zhang@intel.com>
>
> Xen COLO based on KVM COLO architecture, it shared COLO proxy and block
> replication with KVM COLO. The only differece is Xen COLO have own
> COLO-frame to handle live migration related function, so we need this
> series make Xen COLO frame can communicate with other COLO modules in
> qemu. Xen side related patches have been merged.
>
> V2:
>   - Rebase on upstream code.
>   - Optimize code by Zhijian's comments in patch 4/5.
>   - Remove origin 5/6 patch.
>
> V1:
>   - Initial patch.
>
> Zhang Chen (5):
>    COLO-compare: Add new parameter to communicate with remote colo-frame
>    COLO-compare: Add remote notification chardev handler frame
>    COLO-compare: Make the compare_chr_send() can send notification
>      message.
>    COLO-compare: Add colo-compare remote notify support
>    migration/colo.c: Add missed filter notify for Xen COLO.
>
>   migration/colo.c   |   2 +
>   net/colo-compare.c | 155 +++++++++++++++++++++++++++++++++++++++------
>   qemu-options.hx    |  33 +++++++++-
>   3 files changed, 171 insertions(+), 19 deletions(-)


Applied.

Thanks

>