| Message ID | 20190426190603.5982-2-linux@rasmusvillemoes.dk (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | None | expand |
On Fri, Apr 26, 2019 at 12:06 PM Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote: > > Current versions of clang does not like the %c modifier in inline > assembly for targets other than x86, so any DYNAMIC_DEBUG=y build > fails on ppc64. A fix is likely to land in 9.0 (see > https://github.com/ClangBuiltLinux/linux/issues/456), but unbreak the > build for older versions. > > Fixes: powerpc: select DYNAMIC_DEBUG_RELATIVE_POINTERS for PPC64 > Reported-by: Nathan Chancellor <natechancellor@gmail.com> > Reported-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Thanks for fixing the build. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > Andrew, please apply and/or fold into 10/10. > > arch/powerpc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index 6821c8ae1d62..8511137ab963 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -155,7 +155,7 @@ config PPC > select BUILDTIME_EXTABLE_SORT > select CLONE_BACKWARDS > select DCACHE_WORD_ACCESS if PPC64 && CPU_LITTLE_ENDIAN > - select DYNAMIC_DEBUG_RELATIVE_POINTERS if PPC64 > + select DYNAMIC_DEBUG_RELATIVE_POINTERS if PPC64 && (CC_IS_GCC || CLANG_VERSION >= 90000) > select DYNAMIC_FTRACE if FUNCTION_TRACER > select EDAC_ATOMIC_SCRUB > select EDAC_SUPPORT > -- > 2.20.1 >
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 6821c8ae1d62..8511137ab963 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -155,7 +155,7 @@ config PPC select BUILDTIME_EXTABLE_SORT select CLONE_BACKWARDS select DCACHE_WORD_ACCESS if PPC64 && CPU_LITTLE_ENDIAN - select DYNAMIC_DEBUG_RELATIVE_POINTERS if PPC64 + select DYNAMIC_DEBUG_RELATIVE_POINTERS if PPC64 && (CC_IS_GCC || CLANG_VERSION >= 90000) select DYNAMIC_FTRACE if FUNCTION_TRACER select EDAC_ATOMIC_SCRUB select EDAC_SUPPORT
Current versions of clang does not like the %c modifier in inline assembly for targets other than x86, so any DYNAMIC_DEBUG=y build fails on ppc64. A fix is likely to land in 9.0 (see https://github.com/ClangBuiltLinux/linux/issues/456), but unbreak the build for older versions. Fixes: powerpc: select DYNAMIC_DEBUG_RELATIVE_POINTERS for PPC64 Reported-by: Nathan Chancellor <natechancellor@gmail.com> Reported-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- Andrew, please apply and/or fold into 10/10. arch/powerpc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)