mbox series

[0/4] build: cleanup in Makefile.objs

Message ID 20190321124624.26131-1-lvivier@redhat.com
Headers show
Series build: cleanup in Makefile.objs | expand

Message

Laurent Vivier March 21, 2019, 12:46 p.m. UTC 
This cleanup removes hardware objects from the list of files to be
built for linux-user only targets.

It also builds traces files only when the related file is built.

Tested with:

   configure --enable-user --disable-system
   configure --disable-user --disable-system
   configure --disable-user --enable-system

Laurent Vivier (4):
  trace: only include trace-event-subdirs when they are needed
  ui: build keymap only with softmmu targets
  tools: edid-generate.c is part of the tools
  build: don't build hardware objects with linux-user

 Makefile               |  2 ++
 Makefile.objs          | 44 ++++++++++++++++++++++++------------------
 tests/Makefile.include | 26 ++++++++++++++-----------
 3 files changed, 42 insertions(+), 30 deletions(-)

Comments

Paolo Bonzini March 26, 2019, 9:02 a.m. UTC | #1 
On 21/03/19 13:46, Laurent Vivier wrote:
> This cleanup removes hardware objects from the list of files to be
> built for linux-user only targets.
> 
> It also builds traces files only when the related file is built.
> 
> Tested with:
> 
>    configure --enable-user --disable-system
>    configure --disable-user --disable-system
>    configure --disable-user --enable-system
> 
> Laurent Vivier (4):
>   trace: only include trace-event-subdirs when they are needed
>   ui: build keymap only with softmmu targets
>   tools: edid-generate.c is part of the tools
>   build: don't build hardware objects with linux-user
> 
>  Makefile               |  2 ++
>  Makefile.objs          | 44 ++++++++++++++++++++++++------------------
>  tests/Makefile.include | 26 ++++++++++++++-----------
>  3 files changed, 42 insertions(+), 30 deletions(-)
> 

Hi Laurent,

I am not sure if the extra complexity is worth the reduction in build
times for the --disable-system case, but I guess a simpler version of
these patches would be okay.

Paolo