Message ID | 20180731084203.29959-1-laurent@vivier.eu |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180731084203.29959-1-laurent@vivier.eu Subject: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 806398c875 linux-user: ppc64: don't use volatile register during safe_syscall ba78346662 tests: add check_invalid_maps to test-mmap 80fc1be868 linux-user/mmap.c: handle invalid len maps correctly === OUTPUT BEGIN === Checking PATCH 1/3: linux-user/mmap.c: handle invalid len maps correctly... Checking PATCH 2/3: tests: add check_invalid_maps to test-mmap... ERROR: code indent should never use tabs #62: FILE: tests/tcg/multiarch/test-mmap.c:498: +^Icheck_invalid_mmaps();$ total: 1 errors, 0 warnings, 40 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/3: linux-user: ppc64: don't use volatile register during safe_syscall... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Laurent Vivier <laurent@vivier.eu> writes: > Le 31/07/2018 à 14:24, no-reply@patchew.org a écrit: >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: >> >> Type: series >> Message-id: 20180731084203.29959-1-laurent@vivier.eu >> Subject: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches >> >> === TEST SCRIPT BEGIN === >> #!/bin/bash >> >> BASE=base >> n=1 >> total=$(git log --oneline $BASE.. | wc -l) >> failed=0 >> >> git config --local diff.renamelimit 0 >> git config --local diff.renames True >> git config --local diff.algorithm histogram >> >> commits="$(git log --format=%H --reverse $BASE..)" >> for c in $commits; do >> echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." >> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then >> failed=1 >> echo >> fi >> n=$((n+1)) >> done >> >> exit $failed >> === TEST SCRIPT END === >> >> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 >> Switched to a new branch 'test' >> 806398c875 linux-user: ppc64: don't use volatile register during safe_syscall >> ba78346662 tests: add check_invalid_maps to test-mmap >> 80fc1be868 linux-user/mmap.c: handle invalid len maps correctly >> >> === OUTPUT BEGIN === >> Checking PATCH 1/3: linux-user/mmap.c: handle invalid len maps correctly... >> Checking PATCH 2/3: tests: add check_invalid_maps to test-mmap... >> ERROR: code indent should never use tabs >> #62: FILE: tests/tcg/multiarch/test-mmap.c:498: >> +^Icheck_invalid_mmaps();$ Sorry I should of flagged this in the commit message. I left the touched bits as is and used spaces for new functions. >> >> total: 1 errors, 0 warnings, 40 lines checked > > I'm going to resend a pull request without the tab. > > Thanks, > Laurent -- Alex Bennée
On 31 July 2018 at 09:42, Laurent Vivier <laurent@vivier.eu> wrote: > The following changes since commit 6d9dd5fb9d0e9f4a174f53a0e20a39fbe809c71e: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qobject-2018-07-27-v2' into staging (2018-07-30 09:55:47 +0100) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-3.0-pull-request > > for you to fetch changes up to 5d9f3ea0817215ad4baac5aa30414e9ebbaaf0d6: > > linux-user: ppc64: don't use volatile register during safe_syscall (2018-07-31 09:57:43 +0200) > > ---------------------------------------------------------------- > Fix safe_syscall() on ppc64 host > Fix mmap() 0 length error case > > ---------------------------------------------------------------- Applied, thanks. -- PMM