Message ID | 20180604152015.13359-1-laurent@vivier.eu |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180604152015.13359-1-laurent@vivier.eu Subject: [Qemu-devel] [PULL 00/17] Linux user for 3.0 patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20180604152015.13359-1-laurent@vivier.eu -> patchew/20180604152015.13359-1-laurent@vivier.eu Switched to a new branch 'test' b10478242d linux-user: remove useless #if 7e14034963 linux-user: move hppa signal definitions to hppa/target_signal.h 00c6a0fd0f linux-user: move alpha signal definitions to alpha/target_signal.h 7eb8748ab0 linux-user: move openrisc signal definitions to openrisc/target_signal.h 1cc90355ad linux-user: move mips signal definitions to mips/target_signal.h 5065e2156d linux-user: move sparc signal definitions to sparc/target_signal.h 773e331d15 linux-user: move generic signal definitions to generic/signal.h b171890620 linux-user: move get_sp_from_cpustate() to target_cpu.h 98f034ebc3 linux-user: move sparc/sparc64 fcntl definitions to sparc/target_fcntl.h 2593fb53e0 linux-user: move ppc fcntl definitions to ppc/target_fcntl.h 81ea11e0bb linux-user: move mips/mips64 fcntl definitions to mips/target_fcntl.h 79d45083df linux-user: move arm/aarch64/m68k fcntl definitions to [arm|aarch64|m68k]/target_fcntl.h 094dc23513 linux-user: move hppa fcntl definitions to hppa/target_fcntl.h c269473465 linux-user: move alpha fcntl definitions to alpha/target_fcntl.h d6b1545efd linux-user: move generic fcntl definitions to generic/fcntl.h 8722c0d847 linux-user: SPARC "rd %tick" can be used by user application 66eb4d4878 syscall: replace strcpy() by g_strlcpy() === OUTPUT BEGIN === Checking PATCH 1/17: syscall: replace strcpy() by g_strlcpy()... Checking PATCH 2/17: linux-user: SPARC "rd %tick" can be used by user application... Checking PATCH 3/17: linux-user: move generic fcntl definitions to generic/fcntl.h... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 528 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/17: linux-user: move alpha fcntl definitions to alpha/target_fcntl.h... Checking PATCH 5/17: linux-user: move hppa fcntl definitions to hppa/target_fcntl.h... Checking PATCH 6/17: linux-user: move arm/aarch64/m68k fcntl definitions to [arm|aarch64|m68k]/target_fcntl.h... Checking PATCH 7/17: linux-user: move mips/mips64 fcntl definitions to mips/target_fcntl.h... ERROR: space prohibited between function name and open parenthesis '(' #99: FILE: linux-user/syscall_defs.h:2429: +#if defined (TARGET_PPC) total: 1 errors, 0 warnings, 87 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 8/17: linux-user: move ppc fcntl definitions to ppc/target_fcntl.h... ERROR: space prohibited between function name and open parenthesis '(' #42: FILE: linux-user/syscall_defs.h:2429: +#if defined (TARGET_SPARC) total: 1 errors, 0 warnings, 24 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 9/17: linux-user: move sparc/sparc64 fcntl definitions to sparc/target_fcntl.h... Checking PATCH 10/17: linux-user: move get_sp_from_cpustate() to target_cpu.h... Checking PATCH 11/17: linux-user: move generic signal definitions to generic/signal.h... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 219 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 12/17: linux-user: move sparc signal definitions to sparc/target_signal.h... Checking PATCH 13/17: linux-user: move mips signal definitions to mips/target_signal.h... WARNING: line over 80 characters #41: FILE: linux-user/mips/target_signal.h:24: +#define TARGET_SIGCLD TARGET_SIGCHLD /* Same as TARGET_SIGCHLD (System V). */ WARNING: line over 80 characters #44: FILE: linux-user/mips/target_signal.h:27: +#define TARGET_SIGURG 21 /* Urgent condition on socket (4.2 BSD). */ WARNING: line over 80 characters #46: FILE: linux-user/mips/target_signal.h:29: +#define TARGET_SIGPOLL TARGET_SIGIO /* Pollable event occurred (System V). */ WARNING: line over 80 characters #55: FILE: linux-user/mips/target_signal.h:38: +#define TARGET_SIGXFSZ 31 /* File size limit exceeded (4.2 BSD). */ WARNING: line over 80 characters #109: FILE: linux-user/mips64/target_signal.h:24: +#define TARGET_SIGCLD TARGET_SIGCHLD /* Same as TARGET_SIGCHLD (System V). */ WARNING: line over 80 characters #112: FILE: linux-user/mips64/target_signal.h:27: +#define TARGET_SIGURG 21 /* Urgent condition on socket (4.2 BSD). */ WARNING: line over 80 characters #114: FILE: linux-user/mips64/target_signal.h:29: +#define TARGET_SIGPOLL TARGET_SIGIO /* Pollable event occurred (System V). */ WARNING: line over 80 characters #123: FILE: linux-user/mips64/target_signal.h:38: +#define TARGET_SIGXFSZ 31 /* File size limit exceeded (4.2 BSD). */ total: 0 errors, 8 warnings, 191 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 14/17: linux-user: move openrisc signal definitions to openrisc/target_signal.h... Checking PATCH 15/17: linux-user: move alpha signal definitions to alpha/target_signal.h... Checking PATCH 16/17: linux-user: move hppa signal definitions to hppa/target_signal.h... Checking PATCH 17/17: linux-user: remove useless #if... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 4 June 2018 at 16:19, Laurent Vivier <laurent@vivier.eu> wrote: > The following changes since commit 392fba9f583223786f844dce9b2e7f9a0ce0147a: > > Merge remote-tracking branch 'remotes/stsquad/tags/pull-travis-updates-010618-1' into staging (2018-06-01 17:32:30 +0100) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-3.0-pull-request > > for you to fetch changes up to 7ea65371ee6ba714c5b369b38dd608b128dab57c: > > linux-user: remove useless #if (2018-06-04 01:30:44 +0200) > > ---------------------------------------------------------------- > move more data to arch specific files > fix SPARC %tick > replace strcpy() by g_strlcpy() in syscall.c > > ---------------------------------------------------------------- Applied, thanks. -- PMM