Message ID | 20180519092956.15134-1-laurent@vivier.eu |
---|---|
Headers | show |
Series | linux-user: move socket.h definitions to CPU directories | expand |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180519092956.15134-1-laurent@vivier.eu Subject: [Qemu-devel] [PATCH v3 0/8] linux-user: move socket.h definitions to CPU directories === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20180519092956.15134-1-laurent@vivier.eu -> patchew/20180519092956.15134-1-laurent@vivier.eu Switched to a new branch 'test' 4302e15b3c linux-user: define TARGET_SO_REUSEPORT 79f9d462e0 linux-user: copy sparc/sockbits.h definitions from linux 4d4d80f6dd linux-user: update ARCH_HAS_SOCKET_TYPES use f90eb19225 linux-user: move ppc socket.h definitions to ppc/sockbits.h a159233782 linux-user: move socket.h generic definitions to generic/sockbits.h 7bda50c2b9 linux-user: move sparc/sparc64 socket.h definitions to sparc/sockbits.h 1e5e7d107e linux-user: move alpha socket.h definitions to alpha/sockbits.h 9675bdc0c5 linux-user: move mips socket.h definitions to mips/sockbits.h === OUTPUT BEGIN === Checking PATCH 1/8: linux-user: move mips socket.h definitions to mips/sockbits.h... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 ERROR: if this code is redundant consider removing it #52: FILE: linux-user/mips/sockbits.h:31: +#if 0 total: 1 errors, 1 warnings, 227 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/8: linux-user: move alpha socket.h definitions to alpha/sockbits.h... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 224 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/8: linux-user: move sparc/sparc64 socket.h definitions to sparc/sockbits.h... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #74: new file mode 100644 total: 0 errors, 1 warnings, 146 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/8: linux-user: move socket.h generic definitions to generic/sockbits.h... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 148 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 5/8: linux-user: move ppc socket.h definitions to ppc/sockbits.h... Checking PATCH 6/8: linux-user: update ARCH_HAS_SOCKET_TYPES use... Checking PATCH 7/8: linux-user: copy sparc/sockbits.h definitions from linux... Checking PATCH 8/8: linux-user: define TARGET_SO_REUSEPORT... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com