Message ID | 20180430170156.1860-1-laurent@vivier.eu |
---|---|
State | New |
Headers | show |
Series | [1/2] m68k: Fix floatx80_lognp1 (Coverity CID1390587) | expand |
On 30 April 2018 at 18:01, Laurent Vivier <laurent@vivier.eu> wrote: > return the result of packFloatx80() instead of > dropping it. > > Signed-off-by: Laurent Vivier <laurent@vivier.eu> > --- > target/m68k/softfloat.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/m68k/softfloat.c b/target/m68k/softfloat.c > index dffb371c71..2c069a5efb 100644 > --- a/target/m68k/softfloat.c > +++ b/target/m68k/softfloat.c > @@ -334,7 +334,8 @@ floatx80 floatx80_lognp1(floatx80 a, float_status *status) > if (aSign && aExp >= one_exp) { > if (aExp == one_exp && aSig == one_sig) { > float_raise(float_flag_divbyzero, status); > - packFloatx80(aSign, floatx80_infinity.high, floatx80_infinity.low); > + return packFloatx80(aSign, floatx80_infinity.high, > + floatx80_infinity.low); > } > float_raise(float_flag_invalid, status); > return floatx80_default_nan(status); Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
On 04/30/2018 02:01 PM, Laurent Vivier wrote: > return the result of packFloatx80() instead of > dropping it. (missed in 4b5c65b8f02). > > Signed-off-by: Laurent Vivier <laurent@vivier.eu> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > target/m68k/softfloat.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/m68k/softfloat.c b/target/m68k/softfloat.c > index dffb371c71..2c069a5efb 100644 > --- a/target/m68k/softfloat.c > +++ b/target/m68k/softfloat.c > @@ -334,7 +334,8 @@ floatx80 floatx80_lognp1(floatx80 a, float_status *status) > if (aSign && aExp >= one_exp) { > if (aExp == one_exp && aSig == one_sig) { > float_raise(float_flag_divbyzero, status); > - packFloatx80(aSign, floatx80_infinity.high, floatx80_infinity.low); > + return packFloatx80(aSign, floatx80_infinity.high, > + floatx80_infinity.low); > } > float_raise(float_flag_invalid, status); > return floatx80_default_nan(status); >
diff --git a/target/m68k/softfloat.c b/target/m68k/softfloat.c index dffb371c71..2c069a5efb 100644 --- a/target/m68k/softfloat.c +++ b/target/m68k/softfloat.c @@ -334,7 +334,8 @@ floatx80 floatx80_lognp1(floatx80 a, float_status *status) if (aSign && aExp >= one_exp) { if (aExp == one_exp && aSig == one_sig) { float_raise(float_flag_divbyzero, status); - packFloatx80(aSign, floatx80_infinity.high, floatx80_infinity.low); + return packFloatx80(aSign, floatx80_infinity.high, + floatx80_infinity.low); } float_raise(float_flag_invalid, status); return floatx80_default_nan(status);
return the result of packFloatx80() instead of dropping it. Signed-off-by: Laurent Vivier <laurent@vivier.eu> --- target/m68k/softfloat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)