Message ID | 20180328133152.24623-1-lvivier@redhat.com |
---|---|
State | New |
Headers | show |
Series | tcg: fix 16-byte vector operations detection | expand |
On Wed, Mar 28, 2018 at 03:31:52PM +0200, Laurent Vivier wrote: > configure tries to detect if the compiler > supports 16-byte vector operations. > > As stated in the comment of the detection > program, there is a problem with the system > compiler on GCC on Centos 7. > > This program doesn't actually detect the problem > with GCC on RHEL7 on PPC64LE (Red Hat 4.8.5-28). > > This patch updates the test to look more like > it is in QEMU helpers, and now detects the problem. > > The error reported is: > > CC ppc64-softmmu/accel/tcg/tcg-runtime-gvec.o > ..//accel/tcg/tcg-runtime-gvec.c: In function ‘helper_gvec_shl8i’: > ../accel/tcg/tcg-runtime-gvec.c:558:26: internal compiler error: in emit_move_insn, at expr.c:3495 > *(vec8 *)(d + i) = *(vec8 *)(a + i) << shift; > ^ > Fixes: db43267 "tcg: Add generic vector expanders" > Signed-off-by: Laurent Vivier <lvivier@redhat.com> > --- > configure | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/configure b/configure > index 4d0e92c96c..a2301dd0dc 100755 > --- a/configure > +++ b/configure > @@ -5054,6 +5054,14 @@ static S2 c2; > static S4 c4; > static S8 c8; > static int i; > +void helper(void *d, void *a, int shift, int i); > +void helper(void *d, void *a, int shift, int i) > +{ > + *(U1 *)(d + i) = *(U1 *)(a + i) << shift; > + *(U2 *)(d + i) = *(U2 *)(a + i) << shift; > + *(U4 *)(d + i) = *(U4 *)(a + i) << shift; > + *(U8 *)(d + i) = *(U8 *)(a + i) << shift; > +} > int main(void) > { > a1 += b1; a2 += b2; a4 += b4; a8 += b8; > -- > 2.14.3 > > Build works correctly for RHEL 7 with this patch Reviewed-by: Miroslav Rezanina <mrezanin@redhat.com>
Hi, I think it would be good to have this fix (or something similar) in -rc2. Without this we can't build QEMU 2.12 PPC64LE for RHEL7 [1] Any comment? Thanks, Laurent [1] we have bugzilla for RHEL7 GCC, https://bugzilla.redhat.com/show_bug.cgi?id=1546728 but as configure provides a way to workaround the problem we should also fix configure. On 28/03/2018 15:31, Laurent Vivier wrote: > configure tries to detect if the compiler > supports 16-byte vector operations. > > As stated in the comment of the detection > program, there is a problem with the system > compiler on GCC on Centos 7. > > This program doesn't actually detect the problem > with GCC on RHEL7 on PPC64LE (Red Hat 4.8.5-28). > > This patch updates the test to look more like > it is in QEMU helpers, and now detects the problem. > > The error reported is: > > CC ppc64-softmmu/accel/tcg/tcg-runtime-gvec.o > ..//accel/tcg/tcg-runtime-gvec.c: In function ‘helper_gvec_shl8i’: > ../accel/tcg/tcg-runtime-gvec.c:558:26: internal compiler error: in emit_move_insn, at expr.c:3495 > *(vec8 *)(d + i) = *(vec8 *)(a + i) << shift; > ^ > Fixes: db43267 "tcg: Add generic vector expanders" > Signed-off-by: Laurent Vivier <lvivier@redhat.com> > --- > configure | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/configure b/configure > index 4d0e92c96c..a2301dd0dc 100755 > --- a/configure > +++ b/configure > @@ -5054,6 +5054,14 @@ static S2 c2; > static S4 c4; > static S8 c8; > static int i; > +void helper(void *d, void *a, int shift, int i); > +void helper(void *d, void *a, int shift, int i) > +{ > + *(U1 *)(d + i) = *(U1 *)(a + i) << shift; > + *(U2 *)(d + i) = *(U2 *)(a + i) << shift; > + *(U4 *)(d + i) = *(U4 *)(a + i) << shift; > + *(U8 *)(d + i) = *(U8 *)(a + i) << shift; > +} > int main(void) > { > a1 += b1; a2 += b2; a4 += b4; a8 += b8; >
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180328133152.24623-1-lvivier@redhat.com Subject: [Qemu-devel] [PATCH] tcg: fix 16-byte vector operations detection === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=8 time make docker-test-build@min-glib === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' e73ef6dd1d tcg: fix 16-byte vector operations detection === OUTPUT BEGIN === Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Cloning into '/var/tmp/patchew-tester-tmp-i74o88wx/src/dtc'... Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42' BUILD min-glib make[1]: Entering directory '/var/tmp/patchew-tester-tmp-i74o88wx/src' GEN /var/tmp/patchew-tester-tmp-i74o88wx/src/docker-src.2018-03-31-03.48.07.32210/qemu.tar Cloning into '/var/tmp/patchew-tester-tmp-i74o88wx/src/docker-src.2018-03-31-03.48.07.32210/qemu.tar.vroot'... done. Checking out files: 26% (1598/6066) Checking out files: 27% (1638/6066) Checking out files: 28% (1699/6066) Checking out files: 29% (1760/6066) Checking out files: 30% (1820/6066) Checking out files: 31% (1881/6066) Checking out files: 32% (1942/6066) Checking out files: 33% (2002/6066) Checking out files: 34% (2063/6066) Checking out files: 35% (2124/6066) Checking out files: 36% (2184/6066) Checking out files: 37% (2245/6066) Checking out files: 38% (2306/6066) Checking out files: 38% (2311/6066) Checking out files: 39% (2366/6066) Checking out files: 40% (2427/6066) Checking out files: 41% (2488/6066) Checking out files: 42% (2548/6066) Checking out files: 43% (2609/6066) Checking out files: 44% (2670/6066) Checking out files: 45% (2730/6066) Checking out files: 46% (2791/6066) Checking out files: 47% (2852/6066) Checking out files: 48% (2912/6066) Checking out files: 49% (2973/6066) Checking out files: 50% (3033/6066) Checking out files: 51% (3094/6066) Checking out files: 52% (3155/6066) Checking out files: 53% (3215/6066) Checking out files: 54% (3276/6066) Checking out files: 55% (3337/6066) Checking out files: 56% (3397/6066) Checking out files: 57% (3458/6066) Checking out files: 58% (3519/6066) Checking out files: 59% (3579/6066) Checking out files: 60% (3640/6066) Checking out files: 61% (3701/6066) Checking out files: 62% (3761/6066) Checking out files: 63% (3822/6066) Checking out files: 64% (3883/6066) Checking out files: 65% (3943/6066) Checking out files: 66% (4004/6066) Checking out files: 67% (4065/6066) Checking out files: 68% (4125/6066) Checking out files: 69% (4186/6066) Checking out files: 70% (4247/6066) Checking out files: 71% (4307/6066) Checking out files: 72% (4368/6066) Checking out files: 73% (4429/6066) Checking out files: 74% (4489/6066) Checking out files: 75% (4550/6066) Checking out files: 76% (4611/6066) Checking out files: 76% (4650/6066) Checking out files: 77% (4671/6066) Checking out files: 78% (4732/6066) Checking out files: 79% (4793/6066) Checking out files: 80% (4853/6066) Checking out files: 81% (4914/6066) Checking out files: 82% (4975/6066) Checking out files: 83% (5035/6066) Checking out files: 83% (5067/6066) Checking out files: 84% (5096/6066) Checking out files: 85% (5157/6066) Checking out files: 86% (5217/6066) Checking out files: 87% (5278/6066) Checking out files: 88% (5339/6066) Checking out files: 89% (5399/6066) Checking out files: 90% (5460/6066) Checking out files: 91% (5521/6066) Checking out files: 92% (5581/6066) Checking out files: 93% (5642/6066) Checking out files: 94% (5703/6066) Checking out files: 95% (5763/6066) Checking out files: 96% (5824/6066) Checking out files: 97% (5885/6066) Checking out files: 98% (5945/6066) Checking out files: 99% (6006/6066) Checking out files: 99% (6023/6066) Checking out files: 100% (6066/6066) Checking out files: 100% (6066/6066), done. Your branch is up-to-date with 'origin/test'. Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Cloning into '/var/tmp/patchew-tester-tmp-i74o88wx/src/docker-src.2018-03-31-03.48.07.32210/qemu.tar.vroot/dtc'... Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42' Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into '/var/tmp/patchew-tester-tmp-i74o88wx/src/docker-src.2018-03-31-03.48.07.32210/qemu.tar.vroot/ui/keycodemapdb'... Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce' tar: /var/tmp/patchew-tester-tmp-i74o88wx/src/docker-src.2018-03-31-03.48.07.32210/qemu.tar: Wrote only 2048 of 10240 bytes tar: Error is not recoverable: exiting now failed to create tar file COPY RUNNER RUN test-build in qemu:min-glib tar: Unexpected EOF in archive tar: rmtlseek not stopped at a record boundary tar: Error is not recoverable: exiting now /var/tmp/qemu/run: line 32: prep_fail: command not found Environment variables: HOSTNAME=5fd8e1f189a4 MAKEFLAGS= -j8 J=8 CCACHE_DIR=/var/tmp/ccache EXTRA_CONFIGURE_OPTS= V= SHOW_ENV=1 PATH=/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD=/ TARGET_LIST= SHLVL=1 HOME=/root TEST_DIR=/tmp/qemu-test FEATURES= dtc DEBUG= _=/usr/bin/env /var/tmp/qemu/run: line 52: cd: /tmp/qemu-test/src/tests/docker: No such file or directory /var/tmp/qemu/run: line 57: /test-build: No such file or directory /var/tmp/qemu/run: line 57: exec: /test-build: cannot execute: No such file or directory Traceback (most recent call last): File "./tests/docker/docker.py", line 407, in <module> sys.exit(main()) File "./tests/docker/docker.py", line 404, in main return args.cmdobj.run(args, argv) File "./tests/docker/docker.py", line 261, in run return Docker().run(argv, args.keep, quiet=args.quiet) File "./tests/docker/docker.py", line 229, in run quiet=quiet) File "./tests/docker/docker.py", line 147, in _do_check return subprocess.check_call(self._command + cmd, **kwargs) File "/usr/lib64/python2.7/subprocess.py", line 186, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['docker', 'run', '--label', 'com.qemu.instance.uuid=e8b34b6034b711e886e352540069c830', '-u', '0', '--security-opt', 'seccomp=unconfined', '--rm', '--net=none', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=8', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/root/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-i74o88wx/src/docker-src.2018-03-31-03.48.07.32210:/var/tmp/qemu:z,ro', 'qemu:min-glib', '/var/tmp/qemu/run', 'test-build']' returned non-zero exit status 126 make[1]: *** [tests/docker/Makefile.include:129: docker-run] Error 1 make[1]: Leaving directory '/var/tmp/patchew-tester-tmp-i74o88wx/src' make: *** [tests/docker/Makefile.include:163: docker-run-test-build@min-glib] Error 2 real 0m38.003s user 0m8.962s sys 0m6.700s === OUTPUT END === Test command exited with code: 2 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 29/03/2018 18:54, Laurent Vivier wrote: > Hi, > > I think it would be good to have this fix (or something similar) in -rc2. So no one agrees with that? Thanks, Laurent
On 3 April 2018 at 16:45, Laurent Vivier <lvivier@redhat.com> wrote: > On 29/03/2018 18:54, Laurent Vivier wrote: >> Hi, >> >> I think it would be good to have this fix (or something similar) in -rc2. > > So no one agrees with that? Applied to master, thanks. -- PMM
On 28/03/2018 15:31, Laurent Vivier wrote: > configure tries to detect if the compiler > supports 16-byte vector operations. > > As stated in the comment of the detection > program, there is a problem with the system > compiler on GCC on Centos 7. > > This program doesn't actually detect the problem > with GCC on RHEL7 on PPC64LE (Red Hat 4.8.5-28). > > This patch updates the test to look more like > it is in QEMU helpers, and now detects the problem. > > The error reported is: > > CC ppc64-softmmu/accel/tcg/tcg-runtime-gvec.o > ..//accel/tcg/tcg-runtime-gvec.c: In function ‘helper_gvec_shl8i’: > ../accel/tcg/tcg-runtime-gvec.c:558:26: internal compiler error: in emit_move_insn, at expr.c:3495 > *(vec8 *)(d + i) = *(vec8 *)(a + i) << shift; > ^ > Fixes: db43267 "tcg: Add generic vector expanders" > Signed-off-by: Laurent Vivier <lvivier@redhat.com> > --- > configure | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/configure b/configure > index 4d0e92c96c..a2301dd0dc 100755 > --- a/configure > +++ b/configure > @@ -5054,6 +5054,14 @@ static S2 c2; > static S4 c4; > static S8 c8; > static int i; > +void helper(void *d, void *a, int shift, int i); > +void helper(void *d, void *a, int shift, int i) > +{ > + *(U1 *)(d + i) = *(U1 *)(a + i) << shift; > + *(U2 *)(d + i) = *(U2 *)(a + i) << shift; > + *(U4 *)(d + i) = *(U4 *)(a + i) << shift; > + *(U8 *)(d + i) = *(U8 *)(a + i) << shift; > +} > int main(void) > { > a1 += b1; a2 += b2; a4 += b4; a8 += b8; > Queued, thanks. Paolo
On 5 April 2018 at 21:31, Paolo Bonzini <pbonzini@redhat.com> wrote: > On 28/03/2018 15:31, Laurent Vivier wrote: >> configure tries to detect if the compiler >> supports 16-byte vector operations. >> >> As stated in the comment of the detection >> program, there is a problem with the system >> compiler on GCC on Centos 7. >> >> This program doesn't actually detect the problem >> with GCC on RHEL7 on PPC64LE (Red Hat 4.8.5-28). >> >> This patch updates the test to look more like >> it is in QEMU helpers, and now detects the problem. >> >> The error reported is: >> >> CC ppc64-softmmu/accel/tcg/tcg-runtime-gvec.o >> ..//accel/tcg/tcg-runtime-gvec.c: In function ‘helper_gvec_shl8i’: >> ../accel/tcg/tcg-runtime-gvec.c:558:26: internal compiler error: in emit_move_insn, at expr.c:3495 >> *(vec8 *)(d + i) = *(vec8 *)(a + i) << shift; >> ^ >> Fixes: db43267 "tcg: Add generic vector expanders" >> Signed-off-by: Laurent Vivier <lvivier@redhat.com> >> --- >> configure | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/configure b/configure >> index 4d0e92c96c..a2301dd0dc 100755 >> --- a/configure >> +++ b/configure >> @@ -5054,6 +5054,14 @@ static S2 c2; >> static S4 c4; >> static S8 c8; >> static int i; >> +void helper(void *d, void *a, int shift, int i); >> +void helper(void *d, void *a, int shift, int i) >> +{ >> + *(U1 *)(d + i) = *(U1 *)(a + i) << shift; >> + *(U2 *)(d + i) = *(U2 *)(a + i) << shift; >> + *(U4 *)(d + i) = *(U4 *)(a + i) << shift; >> + *(U8 *)(d + i) = *(U8 *)(a + i) << shift; >> +} >> int main(void) >> { >> a1 += b1; a2 += b2; a4 += b4; a8 += b8; >> > > Queued, thanks. This is already in master... thanks -- PMM
diff --git a/configure b/configure index 4d0e92c96c..a2301dd0dc 100755 --- a/configure +++ b/configure @@ -5054,6 +5054,14 @@ static S2 c2; static S4 c4; static S8 c8; static int i; +void helper(void *d, void *a, int shift, int i); +void helper(void *d, void *a, int shift, int i) +{ + *(U1 *)(d + i) = *(U1 *)(a + i) << shift; + *(U2 *)(d + i) = *(U2 *)(a + i) << shift; + *(U4 *)(d + i) = *(U4 *)(a + i) << shift; + *(U8 *)(d + i) = *(U8 *)(a + i) << shift; +} int main(void) { a1 += b1; a2 += b2; a4 += b4; a8 += b8;
configure tries to detect if the compiler supports 16-byte vector operations. As stated in the comment of the detection program, there is a problem with the system compiler on GCC on Centos 7. This program doesn't actually detect the problem with GCC on RHEL7 on PPC64LE (Red Hat 4.8.5-28). This patch updates the test to look more like it is in QEMU helpers, and now detects the problem. The error reported is: CC ppc64-softmmu/accel/tcg/tcg-runtime-gvec.o ..//accel/tcg/tcg-runtime-gvec.c: In function ‘helper_gvec_shl8i’: ../accel/tcg/tcg-runtime-gvec.c:558:26: internal compiler error: in emit_move_insn, at expr.c:3495 *(vec8 *)(d + i) = *(vec8 *)(a + i) << shift; ^ Fixes: db43267 "tcg: Add generic vector expanders" Signed-off-by: Laurent Vivier <lvivier@redhat.com> --- configure | 8 ++++++++ 1 file changed, 8 insertions(+)