Message ID | cover.1519227112.git.khalid.aziz@oracle.com (mailing list archive) |
---|---|
Headers | show |
Series | Application Data Integrity feature introduced by SPARC M7 | expand |
From: Khalid Aziz <khalid.aziz@oracle.com> Date: Wed, 21 Feb 2018 10:15:42 -0700 > V12 changes: > This series is same as v10 and v11 and was simply rebased on 4.16-rc2 > kernel and patch 11 was added to update signal delivery code to use the > new helper functions added by Eric Biederman. Can mm maintainers please > review patches 2, 7, 8 and 9 which are arch independent, and > include/linux/mm.h and mm/ksm.c changes in patch 10 and ack these if > everything looks good? Khalid I've applied this series to sparc-next, thank you! But one thing has to be fixed up. In uapi/asm/auxvec.h you conditionalize the ADI aux vectors on CONFIG_SPARC64. That's not correct, you should never control user facing definitions based upon kernel configuration. Also, both 32-bit and 64-bit applications running on ADI capable machines want to compile against and use this informaiton. So please remove these CPP checks.
On 03/18/2018 09:08 AM, David Miller wrote: > In uapi/asm/auxvec.h you conditionalize the ADI aux vectors on > CONFIG_SPARC64. > > That's not correct, you should never control user facing definitions > based upon kernel configuration. > > Also, both 32-bit and 64-bit applications running on ADI capable > machines want to compile against and use this informaiton. > > So please remove these CPP checks. > Hi Dave, That makes sense. I will send a patch to remove these. Thanks, Khalid