mbox series

[0/5] DPAA Ethernet fixes

Message ID 20180314133732.24068-1-madalin.bucur@nxp.com (mailing list archive)
Headers show
Series DPAA Ethernet fixes | expand

Message

Madalin Bucur March 14, 2018, 1:37 p.m. UTC
Hi,

This patch set is addressing several issues in the DPAA Ethernet
driver suite:

 - module unload crash caused by wrong reference to device being left
   in the cleanup code after the DSA related changes
 - scheduling wile atomic bug in QMan code revealed during dpaa_eth
   module unload
 - a couple of error counter fixes, a duplicated init in dpaa_eth.

Madalin

Camelia Groza (3):
  dpaa_eth: remove duplicate initialization
  dpaa_eth: increment the RX dropped counter when needed
  dpaa_eth: remove duplicate increment of the tx_errors counter

Madalin Bucur (2):
  soc/fsl/qbman: fix issue in qman_delete_cgr_safe()
  dpaa_eth: fix error in dpaa_remove()

 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c |  8 ++++----
 drivers/soc/fsl/qbman/qman.c                   | 28 +++++---------------------
 2 files changed, 9 insertions(+), 27 deletions(-)

Comments

David Miller March 14, 2018, 5:17 p.m. UTC | #1
From: Madalin Bucur <madalin.bucur@nxp.com>
Date: Wed, 14 Mar 2018 08:37:27 -0500

> This patch set is addressing several issues in the DPAA Ethernet
> driver suite:
> 
>  - module unload crash caused by wrong reference to device being left
>    in the cleanup code after the DSA related changes
>  - scheduling wile atomic bug in QMan code revealed during dpaa_eth
>    module unload
>  - a couple of error counter fixes, a duplicated init in dpaa_eth.

Series applied, thank you.
Joakim Tjernlund March 14, 2018, 6:43 p.m. UTC | #2
On Wed, 2018-03-14 at 08:37 -0500, Madalin Bucur wrote:
> Hi,

> 

> This patch set is addressing several issues in the DPAA Ethernet

> driver suite:

> 

>  - module unload crash caused by wrong reference to device being left

>    in the cleanup code after the DSA related changes

>  - scheduling wile atomic bug in QMan code revealed during dpaa_eth

>    module unload

>  - a couple of error counter fixes, a duplicated init in dpaa_eth.


hmm, some of these(all?) bugs are in stable too, CC: stable perhaps? 

> 

> Madalin

> 

> Camelia Groza (3):

>   dpaa_eth: remove duplicate initialization

>   dpaa_eth: increment the RX dropped counter when needed

>   dpaa_eth: remove duplicate increment of the tx_errors counter

> 

> Madalin Bucur (2):

>   soc/fsl/qbman: fix issue in qman_delete_cgr_safe()

>   dpaa_eth: fix error in dpaa_remove()

> 

>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c |  8 ++++----

>  drivers/soc/fsl/qbman/qman.c                   | 28 +++++---------------------

>  2 files changed, 9 insertions(+), 27 deletions(-)

> 

> --

> 2.1.0

>
Madalin Bucur March 15, 2018, 9:32 a.m. UTC | #3
> -----Original Message-----

> From: Joakim Tjernlund [mailto:Joakim.Tjernlund@infinera.com]

> Sent: Wednesday, March 14, 2018 8:43 PM

> To: davem@davemloft.net; Madalin-cristian Bucur

> <madalin.bucur@nxp.com>

> 

> On Wed, 2018-03-14 at 08:37 -0500, Madalin Bucur wrote:

> > Hi,

> >

> > This patch set is addressing several issues in the DPAA Ethernet

> > driver suite:

> >

> >  - module unload crash caused by wrong reference to device being left

> >    in the cleanup code after the DSA related changes

> >  - scheduling wile atomic bug in QMan code revealed during dpaa_eth

> >    module unload

> >  - a couple of error counter fixes, a duplicated init in dpaa_eth.

> 

> hmm, some of these(all?) bugs are in stable too, CC: stable perhaps?


Hi Jocke,

I did not check that, they should be added.

Thanks,
Madalin

> >

> > Madalin

> >

> > Camelia Groza (3):

> >   dpaa_eth: remove duplicate initialization

> >   dpaa_eth: increment the RX dropped counter when needed

> >   dpaa_eth: remove duplicate increment of the tx_errors counter

> >

> > Madalin Bucur (2):

> >   soc/fsl/qbman: fix issue in qman_delete_cgr_safe()

> >   dpaa_eth: fix error in dpaa_remove()

> >

> >  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c |  8 ++++----

> >  drivers/soc/fsl/qbman/qman.c                   | 28 +++++---------------------

> >  2 files changed, 9 insertions(+), 27 deletions(-)

> >

> > --

> > 2.1.0

> >
David Miller March 15, 2018, 3:15 p.m. UTC | #4
From: Madalin-cristian Bucur <madalin.bucur@nxp.com>
Date: Thu, 15 Mar 2018 09:32:35 +0000

>> -----Original Message-----
>> From: Joakim Tjernlund [mailto:Joakim.Tjernlund@infinera.com]
>> Sent: Wednesday, March 14, 2018 8:43 PM
>> To: davem@davemloft.net; Madalin-cristian Bucur
>> <madalin.bucur@nxp.com>
>> 
>> On Wed, 2018-03-14 at 08:37 -0500, Madalin Bucur wrote:
>> > Hi,
>> >
>> > This patch set is addressing several issues in the DPAA Ethernet
>> > driver suite:
>> >
>> >  - module unload crash caused by wrong reference to device being left
>> >    in the cleanup code after the DSA related changes
>> >  - scheduling wile atomic bug in QMan code revealed during dpaa_eth
>> >    module unload
>> >  - a couple of error counter fixes, a duplicated init in dpaa_eth.
>> 
>> hmm, some of these(all?) bugs are in stable too, CC: stable perhaps?
> 
> Hi Jocke,
> 
> I did not check that, they should be added.

Networking patches are not queued to stable by CC:'ing stable.

Instead you just simply need to ask me explicitly for -stable submission
which I will do at the appropriate time after the fixes have been able
to cook in Linus's tree for a little while.

I've queued this series up for that purpose, thanks.