| Message ID | 52c15c0414d248981e251386384ed2a716315003.1520294174.git.sam.bobroff@au1.ibm.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | EEH refactoring 1 | expand |
On Tue, 2018-03-06 at 10:59 +1100, Sam Bobroff wrote: > Remove a test that checks if "frozen_bus" is NULL, because it cannot > have changed since it was tested at the start of the function and so > must be true here. It could potentially be modified since it gets passed into eeh_reset_device() but it doesn't look like it does anywhere. > > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> Reviewed-by: Russell Currey <ruscur@russell.cc>
Sam Bobroff <sam.bobroff@au1.ibm.com> writes: > Remove a test that checks if "frozen_bus" is NULL, because it cannot > have changed since it was tested at the start of the function and so > must be true here. As far as I can tell this was added back in 2012 in 9b3c76f08122f. As far as I can tell it couldn't be NULL back then either. Weird. LGTM, but I'm not super comfortable chnging something I don't understand so I will leave the formal review for now. Regards, Daniel > > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> > --- > arch/powerpc/kernel/eeh_driver.c | 24 +++++++++++------------- > 1 file changed, 11 insertions(+), 13 deletions(-) > > diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c > index 5b7a5ed4db4d..04a5d9db5499 100644 > --- a/arch/powerpc/kernel/eeh_driver.c > +++ b/arch/powerpc/kernel/eeh_driver.c > @@ -930,20 +930,18 @@ void eeh_handle_normal_event(struct eeh_pe *pe) > * all removed devices correctly to avoid access > * the their PCI config any more. > */ > - if (frozen_bus) { > - if (pe->type & EEH_PE_VF) { > - eeh_pe_dev_traverse(pe, eeh_rmv_device, NULL); > - eeh_pe_dev_mode_mark(pe, EEH_DEV_REMOVED); > - } else { > - eeh_pe_state_clear(pe, EEH_PE_PRI_BUS); > - eeh_pe_dev_mode_mark(pe, EEH_DEV_REMOVED); > + if (pe->type & EEH_PE_VF) { > + eeh_pe_dev_traverse(pe, eeh_rmv_device, NULL); > + eeh_pe_dev_mode_mark(pe, EEH_DEV_REMOVED); > + } else { > + eeh_pe_state_clear(pe, EEH_PE_PRI_BUS); > + eeh_pe_dev_mode_mark(pe, EEH_DEV_REMOVED); > > - pci_lock_rescan_remove(); > - pci_hp_remove_devices(frozen_bus); > - pci_unlock_rescan_remove(); > - /* The passed PE should no longer be used */ > - return; > - } > + pci_lock_rescan_remove(); > + pci_hp_remove_devices(frozen_bus); > + pci_unlock_rescan_remove(); > + /* The passed PE should no longer be used */ > + return; > } > final: > eeh_pe_state_clear(pe, EEH_PE_RECOVERING); > -- > 2.16.1.74.g9b0b1f47b
diff --git a/arch/powerpc/kernel/eeh_driver.c b/arch/powerpc/kernel/eeh_driver.c index 5b7a5ed4db4d..04a5d9db5499 100644 --- a/arch/powerpc/kernel/eeh_driver.c +++ b/arch/powerpc/kernel/eeh_driver.c @@ -930,20 +930,18 @@ void eeh_handle_normal_event(struct eeh_pe *pe) * all removed devices correctly to avoid access * the their PCI config any more. */ - if (frozen_bus) { - if (pe->type & EEH_PE_VF) { - eeh_pe_dev_traverse(pe, eeh_rmv_device, NULL); - eeh_pe_dev_mode_mark(pe, EEH_DEV_REMOVED); - } else { - eeh_pe_state_clear(pe, EEH_PE_PRI_BUS); - eeh_pe_dev_mode_mark(pe, EEH_DEV_REMOVED); + if (pe->type & EEH_PE_VF) { + eeh_pe_dev_traverse(pe, eeh_rmv_device, NULL); + eeh_pe_dev_mode_mark(pe, EEH_DEV_REMOVED); + } else { + eeh_pe_state_clear(pe, EEH_PE_PRI_BUS); + eeh_pe_dev_mode_mark(pe, EEH_DEV_REMOVED); - pci_lock_rescan_remove(); - pci_hp_remove_devices(frozen_bus); - pci_unlock_rescan_remove(); - /* The passed PE should no longer be used */ - return; - } + pci_lock_rescan_remove(); + pci_hp_remove_devices(frozen_bus); + pci_unlock_rescan_remove(); + /* The passed PE should no longer be used */ + return; } final: eeh_pe_state_clear(pe, EEH_PE_RECOVERING);
Remove a test that checks if "frozen_bus" is NULL, because it cannot have changed since it was tested at the start of the function and so must be true here. Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com> --- arch/powerpc/kernel/eeh_driver.c | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-)