diff mbox series

[v2,1/4] ipc: Make char buf pomiter parameter of ipc_inst_start_ext function const

Message ID 1518813722-4297-1-git-send-email-stefan@herbrechtsmeier.net
State Accepted
Headers show
Series [v2,1/4] ipc: Make char buf pomiter parameter of ipc_inst_start_ext function const | expand

Commit Message

Stefan Herbrechtsmeier Feb. 16, 2018, 8:41 p.m. UTC
From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>

Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
---

Changes in v2: None

 include/network_ipc.h | 2 +-
 ipc/network_ipc.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Stefano Babic Feb. 18, 2018, 10:44 a.m. UTC | #1
On 16/02/2018 21:41, stefan@herbrechtsmeier.net wrote:
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> 
> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> ---
> 

Pomiter ?

> Changes in v2: None
> 
>  include/network_ipc.h | 2 +-
>  ipc/network_ipc.c     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/network_ipc.h b/include/network_ipc.h
> index 1c7e947..fd90b1e 100644
> --- a/include/network_ipc.h
> +++ b/include/network_ipc.h
> @@ -60,7 +60,7 @@ typedef struct {
>  } ipc_message;
>  
>  int ipc_inst_start(void);
> -int ipc_inst_start_ext(sourcetype source, size_t len, char *info);
> +int ipc_inst_start_ext(sourcetype source, size_t len, const char *info);
>  int ipc_send_data(int connfd, char *buf, int size);
>  void ipc_end(int connfd);
>  int ipc_get_status(ipc_message *msg);
> diff --git a/ipc/network_ipc.c b/ipc/network_ipc.c
> index 48f6fcc..4543092 100644
> --- a/ipc/network_ipc.c
> +++ b/ipc/network_ipc.c
> @@ -143,7 +143,7 @@ int ipc_get_status(ipc_message *msg)
>  	return ret;
>  }
>  
> -int ipc_inst_start_ext(sourcetype source, size_t len, char *buf)
> +int ipc_inst_start_ext(sourcetype source, size_t len, const char *buf)
>  {
>  	int connfd;
>  	ipc_message msg;
> 

Applied after s/pomiter/pointer/, thanks !

Best regards,
Stefano Babic
Herbrechtsmeier Dr.-Ing. , Stefan Feb. 19, 2018, 7:40 a.m. UTC | #2
Hi Stefano,

> Von: Stefano Babic [mailto:sbabic@denx.de]
> Gesendet: Sonntag, 18. Februar 2018 11:44
> An: stefan@herbrechtsmeier.net; swupdate@googlegroups.com
> Cc: Herbrechtsmeier Dr.-Ing. , Stefan
> <Stefan.Herbrechtsmeier@weidmueller.com>
> Betreff: Re: [swupdate] [PATCH v2 1/4] ipc: Make char buf pomiter
> parameter of ipc_inst_start_ext function const
>
> On 16/02/2018 21:41, stefan@herbrechtsmeier.net wrote:
> > From: Stefan Herbrechtsmeier
> <stefan.herbrechtsmeier@weidmueller.com>
> >
> > Signed-off-by: Stefan Herbrechtsmeier
> > <stefan.herbrechtsmeier@weidmueller.com>
> > ---
> >
>
> Pomiter ?

Sorry, I notice the typo after the commit.

> > Changes in v2: None
> >
> >  include/network_ipc.h | 2 +-
> >  ipc/network_ipc.c     | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/network_ipc.h b/include/network_ipc.h index
> > 1c7e947..fd90b1e 100644
> > --- a/include/network_ipc.h
> > +++ b/include/network_ipc.h
> > @@ -60,7 +60,7 @@ typedef struct {
> >  } ipc_message;
> >
> >  int ipc_inst_start(void);
> > -int ipc_inst_start_ext(sourcetype source, size_t len, char *info);
> > +int ipc_inst_start_ext(sourcetype source, size_t len, const char
> > +*info);
> >  int ipc_send_data(int connfd, char *buf, int size);  void ipc_end(int
> > connfd);  int ipc_get_status(ipc_message *msg); diff --git
> > a/ipc/network_ipc.c b/ipc/network_ipc.c index 48f6fcc..4543092 100644
> > --- a/ipc/network_ipc.c
> > +++ b/ipc/network_ipc.c
> > @@ -143,7 +143,7 @@ int ipc_get_status(ipc_message *msg)
> >     return ret;
> >  }
> >
> > -int ipc_inst_start_ext(sourcetype source, size_t len, char *buf)
> > +int ipc_inst_start_ext(sourcetype source, size_t len, const char
> > +*buf)
> >  {
> >     int connfd;
> >     ipc_message msg;
> >
>
> Applied after s/pomiter/pointer/, thanks !

Thank you for the direct fixup.

Best regards

Stefan Herbrechtsmeier
Software Developer Embedded Systems

Weidmüller – Your partner in Industrial Connectivity
We look forward to sharing ideas with you – Let’s connect.

Weidmueller Interface GmbH & Co. KG
Klingenbergstraße 16, 32758 Detmold, Germany
Phone: +49 5231 14-293195 – Fax: +49 5231 14-253195
Email: Stefan.Herbrechtsmeier@weidmueller.com – Web: www.weidmueller.com
diff mbox series

Patch

diff --git a/include/network_ipc.h b/include/network_ipc.h
index 1c7e947..fd90b1e 100644
--- a/include/network_ipc.h
+++ b/include/network_ipc.h
@@ -60,7 +60,7 @@  typedef struct {
 } ipc_message;
 
 int ipc_inst_start(void);
-int ipc_inst_start_ext(sourcetype source, size_t len, char *info);
+int ipc_inst_start_ext(sourcetype source, size_t len, const char *info);
 int ipc_send_data(int connfd, char *buf, int size);
 void ipc_end(int connfd);
 int ipc_get_status(ipc_message *msg);
diff --git a/ipc/network_ipc.c b/ipc/network_ipc.c
index 48f6fcc..4543092 100644
--- a/ipc/network_ipc.c
+++ b/ipc/network_ipc.c
@@ -143,7 +143,7 @@  int ipc_get_status(ipc_message *msg)
 	return ret;
 }
 
-int ipc_inst_start_ext(sourcetype source, size_t len, char *buf)
+int ipc_inst_start_ext(sourcetype source, size_t len, const char *buf)
 {
 	int connfd;
 	ipc_message msg;