Message ID | ef4e172df6cdf3d9ee8bb3aa896cacab5efdd1f1.1508279421.git.alistair.francis@xilinx.com |
---|---|
State | New |
Headers | show |
Series | Add a valid_cpu_types property | expand |
On Tue, Oct 17, 2017 at 7:31 PM, Alistair Francis <alistair.francis@xilinx.com> wrote: > The BCM2836 uses a Cortex-A7 not a Cortex-A15. Update the device to use > the correct CPU. > https://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf > > Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > V3: > - Use ARM_CPU_TYPE_NAME() macro > V2: > - Fix the BCM2836 CPU > > hw/arm/bcm2836.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c > index 8c43291112..c477772484 100644 > --- a/hw/arm/bcm2836.c > +++ b/hw/arm/bcm2836.c > @@ -30,7 +30,7 @@ static void bcm2836_init(Object *obj) > > for (n = 0; n < BCM2836_NCPUS; n++) { > object_initialize(&s->cpus[n], sizeof(s->cpus[n]), > - "cortex-a15-" TYPE_ARM_CPU); > + ARM_CPU_TYPE_NAME("cortex-a7")); > object_property_add_child(obj, "cpu[*]", OBJECT(&s->cpus[n]), > &error_abort); > } > -- > 2.11.0 > >
On Tue, 17 Oct 2017 15:31:14 -0700 Alistair Francis <alistair.francis@xilinx.com> wrote: > The BCM2836 uses a Cortex-A7 not a Cortex-A15. Update the device to use > the correct CPU. > https://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf > > Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > V3: > - Use ARM_CPU_TYPE_NAME() macro > V2: > - Fix the BCM2836 CPU > > hw/arm/bcm2836.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c > index 8c43291112..c477772484 100644 > --- a/hw/arm/bcm2836.c > +++ b/hw/arm/bcm2836.c > @@ -30,7 +30,7 @@ static void bcm2836_init(Object *obj) > > for (n = 0; n < BCM2836_NCPUS; n++) { > object_initialize(&s->cpus[n], sizeof(s->cpus[n]), > - "cortex-a15-" TYPE_ARM_CPU); > + ARM_CPU_TYPE_NAME("cortex-a7")); > object_property_add_child(obj, "cpu[*]", OBJECT(&s->cpus[n]), > &error_abort); > }
diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c index 8c43291112..c477772484 100644 --- a/hw/arm/bcm2836.c +++ b/hw/arm/bcm2836.c @@ -30,7 +30,7 @@ static void bcm2836_init(Object *obj) for (n = 0; n < BCM2836_NCPUS; n++) { object_initialize(&s->cpus[n], sizeof(s->cpus[n]), - "cortex-a15-" TYPE_ARM_CPU); + ARM_CPU_TYPE_NAME("cortex-a7")); object_property_add_child(obj, "cpu[*]", OBJECT(&s->cpus[n]), &error_abort); }
The BCM2836 uses a Cortex-A7 not a Cortex-A15. Update the device to use the correct CPU. https://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> --- V3: - Use ARM_CPU_TYPE_NAME() macro V2: - Fix the BCM2836 CPU hw/arm/bcm2836.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)