Message ID | 20170913132417.24384-1-david@redhat.com |
---|---|
Headers | show |
Series | s390x cleanups and CPU hotplug via device_add | expand |
On Wed, 13 Sep 2017 15:23:55 +0200 David Hildenbrand <david@redhat.com> wrote: > The first patches are a bunch of cleanups. I decided to go the > extra mile and implement CPU hotplug via "device_add", as well as > "query-hotpluggable-cpus". > > On s390x, only complete cores can be plugged. CPU hot unplug is currently > not supported by the architecture. > > Support for hotplugging CPUs in random core-id order (last two patches) > is added. We once hat a KVM bug preventing this, but the stable patch > should now be included in relevant places - 152e9f65d66f ("KVM: s390: fix > wrong lookup of VCPUs by array index"). Current tooling will plug them in > sequential order anyway, so it should not hurt. Thanks, applied.
On Mon, 02 Oct 2017 09:47:58 +0200 Markus Armbruster <armbru@redhat.com> wrote: > Cornelia Huck <cohuck@redhat.com> writes: > > > On Wed, 13 Sep 2017 15:23:55 +0200 > > David Hildenbrand <david@redhat.com> wrote: > > > >> The first patches are a bunch of cleanups. I decided to go the > >> extra mile and implement CPU hotplug via "device_add", as well as > >> "query-hotpluggable-cpus". > >> > >> On s390x, only complete cores can be plugged. CPU hot unplug is currently > >> not supported by the architecture. > >> > >> Support for hotplugging CPUs in random core-id order (last two patches) > >> is added. We once hat a KVM bug preventing this, but the stable patch > >> should now be included in relevant places - 152e9f65d66f ("KVM: s390: fix > >> wrong lookup of VCPUs by array index"). Current tooling will plug them in > >> sequential order anyway, so it should not hurt. > > > > Thanks, applied. > > Please squash in the one-liner fix I asked for in my (late!) review of > PATCH 18. Sadly, the review was a bit too late (already merged)...
On 13.09.2017 15:23, David Hildenbrand wrote: > The first patches are a bunch of cleanups. I decided to go the > extra mile and implement CPU hotplug via "device_add", as well as > "query-hotpluggable-cpus". > > On s390x, only complete cores can be plugged. CPU hot unplug is currently > not supported by the architecture. > > Support for hotplugging CPUs in random core-id order (last two patches) > is added. We once hat a KVM bug preventing this, but the stable patch > should now be included in relevant places - 152e9f65d66f ("KVM: s390: fix > wrong lookup of VCPUs by array index"). Current tooling will plug them in > sequential order anyway, so it should not hurt. > Just played with libvirt. It seems to automatically use the new interface. Works great for me (including migration).