Message ID | 20170926183318.12995-1-david@redhat.com |
---|---|
Headers | show |
Series | s390x/tcg: fix some accesses using low address | expand |
On 09/26/2017 11:33 AM, David Hildenbrand wrote: > David Hildenbrand (6): > s390x/tcg: fix checking for invalid memory check > s390x/tcg: add MMU for real addresses > s390x/tcg: make lura(g) use the new _real mmu. > s390x/tcg: make stora(g) use the new _real mmu > s390x/tcg: make testblock use the new _real mmu > s390x/tcg: make idte/ipte use the new _real mmu Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Watch out for a couple of blank lines left over while deleting stuff. E.g. { code } r~
On 27.09.2017 01:10, Richard Henderson wrote: > On 09/26/2017 11:33 AM, David Hildenbrand wrote: >> David Hildenbrand (6): >> s390x/tcg: fix checking for invalid memory check >> s390x/tcg: add MMU for real addresses >> s390x/tcg: make lura(g) use the new _real mmu. >> s390x/tcg: make stora(g) use the new _real mmu >> s390x/tcg: make testblock use the new _real mmu >> s390x/tcg: make idte/ipte use the new _real mmu > > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > > Watch out for a couple of blank lines left over while deleting stuff. Yes, the HELPER(lura) hunk in the third patch has a superfluous empty line now. Apart from that, the series also looks good to me: Reviewed-by: Thomas Huth <thuth@redhat.com>
On Tue, 26 Sep 2017 20:33:12 +0200 David Hildenbrand <david@redhat.com> wrote: > Conny reported that a guest Linux currently spits out: > "The s390-virtio transport is deprecated. Please switch to a modern host > providing virtio-ccw." > > This is strange, because we have no legacy virtio transport in QEMU :) > > Main problem is, that a page is tested for acccess, and the test does not > fail. All memory access variants like stb_phys() will never fail. On > invalid memory, they simply do nothing. > > Linux uses lura for this check. Let's introduce a _real MMU that handles > prefixing and can later be used for things like low address protection. > > The other BUG is that a check for invalid memory is wrong. Therefore, > Patch 1 alone makes the guest crash when trying to initialize the > virtio transport. Crazy stuff. Indeed, thanks for hunting this down! No strange messages for me any more :) Fixed up the empty line in lura and applied to s390-next.