| Message ID | 20170911142056.15643-4-lvivier@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | hmp: fix "dump-quest-memory" segfault | expand |
On 11.09.2017 16:20, Laurent Vivier wrote: > and add a test case of dump-guest-memory without > "[begin length]" parameters. > > Signed-off-by: Laurent Vivier <lvivier@redhat.com> > --- > tests/test-hmp.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/test-hmp.c b/tests/test-hmp.c > index 729c0339f7..90693c0ce2 100644 > --- a/tests/test-hmp.c > +++ b/tests/test-hmp.c > @@ -35,6 +35,7 @@ static const char *hmp_cmds[] = { > "mouse_button 0", > "device_del mouse1", > "dump-guest-memory /dev/null 0 4096", > + "dump-guest-memory /dev/null", > "gdbserver", > "host_net_add user id=net0", > "hostfwd_add tcp::43210-:43210", > @@ -159,5 +160,9 @@ int main(int argc, char **argv) > > qtest_cb_for_every_machine(add_machine_test_case); > > + /* as none machine has no memory, add a test case with memory */ > + Maybe remove the empty line after the comment? > + qtest_add_data_func("hmp/none+2MB", g_strdup("none -m 2"), test_machine); > + > return g_test_run(); > } > Reviewed-by: Thomas Huth <thuth@redhat.com>
On 11/09/2017 16:51, Thomas Huth wrote: > On 11.09.2017 16:20, Laurent Vivier wrote: >> and add a test case of dump-guest-memory without >> "[begin length]" parameters. >> >> Signed-off-by: Laurent Vivier <lvivier@redhat.com> >> --- >> tests/test-hmp.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/tests/test-hmp.c b/tests/test-hmp.c >> index 729c0339f7..90693c0ce2 100644 >> --- a/tests/test-hmp.c >> +++ b/tests/test-hmp.c >> @@ -35,6 +35,7 @@ static const char *hmp_cmds[] = { >> "mouse_button 0", >> "device_del mouse1", >> "dump-guest-memory /dev/null 0 4096", >> + "dump-guest-memory /dev/null", >> "gdbserver", >> "host_net_add user id=net0", >> "hostfwd_add tcp::43210-:43210", >> @@ -159,5 +160,9 @@ int main(int argc, char **argv) >> >> qtest_cb_for_every_machine(add_machine_test_case); >> >> + /* as none machine has no memory, add a test case with memory */ >> + > > Maybe remove the empty line after the comment? Bad habit. If I respin the series, I'll update this, otherwise I would appreciate the committer does. >> + qtest_add_data_func("hmp/none+2MB", g_strdup("none -m 2"), test_machine); >> + >> return g_test_run(); >> } >> > > Reviewed-by: Thomas Huth <thuth@redhat.com> > Thanks, Laurent
On 09/11/2017 11:20 AM, Laurent Vivier wrote: > and add a test case of dump-guest-memory without > "[begin length]" parameters. > > Signed-off-by: Laurent Vivier <lvivier@redhat.com> > --- > tests/test-hmp.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/test-hmp.c b/tests/test-hmp.c > index 729c0339f7..90693c0ce2 100644 > --- a/tests/test-hmp.c > +++ b/tests/test-hmp.c > @@ -35,6 +35,7 @@ static const char *hmp_cmds[] = { > "mouse_button 0", > "device_del mouse1", > "dump-guest-memory /dev/null 0 4096", > + "dump-guest-memory /dev/null", > "gdbserver", > "host_net_add user id=net0", > "hostfwd_add tcp::43210-:43210", > @@ -159,5 +160,9 @@ int main(int argc, char **argv) > > qtest_cb_for_every_machine(add_machine_test_case); > > + /* as none machine has no memory, add a test case with memory */ > + > + qtest_add_data_func("hmp/none+2MB", g_strdup("none -m 2"), test_machine); TIL: "-m 0", "none" machine is implemented in "null-machine.c", "none" machine default maps memory at 0x0. > + > return g_test_run(); > } >
diff --git a/tests/test-hmp.c b/tests/test-hmp.c index 729c0339f7..90693c0ce2 100644 --- a/tests/test-hmp.c +++ b/tests/test-hmp.c @@ -35,6 +35,7 @@ static const char *hmp_cmds[] = { "mouse_button 0", "device_del mouse1", "dump-guest-memory /dev/null 0 4096", + "dump-guest-memory /dev/null", "gdbserver", "host_net_add user id=net0", "hostfwd_add tcp::43210-:43210", @@ -159,5 +160,9 @@ int main(int argc, char **argv) qtest_cb_for_every_machine(add_machine_test_case); + /* as none machine has no memory, add a test case with memory */ + + qtest_add_data_func("hmp/none+2MB", g_strdup("none -m 2"), test_machine); + return g_test_run(); }
and add a test case of dump-guest-memory without "[begin length]" parameters. Signed-off-by: Laurent Vivier <lvivier@redhat.com> --- tests/test-hmp.c | 5 +++++ 1 file changed, 5 insertions(+)