mbox series

[v2,0/5] Expose the secure and virt properties to the

Message ID cover.1504222314.git.alistair.francis@xilinx.com
Headers show
Series Expose the secure and virt properties to the | expand

Message

Alistair Francis Aug. 31, 2017, 11:34 p.m. UTC
The EL2 and EL3 work is working well now and interanlly we now have
tests that expect to start in EL3 and transition through EL2 to EL1. To
make this easy to run let's expose the secure property to the machine
and also add a virt property that can enable EL2.

This series also does some machine/name tidying up and makes the first
move to deprecating the EP108 machine, which was just an early access
development board.

V2:
 - Add a virt option for setting EL2



Alistair Francis (5):
  xlnx-ep108: Rename to ZCU102
  xlnx-zcu102: Manually create the machines
  xlnx-zcu102: Add a machine level secure property
  xlnx-zcu102: Add a machine level virtualization property
  xlnx-zcu102: Mark the EP108 machine as deprecated

 hw/arm/Makefile.objs         |   2 +-
 hw/arm/xlnx-ep108.c          | 137 -----------------------
 hw/arm/xlnx-zcu102.c         | 257 +++++++++++++++++++++++++++++++++++++++++++
 hw/arm/xlnx-zynqmp.c         |   3 +-
 include/hw/arm/xlnx-zynqmp.h |   2 +
 5 files changed, 262 insertions(+), 139 deletions(-)
 delete mode 100644 hw/arm/xlnx-ep108.c
 create mode 100644 hw/arm/xlnx-zcu102.c

Comments

Peter Maydell Sept. 7, 2017, 12:51 p.m. UTC | #1
On 1 September 2017 at 00:34, Alistair Francis
<alistair.francis@xilinx.com> wrote:
>
> The EL2 and EL3 work is working well now and interanlly we now have
> tests that expect to start in EL3 and transition through EL2 to EL1. To
> make this easy to run let's expose the secure property to the machine
> and also add a virt property that can enable EL2.
>
> This series also does some machine/name tidying up and makes the first
> move to deprecating the EP108 machine, which was just an early access
> development board.
>
> V2:
>  - Add a virt option for setting EL2

It looks like only patches 4 5 and the cover letter got through the
mailing list server, so patches and patchwork don't have the whole
thing. Could I ask you to try a resend?

thanks
-- PMM
Alistair Francis Sept. 7, 2017, 4:01 p.m. UTC | #2
On Thu, Sep 7, 2017 at 5:51 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 1 September 2017 at 00:34, Alistair Francis
> <alistair.francis@xilinx.com> wrote:
>>
>> The EL2 and EL3 work is working well now and interanlly we now have
>> tests that expect to start in EL3 and transition through EL2 to EL1. To
>> make this easy to run let's expose the secure property to the machine
>> and also add a virt property that can enable EL2.
>>
>> This series also does some machine/name tidying up and makes the first
>> move to deprecating the EP108 machine, which was just an early access
>> development board.
>>
>> V2:
>>  - Add a virt option for setting EL2
>
> It looks like only patches 4 5 and the cover letter got through the
> mailing list server, so patches and patchwork don't have the whole
> thing. Could I ask you to try a resend?

Just re-sent now. Hopefully it works this time.

Thanks,
Alistair

>
> thanks
> -- PMM
Alistair Francis Sept. 7, 2017, 4:29 p.m. UTC | #3
On Thu, Sep 7, 2017 at 9:01 AM, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> On Thu, Sep 7, 2017 at 5:51 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 1 September 2017 at 00:34, Alistair Francis
>> <alistair.francis@xilinx.com> wrote:
>>>
>>> The EL2 and EL3 work is working well now and interanlly we now have
>>> tests that expect to start in EL3 and transition through EL2 to EL1. To
>>> make this easy to run let's expose the secure property to the machine
>>> and also add a virt property that can enable EL2.
>>>
>>> This series also does some machine/name tidying up and makes the first
>>> move to deprecating the EP108 machine, which was just an early access
>>> development board.
>>>
>>> V2:
>>>  - Add a virt option for setting EL2
>>
>> It looks like only patches 4 5 and the cover letter got through the
>> mailing list server, so patches and patchwork don't have the whole
>> thing. Could I ask you to try a resend?
>
> Just re-sent now. Hopefully it works this time.

It looks like patch 1 and 3 still didn't make it through. I see them
leaving the corporate network and going through to my personal email.

Can anyone see anything on the QEMU mail server side? Any logs might
help me push IT to investigate.

Thanks,
Alistair

>
> Thanks,
> Alistair
>
>>
>> thanks
>> -- PMM
Peter Maydell Sept. 7, 2017, 4:33 p.m. UTC | #4
On 7 September 2017 at 17:29, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> It looks like patch 1 and 3 still didn't make it through. I see them
> leaving the corporate network and going through to my personal email.
>
> Can anyone see anything on the QEMU mail server side? Any logs might
> help me push IT to investigate.

Unfortunately we don't really have much visibility into what
the mail server is doing, because it's run by nongnu.org.
It does seem to have a habit of occasionally eating patches
(maybe it thinks they're spam or something).

thanks
-- PMM
Alistair Francis Sept. 7, 2017, 4:48 p.m. UTC | #5
On Thu, Sep 7, 2017 at 9:33 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 7 September 2017 at 17:29, Alistair Francis
> <alistair.francis@xilinx.com> wrote:
>> It looks like patch 1 and 3 still didn't make it through. I see them
>> leaving the corporate network and going through to my personal email.
>>
>> Can anyone see anything on the QEMU mail server side? Any logs might
>> help me push IT to investigate.
>
> Unfortunately we don't really have much visibility into what
> the mail server is doing, because it's run by nongnu.org.
> It does seem to have a habit of occasionally eating patches
> (maybe it thinks they're spam or something).

Hmmm... I'm not sure how to look into this then, as I can see the
patches going through to my personal email address, so it's hard to
place the blame on the Xilinx mail server.

Do you want me to try sending out patches 1 and 3 again?

Thanks,
Alistair

>
> thanks
> -- PMM
>
Richard Henderson Sept. 7, 2017, 6:06 p.m. UTC | #6
On 09/07/2017 09:48 AM, Alistair Francis wrote:
> Hmmm... I'm not sure how to look into this then, as I can see the
> patches going through to my personal email address, so it's hard to
> place the blame on the Xilinx mail server.
> 
> Do you want me to try sending out patches 1 and 3 again?

I had this problem with one of my patch sets earlier this year.
In the end it seemed easier to post a link to a public git tree.


r~
Peter Maydell Sept. 7, 2017, 6:08 p.m. UTC | #7
On 7 September 2017 at 19:06, Richard Henderson
<richard.henderson@linaro.org> wrote:
> On 09/07/2017 09:48 AM, Alistair Francis wrote:
>> Hmmm... I'm not sure how to look into this then, as I can see the
>> patches going through to my personal email address, so it's hard to
>> place the blame on the Xilinx mail server.
>>
>> Do you want me to try sending out patches 1 and 3 again?
>
> I had this problem with one of my patch sets earlier this year.
> In the end it seemed easier to post a link to a public git tree.

Being on the direct cc list I get all the patches anyway, so
it's mostly an issue for (1) review by other people not directly
cc'd and (2) the automated tools (I can apply stuff by hand from
direct email but it's a pain as I have to manually save and
then git am every email in the set).

thanks
-- PMM
Alistair Francis Sept. 7, 2017, 6:13 p.m. UTC | #8
On Thu, Sep 7, 2017 at 11:08 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 7 September 2017 at 19:06, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>> On 09/07/2017 09:48 AM, Alistair Francis wrote:
>>> Hmmm... I'm not sure how to look into this then, as I can see the
>>> patches going through to my personal email address, so it's hard to
>>> place the blame on the Xilinx mail server.
>>>
>>> Do you want me to try sending out patches 1 and 3 again?
>>
>> I had this problem with one of my patch sets earlier this year.
>> In the end it seemed easier to post a link to a public git tree.
>
> Being on the direct cc list I get all the patches anyway, so
> it's mostly an issue for (1) review by other people not directly
> cc'd and (2) the automated tools (I can apply stuff by hand from
> direct email but it's a pain as I have to manually save and
> then git am every email in the set).

The patches can be found here:
https://github.com/Xilinx/qemu/tree/mainline/alistair/secure.next
That'll save you manually downloading them.

That's probably the best I can do for this series as they don't seem
to want to go through.

Thanks,
Alistair

>
> thanks
> -- PMM
>
Edgar E. Iglesias Sept. 7, 2017, 9:35 p.m. UTC | #9
On Thu, Sep 07, 2017 at 08:56:55AM -0700, Alistair Francis wrote:
> 
> The EL2 and EL3 work is working well now and interanlly we now have
> tests that expect to start in EL3 and transition through EL2 to EL1. To
> make this easy to run let's expose the secure property to the machine
> and also add a virt property that can enable EL2.
> 
> This series also does some machine/name tidying up and makes the first
> move to deprecating the EP108 machine, which was just an early access
> development board.
> 
> V2:
>  - Add a virt option for setting EL2


Thanks Alistair!
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>



> 
> 
> 
> Alistair Francis (5):
>   xlnx-ep108: Rename to ZCU102
>   xlnx-zcu102: Manually create the machines
>   xlnx-zcu102: Add a machine level secure property
>   xlnx-zcu102: Add a machine level virtualization property
>   xlnx-zcu102: Mark the EP108 machine as deprecated
> 
>  hw/arm/Makefile.objs         |   2 +-
>  hw/arm/xlnx-ep108.c          | 137 -----------------------
>  hw/arm/xlnx-zcu102.c         | 257 +++++++++++++++++++++++++++++++++++++++++++
>  hw/arm/xlnx-zynqmp.c         |   3 +-
>  include/hw/arm/xlnx-zynqmp.h |   2 +
>  5 files changed, 262 insertions(+), 139 deletions(-)
>  delete mode 100644 hw/arm/xlnx-ep108.c
>  create mode 100644 hw/arm/xlnx-zcu102.c
> 
> -- 
> 2.11.0
>
Alistair Francis Sept. 7, 2017, 9:44 p.m. UTC | #10
On Thu, Sep 7, 2017 at 2:35 PM, Edgar E. Iglesias
<edgar.iglesias@xilinx.com> wrote:
> On Thu, Sep 07, 2017 at 08:56:55AM -0700, Alistair Francis wrote:
>>
>> The EL2 and EL3 work is working well now and interanlly we now have
>> tests that expect to start in EL3 and transition through EL2 to EL1. To
>> make this easy to run let's expose the secure property to the machine
>> and also add a virt property that can enable EL2.
>>
>> This series also does some machine/name tidying up and makes the first
>> move to deprecating the EP108 machine, which was just an early access
>> development board.
>>
>> V2:
>>  - Add a virt option for setting EL2
>
>
> Thanks Alistair!
> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Thanks Edgar.

@Peter I updated the patches on the git branch I pasted earlier to
include Edgar's review.

Thanks,
Alistair

>
>
>
>>
>>
>>
>> Alistair Francis (5):
>>   xlnx-ep108: Rename to ZCU102
>>   xlnx-zcu102: Manually create the machines
>>   xlnx-zcu102: Add a machine level secure property
>>   xlnx-zcu102: Add a machine level virtualization property
>>   xlnx-zcu102: Mark the EP108 machine as deprecated
>>
>>  hw/arm/Makefile.objs         |   2 +-
>>  hw/arm/xlnx-ep108.c          | 137 -----------------------
>>  hw/arm/xlnx-zcu102.c         | 257 +++++++++++++++++++++++++++++++++++++++++++
>>  hw/arm/xlnx-zynqmp.c         |   3 +-
>>  include/hw/arm/xlnx-zynqmp.h |   2 +
>>  5 files changed, 262 insertions(+), 139 deletions(-)
>>  delete mode 100644 hw/arm/xlnx-ep108.c
>>  create mode 100644 hw/arm/xlnx-zcu102.c
>>
>> --
>> 2.11.0
>>
Peter Maydell Sept. 14, 2017, 12:30 p.m. UTC | #11
On 7 September 2017 at 22:44, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> On Thu, Sep 7, 2017 at 2:35 PM, Edgar E. Iglesias
> <edgar.iglesias@xilinx.com> wrote:
>> On Thu, Sep 07, 2017 at 08:56:55AM -0700, Alistair Francis wrote:
>>>
>>> The EL2 and EL3 work is working well now and interanlly we now have
>>> tests that expect to start in EL3 and transition through EL2 to EL1. To
>>> make this easy to run let's expose the secure property to the machine
>>> and also add a virt property that can enable EL2.
>>>
>>> This series also does some machine/name tidying up and makes the first
>>> move to deprecating the EP108 machine, which was just an early access
>>> development board.
>>>
>>> V2:
>>>  - Add a virt option for setting EL2
>>
>>
>> Thanks Alistair!
>> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
>
> Thanks Edgar.
>
> @Peter I updated the patches on the git branch I pasted earlier to
> include Edgar's review.

Thanks. I've applied the patches to target-arm.next.

-- PMM