| Message ID | 1504170896-7876-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2] perf test powerpc: Fix 'Object code reading' test | expand |
On 31/08/17 12:14, Ravi Bangoria wrote: > 'Object code reading' test always fails on powerpc guest. Two reasons > for the failure are: > > 1. When elf section is too big (size beyond 'unsigned int' max value). > objdump fails to disassemble from such section. This was fixed with > commit 0f6329bd7fc ("binutils/objdump: Fix disassemble for huge elf > sections") in binutils. > > 2. When the sample is from hypervisor. Hypervisor symbols can not > be resolved within guest and thus thread__find_addr_map() fails for > such symbols. Fix this by ignoring hypervisor symbols in the test. > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > Changes in v2: > - Add pr_debug() > > tools/perf/tests/code-reading.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c > index 761c5a4..466a462 100644 > --- a/tools/perf/tests/code-reading.c > +++ b/tools/perf/tests/code-reading.c > @@ -237,6 +237,11 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode, > > thread__find_addr_map(thread, cpumode, MAP__FUNCTION, addr, &al); > if (!al.map || !al.map->dso) { > + if (cpumode == PERF_RECORD_MISC_HYPERVISOR) { > + pr_debug("Hypervisor address can not be resolved - skipping\n"); > + return 0; > + } > + > pr_debug("thread__find_addr_map failed\n"); > return -1; > } >
Em Thu, Aug 31, 2017 at 12:15:29PM +0300, Adrian Hunter escreveu: > On 31/08/17 12:14, Ravi Bangoria wrote: > > 'Object code reading' test always fails on powerpc guest. Two reasons > > for the failure are: > > > > 1. When elf section is too big (size beyond 'unsigned int' max value). > > objdump fails to disassemble from such section. This was fixed with > > commit 0f6329bd7fc ("binutils/objdump: Fix disassemble for huge elf > > sections") in binutils. > > > > 2. When the sample is from hypervisor. Hypervisor symbols can not > > be resolved within guest and thus thread__find_addr_map() fails for > > such symbols. Fix this by ignoring hypervisor symbols in the test. > > > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> > > Acked-by: Adrian Hunter <adrian.hunter@intel.com> Thanks, applied. - Arnaldo
diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c index 761c5a4..466a462 100644 --- a/tools/perf/tests/code-reading.c +++ b/tools/perf/tests/code-reading.c @@ -237,6 +237,11 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode, thread__find_addr_map(thread, cpumode, MAP__FUNCTION, addr, &al); if (!al.map || !al.map->dso) { + if (cpumode == PERF_RECORD_MISC_HYPERVISOR) { + pr_debug("Hypervisor address can not be resolved - skipping\n"); + return 0; + } + pr_debug("thread__find_addr_map failed\n"); return -1; }
'Object code reading' test always fails on powerpc guest. Two reasons for the failure are: 1. When elf section is too big (size beyond 'unsigned int' max value). objdump fails to disassemble from such section. This was fixed with commit 0f6329bd7fc ("binutils/objdump: Fix disassemble for huge elf sections") in binutils. 2. When the sample is from hypervisor. Hypervisor symbols can not be resolved within guest and thus thread__find_addr_map() fails for such symbols. Fix this by ignoring hypervisor symbols in the test. Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> --- Changes in v2: - Add pr_debug() tools/perf/tests/code-reading.c | 5 +++++ 1 file changed, 5 insertions(+)