Message ID | 1496806444-27910-1-git-send-email-jasowang@redhat.com |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL 0/2] Net patches Message-id: 1496806444-27910-1-git-send-email-jasowang@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' a0be159 Revert "Change net/socket.c to use socket_*() functions" again 0e3dcc6 net/rocker: Cleanup the useless return value check === OUTPUT BEGIN === Checking PATCH 1/2: net/rocker: Cleanup the useless return value check... Checking PATCH 2/2: Revert "Change net/socket.c to use socket_*() functions" again... ERROR: braces {} are necessary for all arms of this statement #58: FILE: net/socket.c:495: + if (parse_host_port(&saddr, host_str) < 0) [...] ERROR: braces {} are necessary for all arms of this statement #161: FILE: net/socket.c:540: + if (parse_host_port(&saddr, host_str) < 0) [...] ERROR: space required before the open parenthesis '(' #174: FILE: net/socket.c:551: + for(;;) { ERROR: braces {} are necessary for all arms of this statement #194: FILE: net/socket.c:571: + if (!s) [...] total: 4 errors, 0 warnings, 162 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
On 2017年06月07日 12:31, no-reply@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PULL 0/2] Net patches > Message-id: 1496806444-27910-1-git-send-email-jasowang@redhat.com > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > a0be159 Revert "Change net/socket.c to use socket_*() functions" again > 0e3dcc6 net/rocker: Cleanup the useless return value check > > === OUTPUT BEGIN === > Checking PATCH 1/2: net/rocker: Cleanup the useless return value check... > Checking PATCH 2/2: Revert "Change net/socket.c to use socket_*() functions" again... > ERROR: braces {} are necessary for all arms of this statement > #58: FILE: net/socket.c:495: > + if (parse_host_port(&saddr, host_str) < 0) > [...] > > ERROR: braces {} are necessary for all arms of this statement > #161: FILE: net/socket.c:540: > + if (parse_host_port(&saddr, host_str) < 0) > [...] > > ERROR: space required before the open parenthesis '(' > #174: FILE: net/socket.c:551: > + for(;;) { > > ERROR: braces {} are necessary for all arms of this statement > #194: FILE: net/socket.c:571: > + if (!s) > [...] > > total: 4 errors, 0 warnings, 162 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-devel@freelists.org This patch is a revert, so looks like it was a false positive. Thanks
On 7 June 2017 at 04:34, Jason Wang <jasowang@redhat.com> wrote: > The following changes since commit 199e19ee538eb61fd08b1c1ee5aa838ebdcc968e: > > Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into staging (2017-06-05 15:28:12 +0100) > > are available in the git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-request > > for you to fetch changes up to 6701e5514beab7b781a10424a94e9850c707287c: > > Revert "Change net/socket.c to use socket_*() functions" again (2017-06-07 10:58:31 +0800) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- > Daniel P. Berrange (1): > Revert "Change net/socket.c to use socket_*() functions" again > > Mao Zhongyi (1): > net/rocker: Cleanup the useless return value check > > hw/net/rocker/rocker.c | 9 ++-- > hw/net/rocker/rocker_desc.c | 4 +- > net/socket.c | 127 +++++++++++++++++++------------------------- > 3 files changed, 60 insertions(+), 80 deletions(-) > Applied, thanks. -- PMM