Message ID | 20170508085016.32601-1-horia.geanta@nxp.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 24e0bfbf63bac18495b0ad76115269f2158e9234 |
Headers | show |
Horia Geantă <horia.geanta@nxp.com> writes: > Makefile.postlink always includes include/config/auto.conf, however > this file is not present in a clean kernel tree, causing make to fail: > > arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory > make[1]: *** No rule to make target `include/config/auto.conf'. Stop. > make: *** [vmlinuxclean] Error 2 > > Change the inclusion such that file not being found does not trigger > an error. > > Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations") I can't reproduce this. What exact steps are you doing? And what version of Make? cheers
On 5/8/2017 2:57 PM, Michael Ellerman wrote: > Horia Geantă <horia.geanta@nxp.com> writes: > >> Makefile.postlink always includes include/config/auto.conf, however >> this file is not present in a clean kernel tree, causing make to fail: >> >> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory >> make[1]: *** No rule to make target `include/config/auto.conf'. Stop. >> make: *** [vmlinuxclean] Error 2 >> >> Change the inclusion such that file not being found does not trigger >> an error. >> >> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations") > > I can't reproduce this. What exact steps are you doing? And what version > of Make? > Start with a clean kernel tree and then make distclean arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory make[1]: *** No rule to make target `include/config/auto.conf'. Stop. make: *** [vmlinuxclean] Error 2 make --version GNU Make 3.82 Built for x86_64-redhat-linux-gnu Copyright (C) 2010 Free Software Foundation, Inc. [...] The fix is basically the same as: 6e5b95cdbd0e MIPS: Fix distclean with Makefile.postlink Regards, Horia
On Mon, May 8, 2017 at 8:50 AM, Horia Geantă <horia.geanta@nxp.com> wrote: > On 5/8/2017 2:57 PM, Michael Ellerman wrote: >> Horia Geantă <horia.geanta@nxp.com> writes: >> >>> Makefile.postlink always includes include/config/auto.conf, however >>> this file is not present in a clean kernel tree, causing make to fail: >>> >>> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory >>> make[1]: *** No rule to make target `include/config/auto.conf'. Stop. >>> make: *** [vmlinuxclean] Error 2 >>> >>> Change the inclusion such that file not being found does not trigger >>> an error. >>> >>> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations") >> >> I can't reproduce this. What exact steps are you doing? And what version >> of Make? >> > Start with a clean kernel tree and then > make distclean > arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such > file or directory > make[1]: *** No rule to make target `include/config/auto.conf'. Stop. > make: *** [vmlinuxclean] Error 2 > > make --version > GNU Make 3.82 > Built for x86_64-redhat-linux-gnu > Copyright (C) 2010 Free Software Foundation, Inc. > [...] > > The fix is basically the same as: > 6e5b95cdbd0e MIPS: Fix distclean with Makefile.postlink > Noticed it on the Fedora builds as well today. This patch fixes it. Tested-by: Justin M. Forbes <jforbes@fedoraproject.org>
On Mon, 2017-05-08 at 08:50:16 UTC, =?utf-8?q?Horia_Geant=C4=83?= wrote: > Makefile.postlink always includes include/config/auto.conf, however > this file is not present in a clean kernel tree, causing make to fail: > > arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory > make[1]: *** No rule to make target `include/config/auto.conf'. Stop. > make: *** [vmlinuxclean] Error 2 > > Change the inclusion such that file not being found does not trigger > an error. > > Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations") > Reported-by: Mircea Pop <mircea.pop@nxp.com> > Signed-off-by: Horia Geantă <horia.geanta@nxp.com> > Tested-by: Justin M. Forbes <jforbes@fedoraproject.org> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/24e0bfbf63bac18495b0ad76115269 cheers
diff --git a/arch/powerpc/Makefile.postlink b/arch/powerpc/Makefile.postlink index 3c22d64b2de9..eccfcc88afae 100644 --- a/arch/powerpc/Makefile.postlink +++ b/arch/powerpc/Makefile.postlink @@ -7,7 +7,7 @@ PHONY := __archpost __archpost: -include include/config/auto.conf +-include include/config/auto.conf include scripts/Kbuild.include quiet_cmd_relocs_check = CHKREL $@
Makefile.postlink always includes include/config/auto.conf, however this file is not present in a clean kernel tree, causing make to fail: arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory make[1]: *** No rule to make target `include/config/auto.conf'. Stop. make: *** [vmlinuxclean] Error 2 Change the inclusion such that file not being found does not trigger an error. Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations") Reported-by: Mircea Pop <mircea.pop@nxp.com> Signed-off-by: Horia Geantă <horia.geanta@nxp.com> --- arch/powerpc/Makefile.postlink | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)