| Message ID | de25b9a195ff29f7d4bbaec5af4c2f98532d1b9c.1493933558.git.jcody@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 05/04/2017 05:35 PM, Jeff Cody wrote: > In 88d8879, protocol drivers had modularization enabled. As VXHS is a > protocol, make sure it is able to be built as a module as well. > > Signed-off-by: Jeff Cody <jcody@redhat.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 48a9370..eada141 100755 > --- a/configure > +++ b/configure > @@ -5859,7 +5859,7 @@ if test "$pthread_setname_np" = "yes" ; then > fi > > if test "$vxhs" = "yes" ; then > - echo "CONFIG_VXHS=y" >> $config_host_mak > + echo "CONFIG_VXHS=m" >> $config_host_mak > echo "VXHS_LIBS=$vxhs_libs" >> $config_host_mak > fi > > ERROR: User requested feature vxhs block device configure was not able to find it. Install libvxhs See github wow gee, thanks configure file. I'll go "see github." Not actually that easy to find; separate patch, but could this be touched up?
On Mon, May 08, 2017 at 01:29:46PM -0400, John Snow wrote: > > > On 05/04/2017 05:35 PM, Jeff Cody wrote: > > In 88d8879, protocol drivers had modularization enabled. As VXHS is a > > protocol, make sure it is able to be built as a module as well. > > > > Signed-off-by: Jeff Cody <jcody@redhat.com> > > --- > > configure | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index 48a9370..eada141 100755 > > --- a/configure > > +++ b/configure > > @@ -5859,7 +5859,7 @@ if test "$pthread_setname_np" = "yes" ; then > > fi > > > > if test "$vxhs" = "yes" ; then > > - echo "CONFIG_VXHS=y" >> $config_host_mak > > + echo "CONFIG_VXHS=m" >> $config_host_mak > > echo "VXHS_LIBS=$vxhs_libs" >> $config_host_mak > > fi > > > > > > ERROR: User requested feature vxhs block device > configure was not able to find it. > Install libvxhs See github > > wow gee, thanks configure file. I'll go "see github." > > Not actually that easy to find; separate patch, but could this be > touched up? Sure, that is an easy touch up. I'll add it as a v2 to this patch.
diff --git a/configure b/configure index 48a9370..eada141 100755 --- a/configure +++ b/configure @@ -5859,7 +5859,7 @@ if test "$pthread_setname_np" = "yes" ; then fi if test "$vxhs" = "yes" ; then - echo "CONFIG_VXHS=y" >> $config_host_mak + echo "CONFIG_VXHS=m" >> $config_host_mak echo "VXHS_LIBS=$vxhs_libs" >> $config_host_mak fi
In 88d8879, protocol drivers had modularization enabled. As VXHS is a protocol, make sure it is able to be built as a module as well. Signed-off-by: Jeff Cody <jcody@redhat.com> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)