diff mbox

Freescale mpc8315 IRQ0 setup

Message ID 1715435.xdU3769208@sherry (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Juergen Schindele May 2, 2017, 12:43 p.m. UTC
Dear Scott,
sorry for the delay but i am not very familiar with the formating.
I passed the patch trough checkpatch.pl and there was no more error.
pease find patch in attached file.
Thanks

Comments

Crystal Wood May 3, 2017, 3:29 a.m. UTC | #1
On Tue, 2017-05-02 at 14:43 +0200, Juergen Schindele wrote:
> Dear Scott,
> sorry for the delay but i am not very familiar with the formating.
> I passed the patch trough checkpatch.pl and there was no more error.
> pease find patch in attached file.
> Thanks

Documentation/process/submitting-patches.rst explains the way to format and
submit kernel patches.

Also, why the unrelated change to a print statement in ipic_set_irq_type()?

-Scott
diff mbox

Patch

[PATCH] configure "EDGE" capabilities for IRQ0 (like IRQ1-7)
Signed-off-by: Jurgen Schindele <schindele@nentec.de>
--- linux-a/arch/powerpc/sysdev/ipic.c        2017-04-04 15:28:11.201308780 +0200
+++ linux-b/arch/powerpc/sysdev/ipic.c        2016-12-11 20:17:54.000000000 +0100
@@ -315,7 +315,6 @@  static struct ipic_info ipic_info[] = {
                .prio_mask = 7,
        },
        [48] = {
-               .ack    = IPIC_SEPNR,
                .mask   = IPIC_SEMSR,
                .prio   = IPIC_SMPRR_A,
                .force  = IPIC_SEFCR,
@@ -618,7 +617,7 @@  static int ipic_set_irq_type(struct irq_
        /* ipic supports only edge mode on external interrupts */
        if ((flow_type & IRQ_TYPE_EDGE_FALLING) && !ipic_info[src].ack) {
                printk(KERN_ERR "ipic: edge sense not supported on internal "
-                               "interrupts %d\n", src);
+				"interrupts\n");
                return -EINVAL;

        }